#64 Toolbar Toggle Buttons

[Tsu Jan]

Just a suggestion:

Wouldn't it be better if you remove the condition "if ( sameRoles )" from the line:

if ( sameRoles ) gt = Gradients::Sunken; // sunken dark active - mac-a-like

belonging to Style::drawToolButtonShape in toolbars.cpp? In this way, toolbar toggle buttons will be sunken when activated (for example, the browse and text selection buttons in Okular or view buttons in Dolphin), which seems more logical to me.

Sorry if "toolbar toggle button" or "activated" aren't correct terms for Qt. I've migrated to KDE recently and may still use GTK+ terms.