Menu

#44 device-device doesn't support cciss drives

open
5
2009-09-14
2009-09-13
Rohan Hart
No

ocs-onthefly doesn't detect cciss disks and partitions. Changing to use the common gen_proc_partitions_map_file function which in turn uses cciss_dev_map_if_necessary looks like it would do the trick.

Discussion

  • Steven Shiau

    Steven Shiau - 2009-09-14

    Thanks for the bug report. Could you please provide the patch file or give more details about the modifications you mentioned?
    Thanks in advance.

    Steven.

     
  • Steven Shiau

    Steven Shiau - 2009-09-14
    • assigned_to: nobody --> steven_shiau
     
  • Rohan Hart

    Rohan Hart - 2009-09-14

    Hi Steven

    I've no patch because it looks like a reasonably sizable change. I was comparing against ocs-sr where all these device checks are factored out into common functions in ocs-functions. Unfortunately ocs-onthefly does everything by hand with statements like:

    part_in_hd="$(LC_ALL=C grep -Eo "$source_hd[[:digit:]]+" /proc/partitions)"
    for part in $part_in_hd; do

    where $source_hd must look like [hs]d[a-z] which will never match the cciss partitions which look like cciss/c0d0p[1-9] for the cciss/c0d0 drive.

    The common code instead creates links called sda1, etc. for those devices and adds extra details everytime /proc/partitions is examined.

     
  • Steven Shiau

    Steven Shiau - 2009-09-15

    Thanks. Will try to make ocs-onthefly work with CCISS device in the future.

    Steven.

     

Log in to post a comment.