#419 Slow on find partition

[David NG]

I am on proxmox, it used zfs.
I notice clonezilla is very slow on below.
Finding all disks and partitions..
Excluding busy partition....
Excluding linux raid member partition.................................
Finding partitions..............................

after some testing, I found out the reason.
I got 8 disk, form a zraid2.
I run below command, it show this

lsblk -o type,name,label,partlabel,size,model,wwn,uuid | cat

TYPE NAME      LABEL           PARTLABEL              SIZE MODEL                 WWN                UUID
disk sda                                             12.7T WDC WUH721414ALE604   0x5000cca264d0d2bd 
part ├─sda1    zp814           zfs-8b70227a54c052e2  12.7T                       0x5000cca264d0d2bd 18146158256913063307
part └─sda9                                             8M                       0x5000cca264d0d2bd 
disk sdb                                             12.7T TOSHIBA MG07ACA14TE   0x5000039ab8d92d94 
part ├─sdb1    zp814           zfs-a86ce33206e9418f  12.7T                       0x5000039ab8d92d94 18146158256913063307
part └─sdb9                                             8M                       0x5000039ab8d92d94 
disk sdc                                             12.7T WDC WUH721414ALE6L4   0x5000cca290c94722 
part ├─sdc1    zp814           zfs-cf2306202cc79817  12.7T                       0x5000cca290c94722 18146158256913063307
part └─sdc9                                             8M                       0x5000cca290c94722 
disk sdd                                             12.7T WDC WUH721414ALE6L4   0x5000cca290ca4acb 
part ├─sdd1    zp814           zfs-399b633cafc6b195  12.7T                       0x5000cca290ca4acb 18146158256913063307
part └─sdd9                                             8M                       0x5000cca290ca4acb 
disk sde                                             12.7T WDC WUH721414ALE6L4   0x5000cca2adc8ded8 
part ├─sde1    zp814           zfs-9b7f7cfa345b2af2  12.7T                       0x5000cca2adc8ded8 18146158256913063307
part └─sde9                                             8M                       0x5000cca2adc8ded8 
disk sdf                                             12.7T WDC WUH721414ALE6L4   0x5000cca290c6826a 
part ├─sdf1    zp814           zfs-81a8a84db6c7f80a  12.7T                       0x5000cca290c6826a 18146158256913063307
part └─sdf9                                             8M                       0x5000cca290c6826a 
disk sdg                                             12.7T WDC WUH721414ALE6L4   0x5000cca2adc5f469 
part ├─sdg1    zp814           zfs-57b1c6070af1f540  12.7T                       0x5000cca2adc5f469 18146158256913063307
part └─sdg9                                             8M                       0x5000cca2adc5f469 
disk sdh                                             12.7T WDC WUH721414ALE6L4   0x5000cca2adc5cc23 
part ├─sdh1    zp814           zfs-06d5a0f39a657c9b  12.7T                       0x5000cca2adc5cc23 18146158256913063307
part └─sdh9                                             8M                       0x5000cca2adc5cc23 
disk sdi                                            931.5G CT1000MX500SSD1       0x500a0751e5d2a82a 
part ├─sdi1                                          1007K                       0x500a0751e5d2a82a 
part ├─sdi2                                             1G                       0x500a0751e5d2a82a F688-4409
part └─sdi3    rpool                                  930G                       0x500a0751e5d2a82a 7854791146800525414
disk sdj                                            931.5G CT1000MX500SSD1       0x500a0751e6e1836c 
part ├─sdj1                                          1007K                       0x500a0751e6e1836c 
part ├─sdj2                                             1G                       0x500a0751e6e1836c F689-55AD
part └─sdj3    rpool                                  930G                       0x500a0751e6e1836c 7854791146800525414
disk sdk                                            931.5G CT1000MX500SSD1       0x500a0751e6daaeff 
part ├─sdk1                                          1007K                       0x500a0751e6daaeff 
part ├─sdk2                                             1G                       0x500a0751e6daaeff F68A-6F58
part └─sdk3    rpool                                  930G                       0x500a0751e6daaeff 7854791146800525414
disk sdl                                            931.5G CT1000MX500SSD1       0x500a0751e6e1798c 
part ├─sdl1                                          1007K                       0x500a0751e6e1798c 
part ├─sdl2                                             1G                       0x500a0751e6e1798c F68B-B321
part └─sdl3    rpool                                  930G                       0x500a0751e6e1798c 7854791146800525414
disk sdm                                             16.4T WDC WD180EDGZ-11B2DA2 0x5000cca2b6d59cad 
part └─sdm1    USBWD2        My Book               16.4T                       0x5000cca2b6d59cac C696-12E2
disk sdn                                             16.4T WDC WD180EDGZ-11B2DA2 0x5000cca2ecc30eba 
part └─sdn1    USBWD1        My Book               16.4T                       0x5000cca2ecc30ebf 2AE5-8155
disk zd0                                                1M                                          
disk zd16                                               1M                                          
disk zd32                                             192G                                          
part ├─zd32p1  System Reserved                         50M                                          2C04521C0451E8FA
part └─zd32p2                                       191.9G                                          B6BAD16ABAD1281F
disk zd48                                              60G                                          
part ├─zd48p1  System Reserved                        350M                                          8092FBA492FB9D3A
part └─zd48p2  Win2012-Web_C                         59.7G                                          0E9CFE539CFE3535
disk zd64                                             192G                                          
part ├─zd64p1  System Reserved                         50M                                          2C04521C0451E8FA
part └─zd64p2                                       191.9G                                          B6BAD16ABAD1281F
disk zd80                                              64G                                          
part ├─zd80p1                                           1M                                          
part ├─zd80p2                  EFI System Partition   513M                                          089A-607E
part ├─zd80p3                                           2G                                          540f95e6-6746-441d-9938-36724473d313
part ├─zd80p4  bpool                                    2G                                          12894423480228953162
part └─zd80p5  oldrpool                              59.5G                                          1482310096226846928
disk zd96                                              65G                                          
part ├─zd96p1                                           1M                                          
part └─zd96p2                                          65G                                          028236c2-33b6-4ff9-bb2b-6358efb72085
disk zd112                                            256G                                          
part ├─zd112p1                                          1M                                          
part ├─zd112p2                 EFI System Partition   513M                                          C6D9-31AC
part └─zd112p3                                      255.5G                                          bcbfd9ae-b075-4070-8da5-e9da383cf072
disk zd128                                            192G                                          
part └─zd128p1 Web                                    128G                                          C4E04FA0E04F9816

the speed of the above is sort of ok, but still slow.
then I use
zfs mount -l zp8/ebackup
to import an encrypted zfs dataset which as a lot of zfs partition.
if I run below command, more partition will show up

lsblk -o type,name,label,partlabel,size,model,wwn,uuid | cat
// only show some of it, as the list is too long

disk zd416                                                     60G                                          part ├─zd416p1 System Reserved                                350M                                          8092FBA492FB9D3Apart └─zd416p2 Win2012-Web_C                                 59.7G                                          0E9CFE539CFE3535disk zd432                                                     64G                                          part ├─zd432p1                                                512M                                          68C8-8C0Bpart ├─zd432p2                                                  1K                                          part └─zd432p5                                               63.5G                                          c1002b9a-00e3-4b6d-b2cf-19aa205e227bdisk zd448                                                      1M                                          disk zd464                                                    107M                                          part ├─zd464p1                                                 16M                                          57f8f4bc-abf4-655f-bf67-946fc0f9f25bpart └─zd464p2                                                 90M                                          disk zd480                                                     55G                                          part ├─zd480p1                 EFI System Partition           512M                                          ADF1-5545part └─zd480p2                                               54.5G                                          403e2b91-672f-4535-b5e5-f3aa61bf0926disk zd496                                                     65G                                          part ├─zd496p1                                                  1M                                          part └─zd496p2                                                 65G                                          028236c2-33b6-4ff9-bb2b-6358efb72085disk zd512                                                     64G                                          part ├─zd512p1                                                  1M                                          part ├─zd512p2                 EFI System Partition           513M                                          C6D9-31ACpart └─zd512p3                                               63.5G                                          bcbfd9ae-b075-4070-8da5-e9da383cf072disk zd528                                                     50G                                          part ├─zd528p1                 EFI system partition           100M                                          F036-0342part ├─zd528p2                 Microsoft reserved partition    16M                                          part ├─zd528p3                 Basic data partition          49.4G                                          C4263AA0263A9380part └─zd528p4                                                516M                                          12C8B377C8B35825disk zd544                                                    128G                                          part └─zd544p1 Web                                            128G                                          C4E04FA0E04F9816

so the reason why clonezilla take forever on the partition is
it also look for the zfs partition.
please skip those zfs partition, as we only want save the "physical disk" or "physical partition"
or better, add option for us to choose

[David NG]

here, I show the difference between physical disk and zfs disk
lsblk -o type,name,label,partlabel,size,model,serial,wwn,uuid -J

physical

{
   "blockdevices": [
      {
         "type": "disk",
         "name": "sda",
         "label": null,
         "partlabel": null,
         "size": "12.7T",
         "model": "WDC WUH721414ALE604",
         "serial": "9RH608AC",
         "wwn": "0x5000cca264d0d2bd",
         "uuid": null,
         "children": [
            {
               "type": "part",
               "name": "sda1",
               "label": "zp814",
               "partlabel": "zfs-8b70227a54c052e2",
               "size": "12.7T",
               "model": null,
               "serial": null,
               "wwn": "0x5000cca264d0d2bd",
               "uuid": "18146158256913063307"
            },{
               "type": "part",
               "name": "sda9",
               "label": null,
               "partlabel": null,
               "size": "8M",
               "model": null,
               "serial": null,
               "wwn": "0x5000cca264d0d2bd",
               "uuid": null
            }
         ]
      },{
         "type": "disk",
         "name": "sdb",
         "label": null,
         "partlabel": null,
         "size": "12.7T",
         "model": "TOSHIBA MG07ACA14TE",
         "serial": "21X0A1AHF94G",
         "wwn": "0x5000039ab8d92d94",
         "uuid": null,
         "children": [
            {
               "type": "part",
               "name": "sdb1",
               "label": "zp814",
               "partlabel": "zfs-a86ce33206e9418f",
               "size": "12.7T",
               "model": null,
               "serial": null,
               "wwn": "0x5000039ab8d92d94",
               "uuid": "18146158256913063307"
            },{
               "type": "part",
               "name": "sdb9",
               "label": null,
               "partlabel": null,
               "size": "8M",
               "model": null,
               "serial": null,
               "wwn": "0x5000039ab8d92d94",
               "uuid": null
            }
         ]
      },{

zfs

      },{
         "type": "disk",
         "name": "zd528",
         "label": null,
         "partlabel": null,
         "size": "50G",
         "model": null,
         "serial": null,
         "wwn": null,
         "uuid": null,
         "children": [
            {
               "type": "part",
               "name": "zd528p1",
               "label": null,
               "partlabel": "EFI system partition",
               "size": "100M",
               "model": null,
               "serial": null,
               "wwn": null,
               "uuid": "F036-0342"
            },{
               "type": "part",
               "name": "zd528p2",
               "label": null,
               "partlabel": "Microsoft reserved partition",
               "size": "16M",
               "model": null,
               "serial": null,
               "wwn": null,
               "uuid": null
            },{
               "type": "part",
               "name": "zd528p3",
               "label": null,
               "partlabel": "Basic data partition",
               "size": "49.4G",
               "model": null,
               "serial": null,
               "wwn": null,
               "uuid": "C4263AA0263A9380"
            },{
               "type": "part",
               "name": "zd528p4",
               "label": null,
               "partlabel": null,
               "size": "516M",
               "model": null,
               "serial": null,
               "wwn": null,
               "uuid": "12C8B377C8B35825"
            }
         ]
      },{
         "type": "disk",
         "name": "zd544",
         "label": null,
         "partlabel": null,
         "size": "128G",
         "model": null,
         "serial": null,
         "wwn": null,
         "uuid": null,
         "children": [
            {
               "type": "part",
               "name": "zd544p1",
               "label": "Web",
               "partlabel": null,
               "size": "128G",
               "model": null,
               "serial": null,
               "wwn": null,
               "uuid": "C4E04FA0E04F9816"
            }
         ]
      }
   ]
}

[Steven Shiau]

Thanks for your feedback.
'"please skip those zfs partition, as we only want save the "physical disk" or "physical partition"' -> It will be great if you can provide us the patch file so that this is clearer to us.
Thanks.

Steven