Re: division by zero in new-clx

[Shawn B. <sa...@gm...>]

On Sat, Aug 29, 2009 at 7:37 PM, Sam Steingold<sd...@gn...> wrote:
>> * Shawn Betts <fnorggf@tznvy.pbz> [2009-08-25 21:07:31 -0700]:
>>
>> A user reports that mplayer 1.3 crashes stumpwm. The backtrace
>> revealed a problem in decode-wm-size-hints. Here's the call, taken
>> from that backtrace, that breaks new-clx.
>>
>> (xlib::decode-wm-size-hints #(924 0 528 0 349 0 624 0 352 0 4 0 4 0 0 0 0 0))
>>
>> It seems mplayer uses 0,0 for the max aspect ratio to mean that there
>> is no max aspect ratio.
>
> the culprit is the clx code present in all clx implementations I can see.
> IOW, this, I think, is a bug in mplayer: if they do not want to supply
> the aspect ratio, they should unset the 7th bit in the first vector element.
> I can, of course, add a workaround to this bug:

They do specify a min aspect ratio. I reported this as a bug to clisp
because I think the clx library should be robust enough to detect
badly formed properties and deal with them appropriately. Crashing
because of badly formatted data from another client is Bad! haven't
sent a report to mplayer but I will. I'll let you know if they have
anything interesting to say.

-Shawn