Re[4]: new feature of LAUNCH

[Arseny S. <am...@ic...>]

Hello Sam,

Sunday, August 31, 2003, 2:39:10 PM, you wrote:

> 1. in lispbibl.d, you do

> #if !defined(WIN32_NATIVE)
> #define INVALID_HANDLE_VALUE ((Handle)(-1))
> #endif

>    wouldn't it be better to do

> #if !defined(INVALID_HANDLE_VALUE)
> #define INVALID_HANDLE_VALUE ((Handle)(-1))
> #endif

Well, it's ok if INVALID_HANDLE_VALUE is always #define, but is it
possible for INVALID_HANDLE_VALUE to be a 'const int' for example ?

> 2. please compare the two launch implementations - you use HNULLP for
>    UNIX but stick with NULLs for win32.  This does not look right.
>    moreover, in the WIN32 LAUNCH, hnull is initialized to NULL and then
>    is checked for being non-NULL before anything is assigned to it.
>    This does not look right either.
I'll take this into account, but
NULLs - because I can! (do in on win32) 'if (handle)' - neat!
hnull is checked in all of 3 blocks to prepare them to become a macro
or function (iterational type of programming, not very good, but
better than nothing).
I'll probably merge both LAUNCHers. Most simple way of course is to
use diff and #ifdefs ;)

> PS. I am glad the bears and mosquitos did not finish you up :-)
Thank you :-) My boss(es) - that's what terrible :-)

-- 
Best regards,
 Arseny