RE: [Clirr-devel] CVS: clirr/core/src/java/net/sf/clirr/core/internal/checks InterfaceSetCheck.java,1.3,1.4

[Vincent M. <vma...@pi...>]

Hi Lars,

I've just tried it again with Clirr CVS HEAD on the cactus framework and
still got an NPE:

BUILD FAILED
java.lang.NullPointerException
        at
org.apache.bcel.classfile.JavaClass.getAllInterfaces(JavaClass.java:808)
        at
net.sf.clirr.core.internal.checks.InterfaceSetCheck.check(InterfaceSetChe=
ck.
java:58)
        at net.sf.clirr.core.Checker.runClassChecks(Checker.java:361)
        at net.sf.clirr.core.Checker.reportDiffs(Checker.java:315)
        at net.sf.clirr.core.Checker.reportDiffs(Checker.java:174)
        at net.sf.clirr.ant.AntTask.execute(AntTask.java:267)
        at org.apache.tools.ant.Task.perform(Task.java:341)
        at =
org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:232)

Any idea?

Thanks
-Vincent

> -----Original Message-----
> From: cli...@li... [mailto:clirr-devel-
> ad...@li...] On Behalf Of Lars K=FChne
> Sent: samedi 21 ao=FBt 2004 13:11
> To: cli...@li...
> Subject: [Clirr-devel] CVS:
> clirr/core/src/java/net/sf/clirr/core/internal/checks
> InterfaceSetCheck.java,1.3,1.4
>=20
> Update of
> /cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/checks
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24975
>=20
> Modified Files:
> 	InterfaceSetCheck.java
> Log Message:
> avoid ClassCastException that was caused by adding Strings to a Set =
and
> trying to extract JavaClass objects later
> This should fix the Maven plugin problem that Vincent experienced
>=20
> Index: InterfaceSetCheck.java
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file:
> =
/cvsroot/clirr/clirr/core/src/java/net/sf/clirr/core/internal/checks/Inte=
r
> faceSetCheck.java,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -r1.3 -r1.4
> --- InterfaceSetCheck.java	16 Jul 2004 10:16:50 -0000	1.3
> +++ InterfaceSetCheck.java	21 Aug 2004 11:10:37 -0000	1.4
> @@ -19,8 +19,8 @@
>=20
>  package net.sf.clirr.core.internal.checks;
>=20
> -import java.util.HashSet;
>  import java.util.Set;
> +import java.util.TreeSet;
>=20
>  import net.sf.clirr.core.Severity;
>  import net.sf.clirr.core.Message;
> @@ -110,13 +110,20 @@
>          return true;
>      }
>=20
> +    /**
> +     * Creates a Set of JavaClass objects.
> +     * @param classes the classes to include in the set, might =
contain
> duplicates
> +     * @return Set<JavaClass>
> +     */
>      private Set createClassSet(JavaClass[] classes)
>      {
> -        Set current =3D new HashSet();
> +        // JavaClass does not define equals(), so we use a Set
> implementation
> +        // that determines equality by invoking a Comparator instead =
of
> calling equals()
> +
> +        Set current =3D new =
TreeSet(JavaClassNameComparator.COMPARATOR);
>          for (int i =3D 0; i < classes.length; i++)
>          {
> -            String currentInterface =3D classes[i].getClassName();
> -            current.add(currentInterface);
> +            current.add(classes[i]);
>          }
>          return current;
>      }
>=20
>=20
>=20
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
> _______________________________________________
> Clirr-devel mailing list
> Cli...@li...
> https://lists.sourceforge.net/lists/listinfo/clirr-devel