[Clirr-devel] CVS: clirr/core/src/test/net/sf/clirr/core/internal/checks TestDiffListener.java,1.3,1.4

[Simon K. <s_k...@us...>]

Update of /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv17934

Modified Files:
	TestDiffListener.java 
Log Message:
Generate much more readable error messages.


Index: TestDiffListener.java
===================================================================
RCS file: /cvsroot/clirr/clirr/core/src/test/net/sf/clirr/core/internal/checks/TestDiffListener.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TestDiffListener.java	18 Jul 2004 01:12:42 -0000	1.3
+++ TestDiffListener.java	20 Jul 2004 07:53:23 -0000	1.4
@@ -42,16 +42,21 @@
                     MessageTranslator translator = new MessageTranslator();
 
                     StringBuffer buf = new StringBuffer();
-                    buf.append("Expected diff " + expected + " was not generated.");
-                    buf.append(" Actual diffs generated were: ");
-                    for(Iterator diffIter = diffs.iterator(); diffIter.hasNext();)
+                    buf.append("Expected diff " + expected + " was not generated.\n");
+                    if (diffs.size() == 0)
                     {
-                        ApiDifference diff = (ApiDifference) diffIter.next();
-
-                        buf.append(diff.toString(translator));
-                        if (diffIter.hasNext())
+                        buf.append("No diffs were generated.");
+                    }
+                    else
+                    {
+                        buf.append("Actual diffs generated were: \n");
+                        for(Iterator diffIter = diffs.iterator(); diffIter.hasNext();)
                         {
-                            buf.append(", ");
+                            ApiDifference diff = (ApiDifference) diffIter.next();
+
+                            buf.append(" * ");
+                            buf.append(diff.toString(translator));
+                            buf.append("\n");
                         }
                     }
 
@@ -60,7 +65,7 @@
             }
 
             StringBuffer buf = null;
-            for (Iterator it = diffs.iterator(); it.hasNext();) 
+            for (Iterator it = diffs.iterator(); it.hasNext();)
             {
                 ApiDifference actual = (ApiDifference) it.next();
 
@@ -76,13 +81,11 @@
                     if (buf == null)
                     {
                         buf = new StringBuffer();
-                        buf.append("Unexpected diffs: ");
-                    }
-                    else
-                    {
-                        buf.append(", ");
+                        buf.append("Unexpected diffs:\n");
                     }
+                    buf.append(" * ");
                     buf.append(actual.toString(translator));
+                    buf.append("\n");
                 }
             }