Re: [Clirr-devel] maven plugin

[<lak...@t-...>]

Simon Kitching wrote:

>[...]
>
>I have only one (minor) reservation about your original proposal. I did
>raise this by email, but didn't see any response. It is the matter of
>moving the "cli" stuff into a subpackage. I think the command
>  java net.sf.clirr.cli.Clirr
>is already quite long enough without moving the cli stuff into a
>subpackage :-).
>
>  
>

If we create an uberjar that includes our dependencies that problem goes 
away - you can do

java -jar clirr-uberjar.jar

But still you're right - in a small project like this it should not be 
necessary to have too many package levels.

>[...]
>  
>
>>The simplest thing is to create a module 'core' and simply move 
>>everything we have now (including cli and ant) into that module. You can 
>>then start committing the Maven plugin into a different module, so we 
>>end up with two multiproject modules, 'core' and 'maven'.
>>    
>>
>
>That would make the start command for the cli into this?
>  java net.sf.clirr.core.cli.Clirr 
>
>  
>

No, that's not what I meant, see below.

>>I'm not convinced anyway that it makes sense to have cli and ant in 
>>different packages: the jar would basically consist of one class file... 
>>If someone disagrees we can do further split-up later.
>>    
>>
>
>I tend to agree.
>
>  
>

OK, so the plan is to have two top level modules, core and maven.

The top level package structure is not affected by that move, I don't 
think Maven requires the module name to occur as a package name. This 
means we can have:

clirr-core.jar
+ n.s.c.core (includes only Checker)
+ n.s.c.core.event
+ n.s.c.core.internal.framework (not to be used by integration frontends)
+ n.s.c.core.internal.checks (dito)
+ n.s.c.cli
+ n.s.c.ant

On our web site we can follow Vincent's suggestion and have a toplevel 
menu entry like

Integrations
+ Ant
+ Command Line
+ Maven

[...]

>>I can understand your frustration, and I think we should start using 
>>multiproject next weekend (or earlier if everyone agrees - Simon, please 
>>speak up).
>>    
>>
>
>Fine by me. Don't worry about causing any problems for code I've got
>outstanding; I can deal with any problems that turn up.
>
>  
>

OK, I have saved my local changes (check method exceptions) in a patch 
that I can apply after the code has moved. It seems everybody is ready 
for the move, so I'll make it official:

!! Please do not commit anything into the old structure from this point, 
you might risk losing your work. !!

Vincent, you can start moving core to it's sub-module and add the maven 
plugin. Do you need help or is it easier for you if you do it alone?

>>>On a positive note, I'd really like to try using Clirr on my project at
>>>work. I've convinced other people that we should try it. As we're using
>>>Maven, I'd like to have a Maven plugin working quickly.
>>>      
>>>
>
>I've been thinking it's about time for a 0.4 release. If you're
>interested in getting others to use clirr then it might be a good idea
>to get this new release out the door.
>
>  
>

Yep, let's get that Maven plugin ready and then release 0.4.

Lars