Re: [Clirr-devel] Removing class from hierarchy generates "removed interface" alerts
Status: Alpha
Brought to you by:
lkuehne
From: <lak...@t-...> - 2004-06-21 14:59:40
|
Hi Simon, consider a class "public class MyList extends AbstractList {...}". If you remove the extends clause completely ("public class MyList {...}"), Clirr should really report that MyList is not even a List any more. It's very different from changing it to "public class MyList implements List {...}". Both changes are technically incompatible, but you really need all information if you have to decide whether such a change is acceptable. -1 for removing those messages. Cheers, Lars PS: Good to hear about those good results! Simon Kitching wrote: >Hi, > >I've tried running the latest clirr against commons-digester-1.5 vs >commons-digester HEAD (because I'm familiar with the changes that ought >to be reported). It looks pretty good, but raises one issue. > >When a class is removed from the inheritance hierarcy for class X, we >also generate a bunch of alerts like: > Interface Y removed from class X > Interface Z removed from class X >because the removed class implemented those interfaces. > >Should we suppress these alerts in some way, or not? It does generate >quite a cascade of errors, but I'm not sure it is safe to simply omit >alerts for these no-longer-implemented interfaces.. > > >Cheers, > >Simon > > > > |