[Clirr-devel] comments on recent commits

[Simon K. <si...@ec...>]

Hi Lars,

Thought I'd gone a bit quiet on the clirr development? Nope, just was
working on a rather tricky bit of code :-).

It took me a while to figure out how to determine the real scope of a
nested class - see method ScopeSelector.getClassScope, it's a beauty!

I'm slowly working my way through chapter 13 of the java specification
(the binary compatibility bit); I presume you've been though that too.
That's something I would never have done if I hadn't started working on
clirr!

Hopefully these changes are OK by you. There isn't anything
controversial in there, I think, except possibly having the check method
return a boolean. As you can see from the ClassScopeCheck method, this
allows a check to indicate that there isn't any point applying further
changes. Maybe this feature could be used in the GenderCheck, to avoid
having to have this rather ugly check in MethodSetCheck?

  if (compatBaseline.isInterface() ^ currentVersion.isInterface())
  {
      return true;
  }


Catch you later,

Simon