[Clirr-devel] CVS: clirr/src/java/net/sf/clirr/framework JavaClassNameComparator.java,1.1,1.2

[<lk...@us...>]

Update of /cvsroot/clirr/clirr/src/java/net/sf/clirr/framework
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23835

Modified Files:
	JavaClassNameComparator.java 
Log Message:
made JavaClassNameComparator a singleton
fixed checkstyle errors

Index: JavaClassNameComparator.java
===================================================================
RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/framework/JavaClassNameComparator.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JavaClassNameComparator.java	13 Jun 2004 09:27:10 -0000	1.1
+++ JavaClassNameComparator.java	13 Jun 2004 10:39:09 -0000	1.2
@@ -25,17 +25,32 @@
 /**
  * A class which specifies that JavaClass instances are ordered
  * by string comparisons of their names.
+ *
+ * @author Simon Kitching
  */
 
-public class JavaClassNameComparator implements Comparator
+public final class JavaClassNameComparator implements Comparator
 {
-    public static final JavaClassNameComparator COMPARATOR = 
+    /**
+     * A JavaClassNameComparator does not carry any state,
+     * so only this singleton instance should be used.
+     */
+    public static final JavaClassNameComparator COMPARATOR =
         new JavaClassNameComparator();
-        
+
+    /**
+     * Prevents external instantiation.
+     * Clients should use {@link #COMPARATOR} exclusively.
+     */
+    private JavaClassNameComparator()
+    {
+    }
+
+    /** @see Comparator#compare */
     public int compare(Object o1, Object o2)
     {
-        String n1 = ((JavaClass)o1).getClassName();
-        String n2 = ((JavaClass)o2).getClassName();
+        String n1 = ((JavaClass) o1).getClassName();
+        String n2 = ((JavaClass) o2).getClassName();
         return n1.compareTo(n2);
     }
 }