From: Simon K. <si...@ec...> - 2004-06-01 06:52:36
|
Hi, Well, here's my first patch proposal for your consideration. When generating reports, users may want to see differences in package or even private-scope objects. Currently, clirr hardwires "public|private" in a number of places. This patch is intended to introduce a more flexible way of managing what objects get selected. The unit tests don't currently pass. I believe this is just because the "report" message strings are now a little different. I will try to figure out the easiest way to update these in the unit tests soon. In the meantime, any feedback on this code would be appreciated. The ScopeSelector.java file belongs in the "event" package. I do need to write some unit tests for this code, but wanted to get some feedback on the initial code first. NB: the diffs also report the line with "Lars Kuhne" has changed in this file. This is some side-effect of the fact that the u-umlaut cannot be represented in ascii. It's either CVS or jedit that's having problems with this char, probably also related to my system language setting. If you like this patch, then some code should probably be written to allow ANT options to select the scope. My next patch proposal will provide a way to run tests from the command-line, rather than needing to be invoked from Ant, and will provide a way to set the selected scope. It's almost ready. Cheers, Simon |