RE: [Clirr-devel] [Patch] minor improvements
Status: Alpha
Brought to you by:
lkuehne
From: Vincent M. <vm...@pi...> - 2004-05-25 07:28:03
|
> -----Original Message----- > From: cli...@li... [mailto:clirr-devel- > ad...@li...] On Behalf Of Lars K=FChne > Sent: 25 May 2004 07:16 > To: cli...@li... > Subject: Re: [Clirr-devel] [Patch] minor improvements >=20 > Committed, thanks! >=20 > You can simply commit simple fixes like these - I'll scan the commit > messages and we can revert the changes if there are problems. I think > review/discussion is only required for major changes that are not so > easy to revert with CVS, e.g. >=20 > * Changing the build process (make it a multiproject reactor build, > use Centipede or Ant instead of Maven, ...) > * Adding new source packages or changing package names > * Adding new distributables, i.e. stuff that is released > independently (for example a Maven plugin, an Eclipse plugin, etc.) > * ... you get the idea >=20 > That's how we work on the checkstyle team, and it seems to work well > there. Agreed. As I had not contributed in a long time, I preferred to send the patch instead of committing right away in order to re-establish a dialogue :-) Now that it's done and that you are ok for me to commit, I'll commit simple things like this one. BTW, I'm trying to find some time to write the Maven plugin for clirr (it's really simple to do - I probably need about 2-3 hours end to end). Are you still happy if I commit it to the clirr CVS? If so, before being able to commit it, we need to restructure the CVS directory structure. Here's what I propose: clirr |_ framework |_ [move everything that is currently in clirr/] |_ maven I'll also provide the top level maven.xml that builds the whole thing. What do you think? >=20 > BTW, I'm using Maven 1.0 RC1 and the "nonsense link" is still there - > guess it's time to upgrade... Will Maven 1.0 final be released shortly > or does it make sense to install RC3 now? Hmmm.... I didn't see any link but maybe I was not looking at the right place. Could you explain where you see this link? >=20 > Where can I see an example of an auto-generated download page? We need > to make sure that our releases are distributed via the sourceforge > mirrors (or ibiblio), and not via our web site... Is that possible? Here's an example: To run it, you simply need to define the maven.xdoc.distributionUrl property. For example: maven.xdoc.distributionUrl=3Dhttp://www.ibiblio.org/maven/maven/plugins The xdoc plugin will generate the download page. However, it will construct the full URL this way: ${maven.xdoc.distributionUrl}/${pom.artifactId}-${version}.jar Thus we would need to find a SF URL that matches this. The problem I think is that SF URLs contain numbers and not artifact ids. That's unless we point directly to a mirror...=20 -Vincent >=20 > Thanks, > Lars >=20 >=20 > Vincent Massol wrote: >=20 > >Hi Lars, > > > >As I have never committed yet on this project (AFAIC recall...), here's > >a patch for minor things: > > > >- added target to ignore list > >- fixed my timezone > >- removed TODO about some "nonsense link" as I don't see it anymore. > >Must have been fixed. > >- fixed maven version required in xdocs. BTW, I've just built it on > >Maven rc3 and it works fine > >- bumped version > >- fixed shortDescription which must be under 49 chars as it is used in > >the generated jar manifest as description. > >- added <versions> tags in project.xml. BTW, they can be used to > >automatically generate a download page if you're interested. > > > >Thanks > >-Vincent > > > > >=20 >=20 >=20 > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3D3149&alloc_id=3D8166&op=3Dclick > _______________________________________________ > Clirr-devel mailing list > Cli...@li... > https://lists.sourceforge.net/lists/listinfo/clirr-devel |