[Clirr-devel] CVS: clirr/src/java/net/sf/clirr/checks ClassHierarchyCheck.java,1.8,1.9

[Lars K?h. <lk...@us...>]

Update of /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29623/src/java/net/sf/clirr/checks

Modified Files:
	ClassHierarchyCheck.java 
Log Message:
Warn about introducing new superclasses for Exceptions.
Also added unit tests for class hierarchy check.

Index: ClassHierarchyCheck.java
===================================================================
RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks/ClassHierarchyCheck.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- ClassHierarchyCheck.java	22 May 2004 13:26:03 -0000	1.8
+++ ClassHierarchyCheck.java	23 May 2004 14:27:46 -0000	1.9
@@ -74,6 +74,16 @@
         JavaClass[] compatSuper = compatBaseline.getSuperClasses();
         JavaClass[] currentSuper = currentVersion.getSuperClasses();
 
+        boolean isThrowable = false;
+        for (int i = 0; i < compatSuper.length; i++)
+        {
+            JavaClass javaClass = compatSuper[i];
+            if ("java.lang.Throwable".equals(javaClass.getClassName()))
+            {
+                isThrowable = true;
+            }
+        }
+
         List added = getSetDifference(currentSuper, compatSuper);
         List removed = getSetDifference(compatSuper, currentSuper);
 
@@ -82,7 +92,7 @@
         {
             String s = (String) added.get(i);
             log("Added " + s + " to the list of superclasses of " + className,
-                    Severity.INFO, className, null, null);
+                    isThrowable ? Severity.WARNING : Severity.INFO, className, null, null);
         }
 
         for (int i = 0; i < removed.size(); i++)