[Clirr-devel] CVS: clirr/src/java/net/sf/clirr/checks FieldSetCheck.java,1.1,1.2

[Lars K?h. <lk...@us...>]

Update of /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks
In directory sc8-pr-cvs1:/tmp/cvs-serv22034/src/java/net/sf/clirr/checks

Modified Files:
	FieldSetCheck.java 
Log Message:
some todo comments

Index: FieldSetCheck.java
===================================================================
RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks/FieldSetCheck.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- FieldSetCheck.java	31 Dec 2003 09:48:08 -0000	1.1
+++ FieldSetCheck.java	11 Jan 2004 14:53:47 -0000	1.2
@@ -119,6 +119,8 @@
         }
 
         // TODO: Check field types
+
+        // TODO: warn about constant value changes (see JLS, section 13.4.8)
     }
 
     private void checkForModifierChange(Field bField, Field cField, JavaClass clazz)
@@ -143,7 +145,10 @@
             fireDiff("Field " + bField.getName() + " is now static", Severity.ERROR, clazz, cField);
         }
 
-        // TODO: What about transient and volatile?
+        // JLS, 13.4.10: Adding or deleting a transient modifier of a field
+        // does not break compatibility with pre-existing binaries
+
+        // TODO: What about volatile?
     }
 
     private void checkForVisibilityChange(Field bField, Field cField, JavaClass clazz)