From: Lars K?h. <lk...@us...> - 2003-12-28 09:39:54
|
Update of /cvsroot/clirr/clirr/src/java/net/sf/clirr/event In directory sc8-pr-cvs1:/tmp/cvs-serv18755/src/java/net/sf/clirr/event Modified Files: ApiDifference.java XmlDiffListener.java Log Message: fixed checkstyle "line too long" and "trailing whitespace" errors Index: ApiDifference.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/event/ApiDifference.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- ApiDifference.java 27 Dec 2003 19:08:42 -0000 1.5 +++ ApiDifference.java 28 Dec 2003 09:39:47 -0000 1.6 @@ -22,7 +22,7 @@ /** * Describes an API change. - * + * * @author Lars */ public final class ApiDifference @@ -67,7 +67,7 @@ /** * Create a new API differnce representation. - * + * * @param report a human readable string describing the change that was made. * @param severity the severity in terms of binary API compatibility. */ @@ -85,7 +85,7 @@ * definately break, WARNING means that clients may break, depending * on how they use the library. See the eclipse paper for further * explanation. - * + * * @return the severity of the API difference. */ public Severity getSeverity() @@ -95,7 +95,7 @@ /** * Human readable api change description. - * + * * @return a human readable description of this API difference. */ public String getReport() @@ -147,19 +147,26 @@ { return false; } + if (severity != null ? !severity.equals(other.severity) : other.severity != null) { return false; } - if (affectedClass != null ? !affectedClass.equals(other.affectedClass) : other.affectedClass != null) + + final String otherClass = other.affectedClass; + if (affectedClass != null ? !affectedClass.equals(otherClass) : otherClass != null) { return false; } - if (affectedMethod != null ? !affectedMethod.equals(other.affectedMethod) : other.affectedMethod != null) + + final String otherMethod = other.affectedMethod; + if (affectedMethod != null ? !affectedMethod.equals(otherMethod) : otherMethod != null) { return false; } - if (affectedField != null ? !affectedField.equals(other.affectedField) : other.affectedField != null) + + final String otherField = other.affectedField; + if (affectedField != null ? !affectedField.equals(otherField) : otherField != null) { return false; } Index: XmlDiffListener.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/event/XmlDiffListener.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- XmlDiffListener.java 27 Dec 2003 19:08:42 -0000 1.6 +++ XmlDiffListener.java 28 Dec 2003 09:39:47 -0000 1.7 @@ -26,7 +26,7 @@ * A DiffListener that reports any detected difference to * an XML file. That file can be used by subsequent processing steps * to create nice looking reports in HTML, PDF, etc. - * + * * @author lkuehne */ public final class XmlDiffListener extends FileDiffListener @@ -59,7 +59,7 @@ /** * Writes an XML header and toplevel tag to the xml stream. - * + * * @see DiffListener#start() */ public void start() @@ -80,7 +80,7 @@ /** * Closes the toplevel tag that was opened in start. - * + * * @see DiffListener#stop() */ protected void writeFooter() |