Menu
▾
▴
clirr-devel — Discussion about the source code of Clirr
You can subscribe to this list here.
| 2003 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(15) |
Oct
(23) |
Nov
|
Dec
(25) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2004 |
Jan
(9) |
Feb
|
Mar
|
Apr
|
May
(76) |
Jun
(207) |
Jul
(242) |
Aug
(42) |
Sep
(33) |
Oct
|
Nov
(7) |
Dec
(1) |
| 2005 |
Jan
|
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
|
Jul
(3) |
Aug
(66) |
Sep
(38) |
Oct
(6) |
Nov
|
Dec
(2) |
| 2006 |
Jan
(17) |
Feb
(5) |
Mar
(28) |
Apr
(6) |
May
|
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
(1) |
Nov
(1) |
Dec
(7) |
| 2007 |
Jan
|
Feb
|
Mar
|
Apr
(7) |
May
(33) |
Jun
(4) |
Jul
(3) |
Aug
|
Sep
(5) |
Oct
|
Nov
|
Dec
|
| 2008 |
Jan
(4) |
Feb
(3) |
Mar
(2) |
Apr
|
May
(1) |
Jun
|
Jul
(6) |
Aug
(8) |
Sep
(5) |
Oct
(20) |
Nov
(7) |
Dec
(9) |
| 2009 |
Jan
(8) |
Feb
(3) |
Mar
(20) |
Apr
(10) |
May
(40) |
Jun
(11) |
Jul
(23) |
Aug
(4) |
Sep
(1) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2010 |
Jan
(5) |
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
(1) |
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2011 |
Jan
|
Feb
|
Mar
|
Apr
(3) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
| 2012 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
(6) |
May
(22) |
Jun
(2) |
Jul
|
Aug
|
Sep
|
Oct
(2) |
Nov
(1) |
Dec
(2) |
| 2014 |
Jan
(5) |
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
| 2015 |
Jan
(1) |
Feb
(2) |
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2016 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
|
| 2017 |
Jan
|
Feb
|
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Lars K?h. <lk...@us...> - 2004-05-25 04:38:51
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7706 Modified Files: download.xml Log Message: changed required maven version Index: download.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/download.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- download.xml 23 May 2004 09:14:44 -0000 1.5 +++ download.xml 25 May 2004 04:38:42 -0000 1.6 @@ -32,9 +32,7 @@ </p> <ul> <li> - the latest release of <a - href="http://maven.apache.org">Maven</a>, at the time of - writing that's beta-10. + <a href="http://maven.apache.org">Maven</a> 1.0 RC1 or above. </li> <li> A CVS client. If you are on Linux you probably |
|
From: Lars K?h. <lk...@us...> - 2004-05-25 04:36:58
|
Update of /cvsroot/clirr/clirr In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7418 Modified Files: project.xml Log Message: - added versions section - fixed shortdescription so it's short enough for jar manifest - several other small issues all contributed by vmassol Index: project.xml =================================================================== RCS file: /cvsroot/clirr/clirr/project.xml,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- project.xml 23 May 2004 14:58:18 -0000 1.18 +++ project.xml 25 May 2004 04:36:47 -0000 1.19 @@ -12,7 +12,7 @@ <!-- The version of the project under development, e.g. 1.1, 1.2, 2.0-dev --> - <currentVersion>0.3</currentVersion> + <currentVersion>0.4-SNAPSHOT</currentVersion> <!-- details about the organization that 'owns' the project --> <organization> @@ -26,10 +26,6 @@ <package>net.sf.clirr</package> <logo>/images/clirr.png</logo> <description> - Checks Java libraries for binary compatibility with older releases. - </description> - <!-- a short description of what the project does --> - <shortDescription> Clirr is a tool that checks Java libraries for binary compatibility with older releases. Basically you give it two sets of jar files and Clirr dumps out a list of changes in the public @@ -37,15 +33,16 @@ the build if it detects incompatible api changes. In a continuous integration process Clirr can automatically prevent accidental introduction of binary compatibility problems in Java libraries. + </description> + <!-- a short description of what the project does --> + <shortDescription> + Java binary compatibility checker </shortDescription> <!-- the project home page --> <url>http://clirr.sourceforge.net/</url> <issueTrackingUrl>https://sourceforge.net/tracker/?group_id=89627&atid=590799</issueTrackingUrl> <siteAddress>shell.sourceforge.net</siteAddress> -<!-- - <siteDirectory>/home/lk/rmdir</siteDirectory> ---> <siteDirectory>/home/groups/c/cl/clirr/htdocs/</siteDirectory> <distributionSite>shell.sourceforge.net</distributionSite> <distributionDirectory>/home/groups/c/cl/clirr/htdocs/builds/</distributionDirectory> @@ -57,6 +54,24 @@ <url>http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/clirr</url> </repository> + <versions> + <version> + <id>0.2</id> + <name>0.2</name> + <tag>RELEASE_CLIRR_0_2</tag> + </version> + <version> + <id>0.3</id> + <name>0.3</name> + <tag>RELEASE_CLIRR_0_3</tag> + </version> + <version> + <id>0.4</id> + <name>0.4</name> + <tag>HEAD</tag> + </version> + </versions> + <!-- any mailing lists for the project --> <mailingLists> <mailingList> @@ -91,6 +106,7 @@ <id>vmassol</id> <email></email> <organization>Apache Software Foundation</organization> + <timezone>+1</timezone> <url>http://blogs.codehaus.org/people/vmassol</url> <roles> <role>Initial Inspiration and Feedback</role> |
|
From: Lars K?h. <lk...@us...> - 2004-05-25 04:31:07
|
Update of /cvsroot/clirr/clirr In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6597 Modified Files: .cvsignore Log Message: added "target" (contributed by vmassol) Index: .cvsignore =================================================================== RCS file: /cvsroot/clirr/clirr/.cvsignore,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- .cvsignore 14 Sep 2003 11:09:01 -0000 1.1 +++ .cvsignore 25 May 2004 04:30:43 -0000 1.2 @@ -3,3 +3,4 @@ clirr.iws clirr.ipr clirr.iml +target |
|
From: <lak...@t-...> - 2004-05-24 04:13:23
|
Sure, go ahead. Vincent Massol wrote: >Hi Lars, > >If you're interested, I can deploy the 0.3 release of Clirr on >ibiblio.org? > >Thanks >-Vincent > > > |
|
From: Vincent M. <vm...@pi...> - 2004-05-23 16:33:25
|
Hi Lars, As I have never committed yet on this project (AFAIC recall...), here's a patch for minor things: - added target to ignore list - fixed my timezone - removed TODO about some "nonsense link" as I don't see it anymore. Must have been fixed. - fixed maven version required in xdocs. BTW, I've just built it on Maven rc3 and it works fine - bumped version - fixed shortDescription which must be under 49 chars as it is used in the generated jar manifest as description. - added <versions> tags in project.xml. BTW, they can be used to automatically generate a download page if you're interested. Thanks -Vincent |
|
From: Vincent M. <vm...@pi...> - 2004-05-23 16:27:54
|
Hi Lars, If you're interested, I can deploy the 0.3 release of Clirr on ibiblio.org? Thanks -Vincent |
|
From: <lak...@t-...> - 2004-05-23 15:28:00
|
Hi, Clirr 0.3 is available. A detailed list of changes is available at http://clirr.sourceforge.net/changes-report.html. Enjoy, Lars |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 15:10:35
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv5075 Modified Files: changes.xml Log Message: set release day for 0.3 Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/changes.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- changes.xml 23 May 2004 14:27:47 -0000 1.6 +++ changes.xml 23 May 2004 15:10:25 -0000 1.7 @@ -7,7 +7,7 @@ </properties> <body> - <release version="0.3" date="in CVS"> + <release version="0.3" date="2004-05-23"> <action dev="lkuehne" due-to="Stephen Colebourne" type="fix"> Fixed a copy + paste error in field modifier comparison logic that would lead to false alarms and undetected compatibility |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:58:36
|
Update of /cvsroot/clirr/clirr In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2796 Modified Files: project.xml Log Message: prepare for release 0.3 Index: project.xml =================================================================== RCS file: /cvsroot/clirr/clirr/project.xml,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- project.xml 23 May 2004 07:55:14 -0000 1.17 +++ project.xml 23 May 2004 14:58:18 -0000 1.18 @@ -12,7 +12,7 @@ <!-- The version of the project under development, e.g. 1.1, 1.2, 2.0-dev --> - <currentVersion>0.3-dev</currentVersion> + <currentVersion>0.3</currentVersion> <!-- details about the organization that 'owns' the project --> <organization> |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:57:43
|
Update of /cvsroot/clirr/clirr/src/testinput/testlib-v2/testlib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2641/testinput/testlib-v2/testlib Modified Files: ApplicationException.java Log Message: use a more complicated exception hierarchy in test for added superclass Exception Index: ApplicationException.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/testinput/testlib-v2/testlib/ApplicationException.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ApplicationException.java 23 May 2004 14:27:46 -0000 1.1 +++ ApplicationException.java 23 May 2004 14:57:27 -0000 1.2 @@ -1,5 +1,5 @@ package testlib; -public class ApplicationException extends RuntimeException +public class ApplicationException extends java.util.NoSuchElementException { } |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:57:43
|
Update of /cvsroot/clirr/clirr/src/testinput/testlib-v1/testlib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2641/testinput/testlib-v1/testlib Modified Files: ApplicationException.java Log Message: use a more complicated exception hierarchy in test for added superclass Exception Index: ApplicationException.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/testinput/testlib-v1/testlib/ApplicationException.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ApplicationException.java 23 May 2004 14:27:46 -0000 1.1 +++ ApplicationException.java 23 May 2004 14:57:27 -0000 1.2 @@ -1,5 +1,5 @@ package testlib; -public class ApplicationException extends Exception +public class ApplicationException extends RuntimeException { } |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:57:37
|
Update of /cvsroot/clirr/clirr/src/test/net/sf/clirr/checks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2641/test/net/sf/clirr/checks Modified Files: ClassHierarchyCheckTest.java Log Message: use a more complicated exception hierarchy in test for added superclass Exception Index: ClassHierarchyCheckTest.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/test/net/sf/clirr/checks/ClassHierarchyCheckTest.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ClassHierarchyCheckTest.java 23 May 2004 14:27:46 -0000 1.1 +++ ClassHierarchyCheckTest.java 23 May 2004 14:57:27 -0000 1.2 @@ -12,7 +12,7 @@ public void testHierarchyChangesAreReported() { ApiDifference[] expected = new ApiDifference[] { - new ApiDifference("Added java.lang.RuntimeException to the list of superclasses of testlib.ApplicationException", Severity.WARNING, "testlib.ApplicationException", null, null), + new ApiDifference("Added java.util.NoSuchElementException to the list of superclasses of testlib.ApplicationException", Severity.WARNING, "testlib.ApplicationException", null, null), new ApiDifference("Removed java.awt.event.MouseAdapter from the list of superclasses of testlib.ChangingHierarchy", Severity.ERROR, "testlib.ChangingHierarchy", null, null), new ApiDifference("Added java.awt.event.WindowAdapter to the list of superclasses of testlib.ChangingHierarchy", Severity.INFO, "testlib.ChangingHierarchy", null, null), }; |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:27:56
|
Update of /cvsroot/clirr/clirr/src/testinput/testlib-v2/testlib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29623/src/testinput/testlib-v2/testlib Added Files: ApplicationException.java ChangingHierarchy.java Log Message: Warn about introducing new superclasses for Exceptions. Also added unit tests for class hierarchy check. --- NEW FILE --- package testlib; public class ApplicationException extends RuntimeException { } --- NEW FILE --- package testlib; public class ChangingHierarchy extends java.awt.event.WindowAdapter { } |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:27:56
|
Update of /cvsroot/clirr/clirr/src/testinput/testlib-v1/testlib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29623/src/testinput/testlib-v1/testlib Added Files: ApplicationException.java ChangingHierarchy.java Log Message: Warn about introducing new superclasses for Exceptions. Also added unit tests for class hierarchy check. --- NEW FILE --- package testlib; public class ApplicationException extends Exception { } --- NEW FILE --- package testlib; public class ChangingHierarchy extends java.awt.event.MouseAdapter { } |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:27:55
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29623/xdocs Modified Files: changes.xml Log Message: Warn about introducing new superclasses for Exceptions. Also added unit tests for class hierarchy check. Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/changes.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- changes.xml 23 May 2004 13:52:27 -0000 1.5 +++ changes.xml 23 May 2004 14:27:47 -0000 1.6 @@ -36,6 +36,12 @@ have the old value inlined and continue to use that old value. See the Java Language Spec, Chapter 13.4.8, for details. </action> + <action dev="lkuehne" type="add"> + <!-- RFE #958809 --> + Warn about adding new superclasses to a class derived from java.lang.Throwable. + Such changes are not binary incompatible (you won't get any Exception), + but a different catch clause might get selected in client code. + </action> </release> <release version="0.2" date="2004-05-22"> |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:27:55
|
Update of /cvsroot/clirr/clirr/src/test/net/sf/clirr/checks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29623/src/test/net/sf/clirr/checks Added Files: ClassHierarchyCheckTest.java Log Message: Warn about introducing new superclasses for Exceptions. Also added unit tests for class hierarchy check. --- NEW FILE --- package net.sf.clirr.checks; import net.sf.clirr.framework.ClassChangeCheck; import net.sf.clirr.event.ApiDifference; import net.sf.clirr.event.Severity; /** * @author lkuehne */ public class ClassHierarchyCheckTest extends AbstractCheckTestCase { public void testHierarchyChangesAreReported() { ApiDifference[] expected = new ApiDifference[] { new ApiDifference("Added java.lang.RuntimeException to the list of superclasses of testlib.ApplicationException", Severity.WARNING, "testlib.ApplicationException", null, null), new ApiDifference("Removed java.awt.event.MouseAdapter from the list of superclasses of testlib.ChangingHierarchy", Severity.ERROR, "testlib.ChangingHierarchy", null, null), new ApiDifference("Added java.awt.event.WindowAdapter to the list of superclasses of testlib.ChangingHierarchy", Severity.INFO, "testlib.ChangingHierarchy", null, null), }; verify(expected); } protected ClassChangeCheck createCheck(TestDiffListener tdl) { return new ClassHierarchyCheck(tdl); } } |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 14:27:54
|
Update of /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29623/src/java/net/sf/clirr/checks Modified Files: ClassHierarchyCheck.java Log Message: Warn about introducing new superclasses for Exceptions. Also added unit tests for class hierarchy check. Index: ClassHierarchyCheck.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks/ClassHierarchyCheck.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- ClassHierarchyCheck.java 22 May 2004 13:26:03 -0000 1.8 +++ ClassHierarchyCheck.java 23 May 2004 14:27:46 -0000 1.9 @@ -74,6 +74,16 @@ JavaClass[] compatSuper = compatBaseline.getSuperClasses(); JavaClass[] currentSuper = currentVersion.getSuperClasses(); + boolean isThrowable = false; + for (int i = 0; i < compatSuper.length; i++) + { + JavaClass javaClass = compatSuper[i]; + if ("java.lang.Throwable".equals(javaClass.getClassName())) + { + isThrowable = true; + } + } + List added = getSetDifference(currentSuper, compatSuper); List removed = getSetDifference(compatSuper, currentSuper); @@ -82,7 +92,7 @@ { String s = (String) added.get(i); log("Added " + s + " to the list of superclasses of " + className, - Severity.INFO, className, null, null); + isThrowable ? Severity.WARNING : Severity.INFO, className, null, null); } for (int i = 0; i < removed.size(); i++) |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 13:52:38
|
Update of /cvsroot/clirr/clirr/src/testinput/testlib-v1/testlib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23098/src/testinput/testlib-v1/testlib Modified Files: MembersChange.java Log Message: warn about changing the value of a compile time constant (RFE #958818) Index: MembersChange.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/testinput/testlib-v1/testlib/MembersChange.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- MembersChange.java 22 May 2004 14:06:30 -0000 1.1 +++ MembersChange.java 23 May 2004 13:52:27 -0000 1.2 @@ -14,6 +14,8 @@ public static final int fin2 = 0; public static final int fin3 = 0; public static final int fin4 = 0; + public static final int fin5 = 0; + public static final boolean fin6 = false; public int pub1 = 0; public int pub2 = 0; |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 13:52:38
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23098/xdocs Modified Files: changes.xml Log Message: warn about changing the value of a compile time constant (RFE #958818) Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/changes.xml,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- changes.xml 23 May 2004 08:58:37 -0000 1.4 +++ changes.xml 23 May 2004 13:52:27 -0000 1.5 @@ -28,6 +28,14 @@ <!-- RFE #958807 --> Documented formatter subelements in Ant task. </action> + <action dev="lkuehne" type="add"> + <!-- RFE #958808 --> + Warn about compile time constant value changes. Changing the value + of a constant is not binary incompatible (you won't get any Exception), + but client code compiled against the old version of the library will + have the old value inlined and continue to use that old value. + See the Java Language Spec, Chapter 13.4.8, for details. + </action> </release> <release version="0.2" date="2004-05-22"> |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 13:52:37
|
Update of /cvsroot/clirr/clirr/src/testinput/testlib-v2/testlib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23098/src/testinput/testlib-v2/testlib Modified Files: MembersChange.java Log Message: warn about changing the value of a compile time constant (RFE #958818) Index: MembersChange.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/testinput/testlib-v2/testlib/MembersChange.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- MembersChange.java 23 May 2004 05:41:28 -0000 1.2 +++ MembersChange.java 23 May 2004 13:52:27 -0000 1.3 @@ -15,6 +15,9 @@ protected static final int fin2 = 0; // public -> protected public final int fin3 = 0; // removed static public static int fin4 = 0; // removed final + public static final int fin5 = 1; // changed compile time constant + public static final boolean fin6 = + Boolean.FALSE.booleanValue(); // removed value of compile time constant public int pub1 = 0; public static int pub2 = 0; // added static |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 13:52:37
|
Update of /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23098/src/java/net/sf/clirr/checks Modified Files: FieldSetCheck.java Log Message: warn about changing the value of a compile time constant (RFE #958818) Index: FieldSetCheck.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/java/net/sf/clirr/checks/FieldSetCheck.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- FieldSetCheck.java 23 May 2004 07:54:17 -0000 1.6 +++ FieldSetCheck.java 23 May 2004 13:52:27 -0000 1.7 @@ -29,6 +29,7 @@ import net.sf.clirr.event.Severity; import org.apache.bcel.classfile.JavaClass; import org.apache.bcel.classfile.Field; +import org.apache.bcel.classfile.ConstantValue; /** * Checks the fields of a class. @@ -100,6 +101,7 @@ checkForModifierChange(bField, cField, currentClass); checkForVisibilityChange(bField, cField, currentClass); checkForReturnTypeChange(bField, cField, currentClass); + checkForConstantValueChange(bField, cField, currentClass); } } @@ -113,10 +115,39 @@ fireDiff("Added " + scope + " field " + fieldName, Severity.INFO, currentClass, field); } } + } + + private void checkForConstantValueChange(Field bField, Field cField, JavaClass currentClass) + { + if (!(bField.isStatic() && bField.isFinal() && cField.isStatic() && cField.isFinal())) + { + return; + } + + final ConstantValue bVal = bField.getConstantValue(); - // TODO: Check field types + if (bVal != null) + { + final String bValRep = bVal.toString(); + final ConstantValue cVal = cField.getConstantValue(); + if (cVal == null) + { + fireDiff("Value of " + bField.getName() + + " is no longer a compile time constant", + Severity.WARNING, currentClass, cField); + return; + } - // TODO: warn about constant value changes (see JLS, section 13.4.8) + final String cValRep = String.valueOf(cVal); + if (!bValRep.equals(cValRep)) + { + // TODO: print out old and new value + // How can that be done with BCEL, esp. for boolean values? + fireDiff("Value of compile time constant " + bField.getName() + + " has been changed", + Severity.WARNING, currentClass, cField); + } + } } private void checkForReturnTypeChange(Field bField, Field cField, JavaClass currentClass) |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 13:52:36
|
Update of /cvsroot/clirr/clirr/src/test/net/sf/clirr/checks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23098/src/test/net/sf/clirr/checks Modified Files: FieldSetCheckTest.java Log Message: warn about changing the value of a compile time constant (RFE #958818) Index: FieldSetCheckTest.java =================================================================== RCS file: /cvsroot/clirr/clirr/src/test/net/sf/clirr/checks/FieldSetCheckTest.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- FieldSetCheckTest.java 23 May 2004 07:45:37 -0000 1.3 +++ FieldSetCheckTest.java 23 May 2004 13:52:27 -0000 1.4 @@ -29,6 +29,8 @@ new ApiDifference("Field pub2 is now static in testlib.MembersChange", Severity.ERROR, "testlib.MembersChange", null, "pub2"), new ApiDifference("Changed type of field obj1 from java.lang.Object to java.lang.String in testlib.MembersChange", Severity.ERROR, "testlib.MembersChange", null, "obj1"), new ApiDifference("Changed type of field obj2 from java.lang.Boolean to java.lang.String in testlib.MembersChange", Severity.ERROR, "testlib.MembersChange", null, "obj2"), + new ApiDifference("Value of compile time constant fin5 has been changed in testlib.MembersChange", Severity.WARNING, "testlib.MembersChange", null, "fin5"), + new ApiDifference("Value of fin6 is no longer a compile time constant in testlib.MembersChange", Severity.WARNING, "testlib.MembersChange", null, "fin6"), }; verify(expected); } |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 09:14:59
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv30182 Modified Files: download.xml Log Message: fixed download location for snapshots to point at sf servers, not the local filesystem Index: download.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/download.xml,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- download.xml 22 May 2004 14:25:01 -0000 1.4 +++ download.xml 23 May 2004 09:14:44 -0000 1.5 @@ -15,7 +15,7 @@ <p> Development snapshots are occasionally made available between releases <a - href="builds/clirr/distributions/">here</a>. + href="http://clirr.sourceforge.net/builds/clirr/distributions/">here</a>. </p> <p> <strong>Sourceforge.net provides their infrastructure |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 08:58:49
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27386 Modified Files: anttask.xml changes.xml Log Message: documentation for formatter elements (RFE #958807) Index: anttask.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/anttask.xml,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- anttask.xml 20 May 2004 13:18:37 -0000 1.4 +++ anttask.xml 23 May 2004 08:58:37 -0000 1.5 @@ -124,6 +124,39 @@ for details. </p> </section> + + + + <section name="formatter"> + + <p> + A formatter that generates Clirr output. Multiple formatters can be specified. + Available attributes for each formatter element: + </p> + <table> + <tr> + <td>Attribute</td> + <td>Description</td> + <td>Required</td> + <td>Default</td> + </tr> + <tr> + <td>type</td> + <td>The formatter type. Available types are <em>plain</em> and <em>xml</em></td> + <td>No</td> + <td>plain</td> + </tr> + <tr> + <td>outfile</td> + <td>The file to write to. If not specified, output is written to stdout</td> + <td>No</td> + <td>stdout</td> + </tr> + </table> + </section> + <p> + If no formatter is specified, Clirr will write it's findings to stdout in plain format. + </p> </section> </body> </document> Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/changes.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- changes.xml 23 May 2004 08:16:00 -0000 1.3 +++ changes.xml 23 May 2004 08:58:37 -0000 1.4 @@ -24,6 +24,10 @@ create the impression that there are no compatibility problems, just because Clirr didn't report anything. </action> + <action dev="lkuehne" type="fix"> + <!-- RFE #958807 --> + Documented formatter subelements in Ant task. + </action> </release> <release version="0.2" date="2004-05-22"> |
|
From: Lars K?h. <lk...@us...> - 2004-05-23 08:16:12
|
Update of /cvsroot/clirr/clirr/xdocs In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19670/xdocs Modified Files: changes.xml Log Message: fail in case filesets are empty (RFE #958808) Index: changes.xml =================================================================== RCS file: /cvsroot/clirr/clirr/xdocs/changes.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- changes.xml 23 May 2004 07:45:37 -0000 1.2 +++ changes.xml 23 May 2004 08:16:00 -0000 1.3 @@ -17,6 +17,13 @@ <!-- RFE #958810 --> Detect changes of field types. </action> + <action dev="lkuehne" type="add"> + <!-- RFE #958808 --> + Ant Task fails when filesets origFiles or newFiles are empty. + Empty file sets are usually a setup problem - they should not + create the impression that there are no compatibility problems, + just because Clirr didn't report anything. + </action> </release> <release version="0.2" date="2004-05-22"> |
110 messages has been excluded from this view by a project administrator.
