Re: [Classifier4j-devel] WordProbability Refactor...

[Nick L. <ni...@ma...>]

Pete, that looks good, and I think the commons-lang dependancy is fine.

I'm having a little trouble applying it, though. I don't do a lot of
CVS/Patch work, so it might be something I'm doing wrong.

I'm using Eclipse, which has a nice apply-patch wizard, but unfortunatly
that will only process patches in unified format. Could I get you to redo
the patch using that format?

Just send it to the list (and CC it to nick at mackmo dot com in case it
won't accept attachments).

Nick

----- Original Message ----- 
From: "Peter Leschev" <pe...@le...>
To: <cla...@li...>
Sent: Wednesday, July 09, 2003 11:04 AM
Subject: [Classifier4j-devel] WordProbability Refactor...


> > > I would recommend changing the IWordsDataSource to
> > > return WordProbability objects instead of double.
> This
> > > would ensure that BayesianClassifier doesn't have to
> > > know how to create WordProbability Objects, it just
> > > gets them from the IWordsDataSource.
> > >
> > > It would be nice if WordProbability knew how to
> > > calculate it's own probability, given the number of
> > > nonmatching & matching counts. This will reduce
> > > duplication of code with new IWordsDataSource
> > > implementations.
> > >
>
> > Sounds pretty reasonable. I'm not very happy with the
> use of the
> > WordProbability object at the moment, anyway.
>
> Heya,
>
>         I've submitted a patch with this change.
>
>
http://sourceforge.net/tracker/index.php?func=detail&aid=768157&group_id=79523&atid=556879
>
> Pete
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: Parasoft
> Error proof Web apps, automate testing & more.
> Download & eval WebKing and get a free book.
> www.parasoft.com/bulletproofapps
> _______________________________________________
> Classifier4j-devel mailing list
> Cla...@li...
> https://lists.sourceforge.net/lists/listinfo/classifier4j-devel
>