[CK-Ledger-users] Re: [Phpgroupware-developers] Testing CK-Ledger v.0.7.1 against phpgroupware-0.9.16.RC1

[Dave H. <dav...@mb...>]

C=3D20K=3D20Wu =3Cchiukay2000=40yahoo=2Ecom=2Ehk=3E wrote=3A

=3E Hi=2C Dave=2C
=3E =

=3E Nah=2C I don=27t mean to nag the core team or the phpgw
=3E leadership into backing out of the =2E16 API changes=2E =

=3E My last email is actually to highlight to other addon
=3E maintainers that there is this potential problem that
=3E they have to deal with when they are preparing to
=3E upgrade to 0=2E9=2E16RC1 =2E

No problem=2E  Sorry I misunderstood=2E  I think other developers will
appreciate the heads up=2E  My offer of assisting you to get CK Ledger
ready for 16 still stands =3A)

Cheers

Dave
=3E =

=3E Cheers=2C
=3E CK
=3E =

=3E --- Dave Hall =A1G=3E
=3E Hey CK=2C
=3E =3E =

=3E =3E C=3D20K=3D20Wu =3Cchiukay2000=40yahoo=2Ecom=2Ehk=3E wrote=3A
=3E =3E =

=3E =3E =3E Hello=2C Dave=2C
=3E =3E =3E =

=3E =3E =3E I think I=27ve found what=27s going on=2E
=3E =3E =3E =

=3E =3E =3E With 0=2E9=2E14=2E006=2C
=3E =3E =3E =

=3E =3E =3E =2E=2E/phpgwapi/inc/class=2Esessions=5Fphp4=2Einc=2Ephp (line=

=3E =3E 951)
=3E =3E =3E and =2E=2E/phpgwapi/inc/class=2Esessions=5Fdb=2Einc=2Ephp
=3E =3E (line
=3E =3E =3E 977) read=2C
=3E =3E =3E =

=3E =3E =3E =24new=5Fextravars =2E=3D =22=24key=3D=24value=22 =3B
=3E =3E =3E =

=3E =3E =3E With 0=2E9=2E16RC1=2C
=3E =3E =3E =

=3E =3E =3E =2E=2E/phpgwapi/inc/class=2Esessions=2Einc=2Ephp (line 1194)
=3E =3E =3E reads=2C
=3E =3E =3E =

=3E =3E =3E =24new=5Fextravars =2E=3D =24key=2E=27=3D=27=2Eurlencode(=24v=
alue) =3B
=3E =3E =3E =

=3E =3E =3E So=2C apparently=2C with earlier versions=2C it is the
=3E =3E =3E application script=27s responsibility to url=5Fencode
=3E =3E GET
=3E =3E =3E variables before sending it on=2E  However=2C with
=3E =3E =3E 0=2E9=2E16RC1=2C the sessions facility handles the
=3E =3E =3E url=5Fencode-ing when it receives the GET variables
=3E =3E from
=3E =3E =3E the application script=2E
=3E =3E =3E =

=3E =3E =3E With CK-Ledger v=2E0=2E7=2E1 running against phpgw
=3E =3E =3E 0=2E9=2E16RC1=2C it means double url=5Fencoding and
=3E =3E therefore
=3E =3E =3E the callee scripts need to url=5Fdecode the GET
=3E =3E variable
=3E =3E =3E one more time to recover the correct value=2E
=3E =3E =3E =

=3E =3E =3E I think this will break a lot of the addon module
=3E =3E =3E codes=2E  However=2C if the GET variable passed
=3E =3E contains
=3E =3E =3E pure alphanumeric chars=2C no error will be
=3E =3E detected=2C
=3E =3E =3E since urlencode/urldecode in these cases do not
=3E =3E alter
=3E =3E =3E the GET variables=2E  So=2C there may be quite a fair
=3E =3E bit
=3E =3E =3E of  spurious 0=2E9=2E16RC1 errors being the result of
=3E =3E the
=3E =3E =3E above=2E
=3E =3E =

=3E =3E Ok=2C now I follow what is going on=2E  I didn=27t make
=3E =3E this change=2C but I can
=3E =3E understand (and agree with) the logic behind it=2E =

=3E =3E This is my logic with
=3E =3E it=2C others may disaagree=2C it is easier to url=5Fencode
=3E =3E the variables=2C once
=3E =3E in the api=2C than each app maintainer having to
=3E =3E remember to encode them=2E
=3E =3E  It also means that if we ever have to do anything
=3E =3E else to the GET args
=3E =3E it can be changed once in the API and all apps
=3E =3E automatically get the
=3E =3E benefit=2E
=3E =3E =

=3E =3E I understand this will cause some problems with CK
=3E =3E Ledger=2C this is
=3E =3E unfortunate=2C but I doubt the change will be backed
=3E =3E out=2E  As will all new
=3E =3E versions of the API there are changes=2E  The 16 API
=3E =3E has quite a few
=3E =3E changes=2C some of which I think you app could benefit
=3E =3E from=2E  =

=3E =3E =

=3E =3E I would suggest that you continue testing with the
=3E =3E 16RCs with regular
=3E =3E CVS updates=2C and keep in touch with us=2E  I am
=3E =3E willing to assist you get
=3E =3E your app to run properly on 16=2E  Please be aware
=3E =3E that I do not use CK
=3E =3E Ledger=2C but am happy to answer any questions you may
=3E =3E have=2E
=3E =3E =

=3E =3E Cheers
=3E =3E =

=3E =3E Dave
=3E =3E =

=3E =3E =3E =

=3E =3E =3E Cheers=2C
=3E =3E =3E CK
=3E =3E =3E =

=3E =3E =3E =

=3E =3E =3E =

=3E =3E =3E Dave Hall=3A
=3E =3E =3E =

=3E =3E =3E =3ECK Wu =3Cchiukay2000=40yahoo=2Ecom=2Ehk=3E wrote=3A
=3E =3E =3E =3E
=3E =3E =3E =3E=3EHello=2C folks=2C
=3E =3E =3E =3E=3E
=3E =3E =3E =3E=3EWhile testing CK-Ledger v=2E0=2E7=2E1 against
=3E =3E =3E =3E=3Ephpgroupware-0=2E9=2E16=2ERC1=2C
=3E =3E =3E =3E=3EI came across the following=2C
=3E =3E =3E =3E=3E
=3E =3E =3E =3E=3EWhen calling=2C
=3E =3E =3E =3E=3E
=3E =3E =3E =3E=3E
=3E =3E =3E
=3E =3E
=3E
=3Ehttp=3A//localhost/=2E=2E=2E/loglist=2Ephp=3Ffilter=3D=252BWHERE=252B1=
=25253D1=252B=26sessionid=3D=2E=2E=2E=26kp3=3D=2E=2E=2E=26domain=3Ddefaul=
t=26click=5Fhistory=3D=2E=2E=2E
=3E =3E =3E =3E
=3E =3E =3E =3EIs this
=3E =3E =3E
=3E =3E
=3E
=3Ehttp=3A//localhost/phpgroupware/loglist=2Ephp=3Ffilter=3D=252BWHERE=25=
2B1=25253D1=252B=26=2E=2E=2E
=3E =3E =3E =3E
=3E =3E =3E =3Eor
=3E =3E =3E =3E
=3E =3E =3E =3Ehttp=3A//localhost/ck-
=3E =3E =3E
=3E =3E ledger/loglist=2Ephp=3Ffilter=3D=252BWHERE=252B1=25253D1=252B=26=2E=
=2E=2E=3E
=3E =3E =3E =3ELooking at that code =2E=2E=2E there are several
=3E =3E problems
=3E =3E =3E =2E=2E=2E=2E
=3E =3E =3E =3E
=3E =3E =3E =3Efirstly the =24=5FPOST/=24=5FGET hack won=27t work with
=3E =3E =3E register=5Fglobals =3D off
=3E =3E =3E =3E
=3E =3E =3E =3EAlso phpgroupware has never processed the
=3E =3E external
=3E =3E =3E variables=2C I think it
=3E =3E =3E =3Eis a PHP problem=2E  IIRC php will url=5Fdecode all
=3E =3E =24=5FGET
=3E =3E =3E vars for you=2E
=3E =3E =3E =3E
=3E =3E =3E =3EBit more info about where this code is will
=3E =3E probably
=3E =3E =3E help us track this
=3E =3E =3E =3Edown=2E
=3E =3E =3E =3E
=3E =3E =3E =3ECheers
=3E =3E =3E =3E
=3E =3E =3E =3EDave
=3E =3E =3E =3E
=3E =3E =3E =

=3E =3E =3E =

=3E =3E =3E
=3E =3E
=3E =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F
=3E =3E =3E =B3=CC=B7s=B9a=C1n=B1=C0=A4=B6=3A=B9J=A8=A3=A1A=B6=C3=A5=40=A8=
=CE=A4H=A1A=B0=B2=A6p=B7R=A6=B3=A4=D1=B7N=2E=2E=2E
=3E =3E =3E http=3A//ringtone=2Eyahoo=2Ecom=2Ehk
=3E =3E =3E =

=3E =3E =3E
=3E =3E =3E begin=3Avcard
=3E =3E n=3AHall=3BDave
=3E =3E fn=3ADave Hall
=3E =3E tel=3Bfax=3A+61 3 8610 0029
=3E =3E tel=3Bwork=3A+61 3 96 871 871
=3E =3E org=3ADave Hall Consulting=3B
=3E =3E adr=3A=3B=3B=3B=3B=3B=3BAUSTRALIA
=3E =3E version=3A2=2E1
=3E =3E email=3Binternet=3Adave=2Ehall=40mbox=2Ecom=2Eau
=3E =3E end=3Avcard
=3E =3E =

=3E =3E  =

=3E =

=3E =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F
=3E =B3=CC=B7s=B9a=C1n=B1=C0=A4=B6=3A=B9J=A8=A3=A1A=B6=C3=A5=40=A8=CE=A4H=
=A1A=B0=B2=A6p=B7R=A6=B3=A4=D1=B7N=2E=2E=2E
=3E http=3A//ringtone=2Eyahoo=2Ecom=2Ehk
=3E =

=3E