RE: [Civlog-list] CivLog-0.6.1

[Michael G. <mic...@gr...>]

> [ I just noticed that it took the email 2 days to return from sourceforge ]

What makes you think so?
It appears you sent your reply 2 (+-1) hours after I sent my mail.

from your mail:
Date: Sat, 30 Sep 2000 22:02:46 +0200
From: Raimar Falke <hawk@B205a.WH8.TU-Dresden.De>
[...]
User-Agent: Mutt/1.2.5i
In-Reply-To: <LKE...@gr...>; from mic...@gr... on Sat, Sep 30, 2000 at 08:52:54PM +0100

> On Sat, Sep 30, 2000 at 08:52:54PM +0100, Michael Grundel wrote:
> > Hi!
> >
> > Raimar wrote:
> > > On Mon, Sep 25, 2000 at 05:03:22PM +0200, Raimar Falke wrote:
> > > > On Mon, Sep 25, 2000 at 10:32:33PM +0800, Wong TM (Huang Deming) wrote:
> > > > >
> > > > > Changes:
> > > > >
> > > > >     * Ulrich have made a lot of changes to restructure the data structure:
> > > > >         - .......wait till I read through the mail.
> > > >
> > > > I think you made the inclusion a bit to fast. The work of Ulrich has made
> > > > aware some questions wrt Score. We now think we how to do it the "right way
> > > > [tm]" so wait for a final version which should come in the next days.
> > >
> > > As promised here is the updated version. It is the result of collaboration
> > > between Ulrich and me. We came to the conclusion that a second loop over all
> > > lines is unnecessary. This also kills the huge "String lines[];" thing.
> >
> > Nice.
> >
> > > A remaining problem are "extra player" (player which aren't declared in the
> > > header). The current solution is to create an array which is big enough to
> > > hold every number of players. Fortunate freeciv is currently limited to 32
> > > in this respect.
> > >
> > > Another remaining problem is the current implemenation of the relative modus
> > > of PolyLineGroup. It may be possible to let extra players start somewhere in
> > > the graph (see line 380 in Graph) however this doesn't work in the relative
> > > modus. So unknown values are currently set to 0.
> >
> > Another problem is what I reported earlier: the player-numbering is not always
> > continuous. I speculated that this may be a bug in freeciv. It is not.
> > from report.c:
> > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >   for (i = 0; tags[i]; i++)
> >     {
> >       for (n = 0; n < game.nplayers; n++)
> > 	{
> > 	  if (is_barbarian (&(game.players[n])))            <---------------- NOTE!
> > 	    {
> > 	      continue;                                     <---------------- NOTE!
> > 	    }
> > 	  switch (i)
> > 	    {
> > 	    case 0:
> > 	      fom = total_player_citizens (&(game.players[n]));
> > 	      break;
> > 	    case 1:
> > 	      fom = game.players[n].score.bnp;
> > 	      break;
> > <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> >
> > Barabarians are not added to the log, so they generate gaps in the player
> > numbering.
> >
> > When I open a score-file that has such a gap, 0.6.1-mod breaks:
>
> Can you give me such a scorefile?

attached.

> > Exception occurred during event dispatching:
> > java.lang.RuntimeException: Incorrect order
>
> At least we noticed it.
>
> >         at org.freeciv.civlog.data.AbstractScore.addPlayer(AbstractScore.java:87)
> >         at org.freeciv.civlog.data.SimpleScore.loadScoreFile(SimpleScore.java:246)
> >         at org.freeciv.civlog.data.SimpleScore.loadScoreFile(SimpleScore.java:55)
> >
> > I don't know if it still works if you just remove throwing that exception?
>
> No it wouldn't. You can fix it yourself or send me your score file.
> Hopefully it isn't top secret.

It is not secret :). It is just large (4.5 MB by now, and the game is not finished
yet, currently year 2024, max is 5000). But I found a smaller one. I have attached
that (error happens in year 920).
When the big game is finished I will also make the log-file available.

BTW, did you get any email from freeciv-dev over the last days?
I have not, the last one I got is from Sebastian Bauer from Thursday.


  Michael

--
eMail: mic...@gr...
PGP key available on request