[CIShell-SVN] SF.net SVN: cishell: [535] trunk/testing/org.cishell.testing. convertertester.core.new/src/org/cishell/testing/convertertester/core/ tester2/reportgen/allerrors/analyzer/DefaultErrorSourceAnalyzer.java

[<mwl...@us...>]

Revision: 535
          http://cishell.svn.sourceforge.net/cishell/?rev=535&view=rev
Author:   mwlinnem
Date:     2007-09-20 14:26:54 -0700 (Thu, 20 Sep 2007)

Log Message:
-----------
Fixed bug in how percentages for summaries in all errors report were calculated.

Modified Paths:
--------------
    trunk/testing/org.cishell.testing.convertertester.core.new/src/org/cishell/testing/convertertester/core/tester2/reportgen/allerrors/analyzer/DefaultErrorSourceAnalyzer.java

Modified: trunk/testing/org.cishell.testing.convertertester.core.new/src/org/cishell/testing/convertertester/core/tester2/reportgen/allerrors/analyzer/DefaultErrorSourceAnalyzer.java
===================================================================
--- trunk/testing/org.cishell.testing.convertertester.core.new/src/org/cishell/testing/convertertester/core/tester2/reportgen/allerrors/analyzer/DefaultErrorSourceAnalyzer.java	2007-09-20 21:18:13 UTC (rev 534)
+++ trunk/testing/org.cishell.testing.convertertester.core.new/src/org/cishell/testing/convertertester/core/tester2/reportgen/allerrors/analyzer/DefaultErrorSourceAnalyzer.java	2007-09-20 21:26:54 UTC (rev 535)
@@ -102,22 +102,25 @@
 				totalChanceAtFaults += pc.getChanceAtFault();
 			}
 			
-			List normalizedCafs = new ArrayList();
-			for (int ii = 0; ii < pcs.size(); ii++) {
-				ChanceAtFault pc = (ChanceAtFault) pcs.get(ii);
+			ChanceAtFault[] uniqueCafs = 
+				removeDuplicateConverters(this.pcs);
+			
+			List uniqueNormalizedCafs = new ArrayList();
+			for (int ii = 0; ii < uniqueCafs.length; ii++) {
+				ChanceAtFault pc = uniqueCafs[ii];
 				
 				ChanceAtFault normPC = new ChanceAtFault(
 						pc.getFailedFilePass(),
 						pc.getConverter(),
 						pc.getChanceAtFault() / totalChanceAtFaults);
 				
-				normalizedCafs.add(normPC);
+				uniqueNormalizedCafs.add(normPC);
 			}
 			
-			ChanceAtFault[] uniqueNormalizedCafs = 
-				removeDuplicateConverters(normalizedCafs);
+
 			
-			return uniqueNormalizedCafs;
+			return (ChanceAtFault[]) 
+				uniqueNormalizedCafs.toArray(new ChanceAtFault[0]);
 		}
 	}
 	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.