[CIShell-SVN] SF.net SVN: cishell: [381] trunk/clients/gui

[<hu...@us...>]

Revision: 381
          http://svn.sourceforge.net/cishell/?rev=381&view=rev
Author:   huangb
Date:     2007-03-15 14:39:40 -0700 (Thu, 15 Mar 2007)

Log Message:
-----------
Clean up code a bit

Modified Paths:
--------------
    trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/Activator.java
    trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/LogToFile.java
    trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java

Modified: trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/Activator.java
===================================================================
--- trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/Activator.java	2007-03-15 21:33:40 UTC (rev 380)
+++ trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/Activator.java	2007-03-15 21:39:40 UTC (rev 381)
@@ -3,10 +3,8 @@
 import org.eclipse.ui.plugin.AbstractUIPlugin;
 import org.osgi.framework.BundleContext;
 
-import org.osgi.service.log.LogEntry;
 import org.osgi.service.log.LogListener;
 import org.osgi.service.log.LogReaderService;
-import org.osgi.service.log.LogService;
 import org.osgi.framework.ServiceReference;
 
 /**

Modified: trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/LogToFile.java
===================================================================
--- trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/LogToFile.java	2007-03-15 21:33:40 UTC (rev 380)
+++ trunk/clients/gui/org.cishell.reference.gui.log/src/org/cishell/reference/gui/log/LogToFile.java	2007-03-15 21:39:40 UTC (rev 381)
@@ -4,7 +4,6 @@
 
 import org.osgi.service.log.LogEntry;
 import org.osgi.service.log.LogListener;
-import org.osgi.service.log.LogService;
 
 import java.util.Calendar;
 import java.util.logging.FileHandler;
@@ -14,7 +13,7 @@
 import java.io.IOException;
 
 /**
- * This is a basic implementation. It write log records to files
+ * This is a basic implementation. It writes log records to files
  * @author Weixia(Bonnie) Huang (hu...@in...)
  */
 public class LogToFile implements LogListener {

Modified: trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java
===================================================================
--- trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java	2007-03-15 21:33:40 UTC (rev 380)
+++ trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java	2007-03-15 21:39:40 UTC (rev 381)
@@ -15,27 +15,22 @@
 
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Dictionary;
-import java.util.Hashtable;
 import java.util.List;
 
 import org.cishell.app.service.datamanager.DataManagerListener;
 import org.cishell.app.service.datamanager.DataManagerService;
 import org.cishell.app.service.scheduler.SchedulerService;
 import org.cishell.framework.CIShellContext;
-import org.cishell.framework.algorithm.AlgorithmFactory;
 import org.cishell.framework.algorithm.AlgorithmProperty;
-import org.cishell.framework.algorithm.DataValidator;
+//import org.cishell.framework.algorithm.DataValidator;
 import org.cishell.framework.data.Data;
 import org.cishell.service.conversion.Converter;
 import org.cishell.service.conversion.DataConversionService;
-import org.cishell.service.guibuilder.GUIBuilderService;
 import org.eclipse.jface.action.Action;
 import org.osgi.framework.BundleContext;
-import org.osgi.framework.Constants;
+//import org.osgi.framework.Constants;
 import org.osgi.framework.ServiceReference;
 import org.osgi.service.log.LogService;
-import org.osgi.service.metatype.MetaTypeProvider;
 
 
 public class AlgorithmAction extends Action implements AlgorithmProperty, DataManagerListener {
@@ -182,7 +177,7 @@
     
     //This method will be disabled until we can find a better solution
     //for extra validation beyond input/output checking
-    private boolean isValid() {
+/*    private boolean isValid() {
         String valid = null;
         String[] classes = (String[]) ref.getProperty(Constants.OBJECTCLASS);
         
@@ -207,7 +202,7 @@
         
         return valid == null || valid.length() == 0;
     }
-    
+*/    
     private boolean isAsignableFrom(String type, Data datum) {
         Object data = datum.getData();
         boolean assignable = false;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.