[CIShell-SVN] SF.net SVN: cishell: [278] trunk/clients/gui/org.cishell.reference.gui. menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction. java

[<bh...@us...>]

Revision: 278
          http://svn.sourceforge.net/cishell/?rev=278&view=rev
Author:   bh2
Date:     2006-10-13 16:23:12 -0700 (Fri, 13 Oct 2006)

Log Message:
-----------
fixed a thread locking problem (though it may cause other problems later)

Modified Paths:
--------------
    trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java

Modified: trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java
===================================================================
--- trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java	2006-10-13 23:22:22 UTC (rev 277)
+++ trunk/clients/gui/org.cishell.reference.gui.menumanager/src/org/cishell/reference/gui/menumanager/menu/AlgorithmAction.java	2006-10-13 23:23:12 UTC (rev 278)
@@ -153,17 +153,16 @@
             for (int i=0; i < classes.length; i++) {
                 if (classes[i].equals(DataValidator.class.getName())) {
                     DataValidator validator = (DataValidator) bContext.getService(ref);
-                    
-                    synchronized(this) {
-                        for (int j=0; j < data.length; j++) {
-                            if (converters[j] != null && converters[j].length > 0) {
-                                data[j] = converters[j][0].convert(data[j]);
-                                converters[j] = null;
-                            }
+                                  
+                    //FIXME: Could cause concurrency problems...
+                    for (int j=0; j < data.length; j++) {
+                        if (converters[j] != null && converters[j].length > 0) {
+                            data[j] = converters[j][0].convert(data[j]);
+                            converters[j] = null;
                         }
-                        
-                        valid = validator.validate(data);
                     }
+                    
+                    valid = validator.validate(data);
                 }
             }
         }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.