CIL mishandles several GCC attributes that *should* only be associated
with functions: leaf, artificial, and warn_unused_result. The attached
patch fixes this by adding them to CIL's table of known function attributes.
These three attributes are all heavily used in <stdio.h> under Fedora 17
(glibc 2.15) when optimization is turned on. Without this fix, these
attributes tend to be incorrectly associated with functions' return
types, which in turn leads to GCC warnings about incorrect attribute use.
Would someone please apply this to the main CIL repository? Thanks!
As an aside, I *used* to have direct commit access to the CIL
repository. You'll even see my name listed in the "LICENSE" file as one
of the copyright holders. But either I no longer have commit rights or
else I know longer know what I am supposed to do to exercise those
rights. A git push to
<ssh://liblit@.../gitroot/cil/cil> fails with
"insufficient permission for adding an object to repository database
./objects". Am I doing this wrong? Do I still have commit rights in
theory, or am I no longer considered a CIL developer?
From: Gabriel Kerneis <kerneis@pp...> - 2012-05-10 17:19:42
On Thu, May 10, 2012 at 11:52:48AM -0500, Ben Liblit wrote:
> As an aside, I *used* to have direct commit access to the CIL repository.
> [...] Am I doing this wrong? Do I still have commit rights in theory, or am I
> no longer considered a CIL developer?
You did not do anything wrong. I just forgot to setup the rights when I
switched CIL from svn to git. This should be fixed now (sourceforge's UI is
very confusing, so let me know if it still does not work).
> Would someone please apply this to the main CIL repository? Thanks!
It looks fine with me. I'll let you commit it yourself to check that everything