#374 #define typo in usb_lld.h (OTGv1)

closed-fixed
2014-05-09
2013-01-27
No

In mac_lld.h:

#if !defined(STM32_USB_OTG_THREAD_PRIORITY) || defined(__DOXYGEN__)
#define STM32_USB_OTG_THREAD_PRIO LOWPRIO
#endif

Note that the "#if defined" is ..._THREAD_PRIORITY, whereas the symbol is actually ..._THREAD_PRIO.

Just a typo, but will cause a compiler redefinition error.

Discussion

  • Ignacio García Pérez

    • summary: #define typo in mac_lld.h --> #define typo in usb_lld.h (OTGv1)
     
  • Ignacio García Pérez

    Sorry, in OTGv1/usb_lld.c, not mac_lld.c.

     
  • Giovanni Di Sirio

    Thanks for finding, will be fixed in 2.5.2unstable.

     
  • Giovanni Di Sirio

    • assigned_to: nobody --> gdisirio
    • priority: 5 --> 3
    • milestone: 953057 --> 2.5.1unstable
    • status: open --> open-accepted
     
  • Giovanni Di Sirio

    • status: open-accepted --> open-fixed
     
  • Giovanni Di Sirio

    Hi, will be fixed in 2.5.2unstable, fixed on repository.

     
  • Giovanni Di Sirio

    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks