[Cherbot-commit] SF.net SVN: cherbot: [44] trunk/src/net/sf/cherbot

[<chr...@us...>]

Revision: 44
          http://svn.sourceforge.net/cherbot/?rev=44&view=rev
Author:   christianhujer
Date:     2007-02-10 14:12:53 -0800 (Sat, 10 Feb 2007)

Log Message:
-----------
Fixed some code style issues.

Modified Paths:
--------------
    trunk/src/net/sf/cherbot/CronManager.java
    trunk/src/net/sf/cherbot/Manager.java
    trunk/src/net/sf/cherbot/TimeManager.java

Modified: trunk/src/net/sf/cherbot/CronManager.java
===================================================================
--- trunk/src/net/sf/cherbot/CronManager.java	2007-02-10 21:45:34 UTC (rev 43)
+++ trunk/src/net/sf/cherbot/CronManager.java	2007-02-10 22:12:53 UTC (rev 44)
@@ -85,7 +85,7 @@
     /**
      * CronTask convenience base class.
      */
-    public static abstract class AbstractCronTask implements CronTask {
+    public abstract static class AbstractCronTask implements CronTask {
 
         /**
          * The name for this task.
@@ -112,7 +112,7 @@
     /**
      * CronTask convenience base class.
      */
-    public static abstract class RegularCronTask extends AbstractCronTask {
+    public abstract static class RegularCronTask extends AbstractCronTask {
 
         /**
          * The number of ticks for the task.

Modified: trunk/src/net/sf/cherbot/Manager.java
===================================================================
--- trunk/src/net/sf/cherbot/Manager.java	2007-02-10 21:45:34 UTC (rev 43)
+++ trunk/src/net/sf/cherbot/Manager.java	2007-02-10 22:12:53 UTC (rev 44)
@@ -494,7 +494,7 @@
      * @return sb for convenience
      * @see #split(String)
      */
-    protected static final StringBuilder concat(final StringBuilder sb, final Iterable<String> it) {
+    protected static StringBuilder concat(final StringBuilder sb, final Iterable<String> it) {
         final Iterator<String> iterator = it.iterator();
         if (iterator.hasNext()) {
             String s = iterator.next();
@@ -514,7 +514,7 @@
      * @return Iterable for parts
      * @see #concat(StringBuilder,Iterable)
      */
-    protected static final String[] split(final String s) {
+    protected static String[] split(final String s) {
         return s.split(", ?| and | or ");
     }
 
@@ -1086,7 +1086,7 @@
      * Converter used by MapIOMOdule.
      * @author <a href="mailto:ch...@ri...">Christian Hujer</a>
      */
-    protected static abstract class Converter<ValueType> {
+    protected abstract static class Converter<ValueType> {
 
         /**
          * String Converter that doesn't change.
@@ -1199,7 +1199,7 @@
          * {@inheritDoc}
          */
         @Override public En fromString(final String value) {
-            return (En) Enum.<En>valueOf(cl, value);
+            return Enum.valueOf(cl, value);
         }
 
     } // class EnumConverter

Modified: trunk/src/net/sf/cherbot/TimeManager.java
===================================================================
--- trunk/src/net/sf/cherbot/TimeManager.java	2007-02-10 21:45:34 UTC (rev 43)
+++ trunk/src/net/sf/cherbot/TimeManager.java	2007-02-10 22:12:53 UTC (rev 44)
@@ -171,8 +171,7 @@
      */
     @Override public void text(final String msg) {
         Matcher matcher;
-        if (false) {
-        } else if ((matcher = regexDaytime.matcher(msg)).matches()) {
+        if ((matcher = regexDaytime.matcher(msg)).matches()) {
             time.minutes = Integer.parseInt(matcher.group(1));
             time.hours = Integer.parseInt(matcher.group(2));
             if (matcher.group(3).equals("pm") && time.hours < 12) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.