check-devel — Check unit test framework development

Re: [Check-devel] Is it ok to invoke tests/check_check individually and is a deadlock with HAVE_FORK a bug?

[Branden A. <b.m...@gm...>]

Kalle,

Thanks for your interest in Check, and reporting strange behavior so it can
be looked into.

If I understand correctly, on your system you are unable to compile check
with fork enabled and run the check_check unit tests successfully, right?
Instead, the unit test program never exits. What version of Check are you
using, and on what platform?

When compiled with fork every unit test is forked off and executed. There
are a number of tests checking that the environment for forked tests is as
expected. If all goes well, if the timeout is enabled then any test that
goes rogue will be aborted after the timeout. By default, there is such a
timeout, which should be several seconds.

My guess so far is that you are hitting something with the timeout tests.
For example, in check_check_sub.c there is a test:

START_TEST(test_eternal_fail)

which should never exit and the unit test setup expects the test to
timeout. An easy to check for this is to compile with the
--disable-timeout-tests flag, which turns off such tests. It would be
interesting to hear if you are able to compile with fork with the timeout
tests disabled. If that is not it, I'll help you dig deeper into what the
issue is.

- Branden

On Sun, Jan 18, 2015 at 7:22 PM, Karl-Philipp Richter <
ri...@ri...> wrote:

> Hi,
> I'm getting started with the code and stumbled over a mentionable issue
> while debugging the `tests/check_check` binary (compiled with
> `./configure --disable-fork CPPFLAGS=-DDEBUG CPPFLAGS="-g -O0"
> CFLAGS="-g -O0" && make`). When the `HAVE_FORK` macro is defined the
> program never returns. When I add `--disable-fork` to `./configure` it
> does. `make check` succeeds and I waited multiples of the time it takes
> for `check_check` to return - I have to admit that I'm too unexperienced
> to debug the forked processes. Maybe there're no fork tests in `make
> check`?
>
> Any help or pointers are appreciated.
>
> Best regards,
> Kalle
>
>
> ------------------------------------------------------------------------------
> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet
> _______________________________________________
> Check-devel mailing list
> Che...@li...
> https://lists.sourceforge.net/lists/listinfo/check-devel
>

[Check-devel] Is it ok to invoke tests/check_check individually and is a deadlock with HAVE_FORK a bug?

[Karl-Philipp R. <ri...@ri...>]

Hi,
I'm getting started with the code and stumbled over a mentionable issue
while debugging the `tests/check_check` binary (compiled with
`./configure --disable-fork CPPFLAGS=-DDEBUG CPPFLAGS="-g -O0"
CFLAGS="-g -O0" && make`). When the `HAVE_FORK` macro is defined the
program never returns. When I add `--disable-fork` to `./configure` it
does. `make check` succeeds and I waited multiples of the time it takes
for `check_check` to return - I have to admit that I'm too unexperienced
to debug the forked processes. Maybe there're no fork tests in `make check`?

Any help or pointers are appreciated.

Best regards,
Kalle

Re: [Check-devel] Linker errors in Check example on Ubuntu 14.04

[Clay M. <cl...@da...>]

Indeed, 0.9.13 introduced PKG_CHECK_MODULES, but Ubuntu 14.04 ships
with 0.9.10. Thanks for clearing that up! It looks like the upcoming
Ubuntu 14.10 will also ship with 0.9.10, but I'll work with the Ubuntu
maintainers to see about releasing an updated package with the next
Ubuntu.

Thanks for the help!

Cheers,

Clay

On Mon, Sep 22, 2014 at 11:37 PM, Branden Archer <b.m...@gm...> wrote:
> What version of Check are you compiling the example from? I believe that the
> example since Check 0.9.13 uses pkg-config:
>
> # Checks for libraries.
> PKG_CHECK_MODULES([CHECK], [check >= 0.9.6])
>
> Maybe the macro is not being used properly, or something else is going
> wrong?
>
> - Branden
>
> On Mon, Sep 22, 2014 at 10:35 PM, Clay McClure <cl...@da...> wrote:
>>
>> Hi Branden,
>>
>> Yes, Check is installed as a static library on Ubuntu:
>>
>> $ dpkg -L check | grep /lib//usr/lib/x86_64-linux-gnu
>> /usr/lib/x86_64-linux-gnu/libcheck_pic.a
>> /usr/lib/x86_64-linux-gnu/pkgconfig
>> /usr/lib/x86_64-linux-gnu/pkgconfig/check.pc
>> /usr/lib/x86_64-linux-gnu/libcheck.a
>>
>> Noticing the pkgconfig directory, I remembered reading about
>> pkg-config and tried:
>>
>> $ pkg-config --cflags --libs check
>> -pthread  -pthread -lcheck_pic -lrt -lm
>>
>> which is exactly what I need. So I suppose the answer is to update the
>> example Makefile to use pkg-config, where possible. Thoughts on how
>> best to do that?
>>
>> Cheers,
>>
>> Clay
>>
>>
>> On Mon, Sep 22, 2014 at 9:48 PM, Branden Archer <b.m...@gm...>
>> wrote:
>> > Out of curiosity, is this necessary because on Ubuntu Check is provided
>> > as a
>> > static library? I've not run into this issue before, but on my system
>> > Check
>> > is a dynamic library.
>> >
>> > I'd be cautious about including these macros into the configure script
>> > as is
>> > if one is interested in multi-platform support:
>> >
>> > AC_SEARCH_LIBS([timer_create], [rt])
>> > AC_SEARCH_LIBS([pthread_create], [pthread])
>> >
>> > The timer call is tricky, because it not existing on some platforms is
>> > valid
>> > and in those cases Check compiles without it. On others the call exists
>> > but
>> > is broken and must be avoided. Check uses the following macro in the
>> > Check
>> > source to figure that out:
>> >
>> > HW_LIBRT_TIMERS
>> >
>> > Additionally, the pthread check is handled by the following macro in
>> > Check:
>> >
>> > ACX_PTHREAD
>> >
>> > If adding the AC_SEARCH_LIBS calls work for you on your platform, it is
>> > OK
>> > to include them in your example. Before the most complete checks for
>> > these
>> > libraries is added into the example, though, we need to figure out why
>> > you
>> > are running into these failures.
>> >
>> > I'll see if I can look-up any information as to what may be going on.
>> >
>> > - Branden
>> >
>> > On Fri, Sep 19, 2014 at 12:24 AM, Clay McClure <cl...@da...> wrote:
>> >>
>> >> On Thu, Sep 18, 2014 at 8:33 AM, Fredrik Hugosson
>> >> <fre...@ax...> wrote:
>> >>
>> >> > Still, I'm no autoconf guru so there may be even simpler/more correct
>> >> > ways to do it.
>> >>
>> >> That makes two of us :)
>> >>
>> >> This works:
>> >>
>> >> AC_SEARCH_LIBS([floor], [m])
>> >> AC_SEARCH_LIBS([timer_create], [rt])
>> >> AC_SEARCH_LIBS([pthread_create], [pthread])
>> >>
>> >> I forgot to add in my first post that I also had to change this line:
>> >>
>> >> AM_INIT_AUTOMAKE([-Wall -Werror foreign 1.9.6])
>> >>
>> >> to this:
>> >>
>> >> AM_INIT_AUTOMAKE([-Wall -Werror -Wno-extra-portability foreign 1.9.6])
>> >>
>> >> Without that, `autoreconf --install` fails with:
>> >>
>> >> /usr/share/automake-1.14/am/ltlibrary.am: warning: 'libmoney.la':
>> >> linking libtool libraries using a non-POSIX
>> >> /usr/share/automake-1.14/am/ltlibrary.am: archiver requires
>> >> 'AM_PROG_AR' in 'configure.ac'
>> >> src/Makefile.am:3:   while processing Libtool library 'libmoney.la'
>> >>
>> >> Thanks,
>> >>
>> >> Clay
>> >>
>> >>
>> >>
>> >> ------------------------------------------------------------------------------
>> >> Slashdot TV.  Video for Nerds.  Stuff that Matters.
>> >>
>> >>
>> >> http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
>> >> _______________________________________________
>> >> Check-devel mailing list
>> >> Che...@li...
>> >> https://lists.sourceforge.net/lists/listinfo/check-devel
>> >
>> >
>
>

Re: [Check-devel] Linker errors in Check example on Ubuntu 14.04

[Branden A. <b.m...@gm...>]

What version of Check are you compiling the example from? I believe that
the example since Check 0.9.13 uses pkg-config:

# Checks for libraries.
PKG_CHECK_MODULES
<https://autotools.io/pkgconfig/pkg_check_modules.html>([CHECK],
[check >= 0.9.6])

Maybe the macro is not being used properly, or something else is going
wrong?

- Branden

On Mon, Sep 22, 2014 at 10:35 PM, Clay McClure <cl...@da...> wrote:

> Hi Branden,
>
> Yes, Check is installed as a static library on Ubuntu:
>
> $ dpkg -L check | grep /lib//usr/lib/x86_64-linux-gnu
> /usr/lib/x86_64-linux-gnu/libcheck_pic.a
> /usr/lib/x86_64-linux-gnu/pkgconfig
> /usr/lib/x86_64-linux-gnu/pkgconfig/check.pc
> /usr/lib/x86_64-linux-gnu/libcheck.a
>
> Noticing the pkgconfig directory, I remembered reading about
> pkg-config and tried:
>
> $ pkg-config --cflags --libs check
> -pthread  -pthread -lcheck_pic -lrt -lm
>
> which is exactly what I need. So I suppose the answer is to update the
> example Makefile to use pkg-config, where possible. Thoughts on how
> best to do that?
>
> Cheers,
>
> Clay
>
>
> On Mon, Sep 22, 2014 at 9:48 PM, Branden Archer <b.m...@gm...>
> wrote:
> > Out of curiosity, is this necessary because on Ubuntu Check is provided
> as a
> > static library? I've not run into this issue before, but on my system
> Check
> > is a dynamic library.
> >
> > I'd be cautious about including these macros into the configure script
> as is
> > if one is interested in multi-platform support:
> >
> > AC_SEARCH_LIBS([timer_create], [rt])
> > AC_SEARCH_LIBS([pthread_create], [pthread])
> >
> > The timer call is tricky, because it not existing on some platforms is
> valid
> > and in those cases Check compiles without it. On others the call exists
> but
> > is broken and must be avoided. Check uses the following macro in the
> Check
> > source to figure that out:
> >
> > HW_LIBRT_TIMERS
> >
> > Additionally, the pthread check is handled by the following macro in
> Check:
> >
> > ACX_PTHREAD
> >
> > If adding the AC_SEARCH_LIBS calls work for you on your platform, it is
> OK
> > to include them in your example. Before the most complete checks for
> these
> > libraries is added into the example, though, we need to figure out why
> you
> > are running into these failures.
> >
> > I'll see if I can look-up any information as to what may be going on.
> >
> > - Branden
> >
> > On Fri, Sep 19, 2014 at 12:24 AM, Clay McClure <cl...@da...> wrote:
> >>
> >> On Thu, Sep 18, 2014 at 8:33 AM, Fredrik Hugosson
> >> <fre...@ax...> wrote:
> >>
> >> > Still, I'm no autoconf guru so there may be even simpler/more correct
> >> > ways to do it.
> >>
> >> That makes two of us :)
> >>
> >> This works:
> >>
> >> AC_SEARCH_LIBS([floor], [m])
> >> AC_SEARCH_LIBS([timer_create], [rt])
> >> AC_SEARCH_LIBS([pthread_create], [pthread])
> >>
> >> I forgot to add in my first post that I also had to change this line:
> >>
> >> AM_INIT_AUTOMAKE([-Wall -Werror foreign 1.9.6])
> >>
> >> to this:
> >>
> >> AM_INIT_AUTOMAKE([-Wall -Werror -Wno-extra-portability foreign 1.9.6])
> >>
> >> Without that, `autoreconf --install` fails with:
> >>
> >> /usr/share/automake-1.14/am/ltlibrary.am: warning: 'libmoney.la':
> >> linking libtool libraries using a non-POSIX
> >> /usr/share/automake-1.14/am/ltlibrary.am: archiver requires
> >> 'AM_PROG_AR' in 'configure.ac'
> >> src/Makefile.am:3:   while processing Libtool library 'libmoney.la'
> >>
> >> Thanks,
> >>
> >> Clay
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Slashdot TV.  Video for Nerds.  Stuff that Matters.
> >>
> >>
> http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
> >> _______________________________________________
> >> Check-devel mailing list
> >> Che...@li...
> >> https://lists.sourceforge.net/lists/listinfo/check-devel
> >
> >
>

Re: [Check-devel] Linker errors in Check example on Ubuntu 14.04

[Clay M. <cl...@da...>]

Hi Branden,

Yes, Check is installed as a static library on Ubuntu:

$ dpkg -L check | grep /lib//usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libcheck_pic.a
/usr/lib/x86_64-linux-gnu/pkgconfig
/usr/lib/x86_64-linux-gnu/pkgconfig/check.pc
/usr/lib/x86_64-linux-gnu/libcheck.a

Noticing the pkgconfig directory, I remembered reading about
pkg-config and tried:

$ pkg-config --cflags --libs check
-pthread  -pthread -lcheck_pic -lrt -lm

which is exactly what I need. So I suppose the answer is to update the
example Makefile to use pkg-config, where possible. Thoughts on how
best to do that?

Cheers,

Clay


On Mon, Sep 22, 2014 at 9:48 PM, Branden Archer <b.m...@gm...> wrote:
> Out of curiosity, is this necessary because on Ubuntu Check is provided as a
> static library? I've not run into this issue before, but on my system Check
> is a dynamic library.
>
> I'd be cautious about including these macros into the configure script as is
> if one is interested in multi-platform support:
>
> AC_SEARCH_LIBS([timer_create], [rt])
> AC_SEARCH_LIBS([pthread_create], [pthread])
>
> The timer call is tricky, because it not existing on some platforms is valid
> and in those cases Check compiles without it. On others the call exists but
> is broken and must be avoided. Check uses the following macro in the Check
> source to figure that out:
>
> HW_LIBRT_TIMERS
>
> Additionally, the pthread check is handled by the following macro in Check:
>
> ACX_PTHREAD
>
> If adding the AC_SEARCH_LIBS calls work for you on your platform, it is OK
> to include them in your example. Before the most complete checks for these
> libraries is added into the example, though, we need to figure out why you
> are running into these failures.
>
> I'll see if I can look-up any information as to what may be going on.
>
> - Branden
>
> On Fri, Sep 19, 2014 at 12:24 AM, Clay McClure <cl...@da...> wrote:
>>
>> On Thu, Sep 18, 2014 at 8:33 AM, Fredrik Hugosson
>> <fre...@ax...> wrote:
>>
>> > Still, I'm no autoconf guru so there may be even simpler/more correct
>> > ways to do it.
>>
>> That makes two of us :)
>>
>> This works:
>>
>> AC_SEARCH_LIBS([floor], [m])
>> AC_SEARCH_LIBS([timer_create], [rt])
>> AC_SEARCH_LIBS([pthread_create], [pthread])
>>
>> I forgot to add in my first post that I also had to change this line:
>>
>> AM_INIT_AUTOMAKE([-Wall -Werror foreign 1.9.6])
>>
>> to this:
>>
>> AM_INIT_AUTOMAKE([-Wall -Werror -Wno-extra-portability foreign 1.9.6])
>>
>> Without that, `autoreconf --install` fails with:
>>
>> /usr/share/automake-1.14/am/ltlibrary.am: warning: 'libmoney.la':
>> linking libtool libraries using a non-POSIX
>> /usr/share/automake-1.14/am/ltlibrary.am: archiver requires
>> 'AM_PROG_AR' in 'configure.ac'
>> src/Makefile.am:3:   while processing Libtool library 'libmoney.la'
>>
>> Thanks,
>>
>> Clay
>>
>>
>> ------------------------------------------------------------------------------
>> Slashdot TV.  Video for Nerds.  Stuff that Matters.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Check-devel mailing list
>> Che...@li...
>> https://lists.sourceforge.net/lists/listinfo/check-devel
>
>

Re: [Check-devel] Linker errors in Check example on Ubuntu 14.04

[Branden A. <b.m...@gm...>]

Out of curiosity, is this necessary because on Ubuntu Check is provided as
a static library? I've not run into this issue before, but on my system
Check is a dynamic library.

I'd be cautious about including these macros into the configure script as
is if one is interested in multi-platform support:

AC_SEARCH_LIBS([timer_create], [rt])
AC_SEARCH_LIBS([pthread_create], [pthread])

The timer call is tricky, because it not existing on some platforms is
valid and in those cases Check compiles without it. On others the call
exists but is broken and must be avoided. Check uses the following macro in
the Check source to figure that out:

HW_LIBRT_TIMERS

Additionally, the pthread check is handled by the following macro in Check:

ACX_PTHREAD

If adding the AC_SEARCH_LIBS calls work for you on your platform, it is OK
to include them in your example. Before the most complete checks for these
libraries is added into the example, though, we need to figure out why you
are running into these failures.

I'll see if I can look-up any information as to what may be going on.

- Branden

On Fri, Sep 19, 2014 at 12:24 AM, Clay McClure <cl...@da...> wrote:

> On Thu, Sep 18, 2014 at 8:33 AM, Fredrik Hugosson
> <fre...@ax...> wrote:
>
> > Still, I'm no autoconf guru so there may be even simpler/more correct
> ways to do it.
>
> That makes two of us :)
>
> This works:
>
> AC_SEARCH_LIBS([floor], [m])
> AC_SEARCH_LIBS([timer_create], [rt])
> AC_SEARCH_LIBS([pthread_create], [pthread])
>
> I forgot to add in my first post that I also had to change this line:
>
> AM_INIT_AUTOMAKE([-Wall -Werror foreign 1.9.6])
>
> to this:
>
> AM_INIT_AUTOMAKE([-Wall -Werror -Wno-extra-portability foreign 1.9.6])
>
> Without that, `autoreconf --install` fails with:
>
> /usr/share/automake-1.14/am/ltlibrary.am: warning: 'libmoney.la':
> linking libtool libraries using a non-POSIX
> /usr/share/automake-1.14/am/ltlibrary.am: archiver requires
> 'AM_PROG_AR' in 'configure.ac'
> src/Makefile.am:3:   while processing Libtool library 'libmoney.la'
>
> Thanks,
>
> Clay
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.  Video for Nerds.  Stuff that Matters.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
> _______________________________________________
> Check-devel mailing list
> Che...@li...
> https://lists.sourceforge.net/lists/listinfo/check-devel
>

[Check-devel] A test runner generator.

[xakz <xa...@gm...>]

Hi,

I wish to present to you a test runner generator that I just developed.

I needed a better approach to fixtures and test naming. So, firstly, I
wanted extend checkmk and send a patch but the code is hard to extend
without rewriting big parts. Thus, I rewritten an almost compatible tool
from scratch that handles fixtures and test names like I want.

If you want test it, it can be downloaded at:
https://github.com/xakz/checkgen

The full documentation is included, including compatibility details.

Any return or suggestion are greatly appreciated.

--
Maxime Chatelle

Re: [Check-devel] Linker errors in Check example on Ubuntu 14.04

[Clay M. <cl...@da...>]

On Thu, Sep 18, 2014 at 8:33 AM, Fredrik Hugosson
<fre...@ax...> wrote:

> Still, I'm no autoconf guru so there may be even simpler/more correct ways to do it.

That makes two of us :)

This works:

AC_SEARCH_LIBS([floor], [m])
AC_SEARCH_LIBS([timer_create], [rt])
AC_SEARCH_LIBS([pthread_create], [pthread])

I forgot to add in my first post that I also had to change this line:

AM_INIT_AUTOMAKE([-Wall -Werror foreign 1.9.6])

to this:

AM_INIT_AUTOMAKE([-Wall -Werror -Wno-extra-portability foreign 1.9.6])

Without that, `autoreconf --install` fails with:

/usr/share/automake-1.14/am/ltlibrary.am: warning: 'libmoney.la':
linking libtool libraries using a non-POSIX
/usr/share/automake-1.14/am/ltlibrary.am: archiver requires
'AM_PROG_AR' in 'configure.ac'
src/Makefile.am:3:   while processing Libtool library 'libmoney.la'

Thanks,

Clay

Re: [Check-devel] Linker errors in Check example on Ubuntu 14.04

[Fredrik H. <fre...@ax...>]

Hi!

Nice to see that you are interested in check, and thanks for the bug report! It is really appreciated and the only way to move stuff forward.

Now on to the problem at hand, I'm not sure that your proposed solution is the correct way to fix the problem. If just adding the checks for the libraries actually fixes the problem, we should really just make sure that the correct linker directives are added.

>From the autoconf manual for AC_CHECK_LIB:
"These days it is normally better to use AC_SEARCH_LIBS([gethostbyname], [nsl]) instead of AC_CHECK_LIB([nsl], [gethostbyname])."

>From the autoconf manual for AC_SEARCH_LIBS:
"Search for a library defining function if it's not already available. This equates to calling 'AC_LINK_IFELSE([AC_LANG_CALL([], [function])])' first with no libraries, then for each library listed in search-libs.

Prepend -llibrary to LIBS for the first library found to contain function, and run action-if-found. If the function is not found, run action-if-not-found."

Still, I'm no autoconf guru so there may be even simpler/more correct ways to do it.

Cheers,
/Fredrik

 -----Original Message-----
From: Clay McClure [mailto:cl...@da...] 
Sent: den 16 september 2014 07:58
To: che...@li...
Subject: [Check-devel] Linker errors in Check example on Ubuntu 14.04

Howdy,

In working through the Check tutorial, step 3.5 (here:
http://check.sourceforge.net/doc/check_html/check_3.html#Creating-a-Suite-1)
on Ubuntu 14.04, I've run into some linker errors:

/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_create':
(.text+0x194): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_create':
(.text+0x1a8): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_set_timeout':
(.text+0x435): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_set_timeout':
(.text+0x449): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_pack.o):
In function `ppack':
(.text+0x51d): undefined reference to `__pthread_register_cancel'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_pack.o):
In function `ppack':
(.text+0x551): undefined reference to `__pthread_unregister_cancel'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_run.o):
In function `srunner_run':
(.text+0x965): undefined reference to `timer_create'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_run.o):
In function `srunner_run':
(.text+0x9b3): undefined reference to `timer_settime'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_run.o):
In function `srunner_run':
(.text+0x9d9): undefined reference to `timer_delete'
collect2: error: ld returned 1 exit status

Adding the following to configure.ac fixes that up:

# Checks for libraries
AC_CHECK_LIB(m, floor)
AC_CHECK_LIB(rt, setitimer)
AC_CHECK_LIB(pthread, pthread_create)

If that looks like an acceptable fix, I'd be happy to submit a patch.

Thanks, and happy checking!

Clay

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce.
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Check-devel mailing list
Che...@li...
https://lists.sourceforge.net/lists/listinfo/check-devel

[Check-devel] Linker errors in Check example on Ubuntu 14.04

[Clay M. <cl...@da...>]

Howdy,

In working through the Check tutorial, step 3.5 (here:
http://check.sourceforge.net/doc/check_html/check_3.html#Creating-a-Suite-1)
on Ubuntu 14.04, I've run into some linker errors:

/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_create':
(.text+0x194): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_create':
(.text+0x1a8): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_set_timeout':
(.text+0x435): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check.o):
In function `tcase_set_timeout':
(.text+0x449): undefined reference to `floor'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_pack.o):
In function `ppack':
(.text+0x51d): undefined reference to `__pthread_register_cancel'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_pack.o):
In function `ppack':
(.text+0x551): undefined reference to `__pthread_unregister_cancel'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_run.o):
In function `srunner_run':
(.text+0x965): undefined reference to `timer_create'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_run.o):
In function `srunner_run':
(.text+0x9b3): undefined reference to `timer_settime'
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libcheck.a(check_run.o):
In function `srunner_run':
(.text+0x9d9): undefined reference to `timer_delete'
collect2: error: ld returned 1 exit status

Adding the following to configure.ac fixes that up:

# Checks for libraries
AC_CHECK_LIB(m, floor)
AC_CHECK_LIB(rt, setitimer)
AC_CHECK_LIB(pthread, pthread_create)

If that looks like an acceptable fix, I'd be happy to submit a patch.

Thanks, and happy checking!

Clay

[Check-devel] You have a new notification from zplesivcak@gmail.com. View??

[<zpl...@gm...>]

Hi,

zpl...@gm... wants to follow you.

****** Is zpl...@gm... you friend? ******
If Yes please follow the link below:
http://invites.infoaxe.net/signup_e.html?fullname=&ema...@li...&inv...@gm...&inviterid=30305487&userid=0&token=0&emailmasterid=50043be3-089b-4125-b003-03c3f97f174f&fro...@gm...&src=txt_yes

If No please follow the link below:
http://invites.infoaxe.net/signup_e.html?fullname=&ema...@li...&inv...@gm...&inviterid=30305487&userid=0&token=0&emailmasterid=50043be3-089b-4125-b003-03c3f97f174f&fro...@gm...&src=txt_no


Follow the link below to remove yourself from all such emails
http://invites.infoaxe.net/uns_inviter.jsp?ema...@li...&iid=50043be3-089b-4125-b003-03c3f97f174f&fro...@gm...

[Check-devel] zplesivcak@gmail.com has indicated you're a friend. Accept?

[<zpl...@gm...>]

Hi,

zpl...@gm... wants to follow you.

****** Is zpl...@gm... you friend? ******
If Yes please follow the link below:
http://invites.info-emailer.com/signup_e.html?fullname=&ema...@li...&inv...@gm...&inviterid=30305487&userid=0&token=0&emailmasterid=3428a971-1c3b-4788-90b8-197939c09406&fro...@gm...&src=txt_yes

If No please follow the link below:
http://invites.info-emailer.com/signup_e.html?fullname=&ema...@li...&inv...@gm...&inviterid=30305487&userid=0&token=0&emailmasterid=3428a971-1c3b-4788-90b8-197939c09406&fro...@gm...&src=txt_no


Follow the link below to remove yourself from all such emails
http://invites.info-emailer.com/uns_inviter.jsp?ema...@li...&iid=3428a971-1c3b-4788-90b8-197939c09406&fro...@gm...

[Check-devel] check-0.9.14 released

[Branden A. <b.m...@gm...>]

Hi all!

This release of Check fixes a few issues that were found on the Solaris and
AIX platforms; resolving these Check now successfully compiles and tests on
these platforms. In addition, a few bugs were resolved and additional unit
tests enabled.
Please test it out and report any problems you might have.

http://prdownloads.sourceforge.net/check/check-0.9.14.tar.gz?download

Thanks,
Branden


Sat July 26, 2014: Released Check 0.9.14
  based on r1174 (2014-07-03 18:43:49 +0000)

* Changes to (unofficially for now) support Solaris and AIX platforms.

* Fix issue with checked teardown functions in CK_NOFORK mode. If
  the teardown function called an assertion that failed, an
  infinate loop would result. Bug#98. As a result of the change, for now
  checked teardown functions that fail in CK_NOFORK mode will
  not cause the test to fail.

* Allow checked fixtures when compiled without fork(). Previously
  such setup/teardown functions were disabled, as the full contract
  for checked fixtures could not be honored. Checked fixtures
  in CK_NOFORK mode are now closer to the contract, and are now
  enabled.

* Various code cleanup, including changes for compiling Check on
  c++ compilers Clang and g++ (which are less forgiving than their
  c counterparts).

* Re-enable internal unit tests, which verify which line numbers are
  reported for unit test failures. (The tests were unintentionally
  disabled in a previous release).

Re: [Check-devel] Minor Check code changes

[Branden A. <b.m...@gm...>]

>
> However the patch is turning out to be more complicated than I thought.


I was starting to think the same thing. Sometimes cross platform
compatibility makes simple things hard.

Thanks for the suggestion, though.


On Wed, Jun 25, 2014 at 10:18 AM, Michael Piszczek <mpi...@dd...>
wrote:

>  The only alternative I can find on Windows is g_mkstemp()
>
> https://developer.gnome.org/glib/2.37/glib-File-Utilities.html#g-mkstemp
>
>
>
> However the patch is turning out to be more complicated than I thought.
> It  might be better to leave it alone if no one is having problems.
>
>
>
> Thanks
>
> Mike P
>
>
>
>
>
> *From:* Branden Archer [mailto:b.m...@gm...]
> *Sent:* Wednesday, June 25, 2014 9:22 AM
>
> *To:* Michael Piszczek
> *Cc:* Che...@li...
> *Subject:* Re: [Check-devel] Minor Check code changes
>
>
>
> It turns out that both MinGW and MSVC do not have mkstemp(). Maybe that is
> not so surprising, as mkstemp() is a POSIX extension, whereas tempnam() is
> ISO C90.
>
>
>
> I cannot find an obvious alternative for mkstemp() that would be a better
> replacement for tempnam() on Windows. Anything come to mind?
>
>
>
> On Tue, Jun 24, 2014 at 10:44 PM, Branden Archer <b.m...@gm...>
> wrote:
>
> Thanks for the patch!
>
> The only change which will be made is to remove the pid stuff; it is not
> needed anymore as mkstemp will guarantee the file is unique.
>
>
>
> -        uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp,
> getpid());
>
> +        uniq_tmp_file = ck_strdup_printf("%s/check_XXXXXX", tmp);
>
>
>
> I will give this a try on MinGW and MSVC to make sure that they both have
> mkstemp() available. If so, I will push the change and let you know.
>
>
>

Re: [Check-devel] Minor Check code changes

[Michael P. <mpi...@dd...>]

The only alternative I can find on Windows is g_mkstemp()
https://developer.gnome.org/glib/2.37/glib-File-Utilities.html#g-mkstemp

However the patch is turning out to be more complicated than I thought.  It  might be better to leave it alone if no one is having problems.

Thanks
Mike P


From: Branden Archer [mailto:b.m...@gm...]
Sent: Wednesday, June 25, 2014 9:22 AM
To: Michael Piszczek
Cc: Che...@li...
Subject: Re: [Check-devel] Minor Check code changes

It turns out that both MinGW and MSVC do not have mkstemp(). Maybe that is not so surprising, as mkstemp() is a POSIX extension, whereas tempnam() is ISO C90.

I cannot find an obvious alternative for mkstemp() that would be a better replacement for tempnam() on Windows. Anything come to mind?

On Tue, Jun 24, 2014 at 10:44 PM, Branden Archer <b.m...@gm...<mailto:b.m...@gm...>> wrote:
Thanks for the patch!

The only change which will be made is to remove the pid stuff; it is not needed anymore as mkstemp will guarantee the file is unique.

-        uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp, getpid());
+        uniq_tmp_file = ck_strdup_printf("%s/check_XXXXXX", tmp);

I will give this a try on MinGW and MSVC to make sure that they both have mkstemp() available. If so, I will push the change and let you know.

Re: [Check-devel] Minor Check code changes

[Branden A. <b.m...@gm...>]

It turns out that both MinGW and MSVC do not have mkstemp(). Maybe that is
not so surprising, as mkstemp() is a POSIX extension, whereas tempnam() is
ISO C90.

I cannot find an obvious alternative for mkstemp() that would be a better
replacement for tempnam() on Windows. Anything come to mind?


On Tue, Jun 24, 2014 at 10:44 PM, Branden Archer <b.m...@gm...>
wrote:

> Thanks for the patch!
>
> The only change which will be made is to remove the pid stuff; it is not
> needed anymore as mkstemp will guarantee the file is unique.
>
>
> -        uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp,
> getpid());
>
> +        uniq_tmp_file = ck_strdup_printf("%s/check_XXXXXX", tmp);
>
> I will give this a try on MinGW and MSVC to make sure that they both have
> mkstemp() available. If so, I will push the change and let you know.
>

Re: [Check-devel] Minor Check code changes

[Branden A. <b.m...@gm...>]

Thanks for the patch!

The only change which will be made is to remove the pid stuff; it is not
needed anymore as mkstemp will guarantee the file is unique.


-        uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp,
getpid());

+        uniq_tmp_file = ck_strdup_printf("%s/check_XXXXXX", tmp);

I will give this a try on MinGW and MSVC to make sure that they both have
mkstemp() available. If so, I will push the change and let you know.

Re: [Check-devel] Minor Check code changes

[Michael P. <mpi...@dd...>]

Hi Branden

Here is a new patch with that incorporates the original functionality of tempnam().

It tries to use TMPDIR first.
If TMPDIR is not set it uses TEMP.
If TEMP is not set it uses P_tmpdir.
If P_tmpdir is not set is uses ‘/’


Index: src/check_msg.c
===================================================================
--- src/check_msg.c     (revision 1173)
+++ src/check_msg.c     (working copy)
@@ -234,24 +234,30 @@
     file = tmpfile();
     if(file == NULL)
     {
-        char *tmp = getenv("TEMP");
-        char *tmp_file = tempnam(tmp, "check_");
+        int fd;
+        char *tmp = getenv("TMPDIR");
+        char *uniq_tmp_file;

-        /*
-         * Note, tempnam is not enough to get a unique name. Between
-         * getting the name and opening the file, something else also
-         * calling tempnam() could get the same name. It has been observed
-         * on MinGW-w64 builds on Wine that this exact thing happens
-         * if multiple instances of a unit tests are running concurrently.
-         * To prevent two concurrent unit tests from getting the same file,
-         * we append the pid to the file. The pid should be unique on the
-         * system.
-         */
-        char *uniq_tmp_file = ck_strdup_printf("%s.%d", tmp_file, getpid());
+        if(tmp == NULL)
+        {
+            tmp = getenv("TEMP");
+        }
+        if(tmp == NULL)
+        {
+            tmp = P_tmpdir;
+        }
+        if(tmp == NULL)
+        {
+            tmp = "";
+        }
+
+        uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp, getpid());
+        fd = mkstemp(uniq_tmp_file);
+        if(fd < 0)
+            eprintf("Error in call to mkstemp",__FILE__, __LINE__ - 2);

-        file = fopen(uniq_tmp_file, "w+b");
+        file = fdopen(fd, "w+b");
         *name = uniq_tmp_file;
-        free(tmp_file);
     }
     return file;
}


Thanks
Mike P

From: Branden Archer [mailto:b.m...@gm...]
Sent: Sunday, June 22, 2014 10:15 PM
To: Michael Piszczek
Cc: Che...@li...
Subject: Re: [Check-devel] Minor Check code changes

Michael,

Thanks for your interest in Check.

Sorry no one has responded thus far to your email. (For whatever reason the email did not end up in my main inbox, and I found it elsewhere).

The first few changes and the last look just fine. I've got them locally and will push them soon. Your name will be added to the AUTHORS file. Thanks!

The tempnam() -> mkstemp() change looks good, but I have a question. Originally Check only used tmpfile(), but it was found that part of that call (unlink on close) was not honored in Windows because of how Windows handled the file system. The result was a lot of files building up in a directory...  The question with the proposed change is "where will the file go if the TEMP environment variable is missing"? The previous implementation, at least on my system, would not find TEMP in my environment, and tempnam() would fallback on the TMPDIR environment var, or failing that whatever P_tmpdir points to in stdio.h. If mkstemp() does not provide these fallbacks, may you submit a patch that takes that into account?

- Branden

On Thu, Jun 5, 2014 at 4:11 PM, Michael Piszczek <mpi...@dd...<mailto:mpi...@dd...>> wrote:
Hi,

I wanted to recommend some minor code changes to Check. A couple of these resolve issues I saw when running Coverity against Check.
Also I replaced tempnam() with mkstemp();
See below.

Thanks
Mike P.


Index: src/check_pack.c
===================================================================
--- src/check_pack.c    (revision 1141)
+++ src/check_pack.c    (working copy)
@@ -298,7 +298,7 @@

void ppack(FILE * fdes, enum ck_msg_type type, CheckMsg * msg)
{
-    char *buf;
+    char *buf = NULL;
     int n;
     ssize_t r;

Index: src/check_log.c
===================================================================
--- src/check_log.c     (revision 1141)
+++ src/check_log.c     (working copy)
@@ -341,7 +341,6 @@
               enum cl_event evt)
{
     TestResult *tr;
-    Suite *s;

     static int num_tests_run = 0;

Index: src/check_pack.h
===================================================================
--- src/check_pack.h    (revision 1141)
+++ src/check_pack.h    (working copy)
@@ -57,6 +57,7 @@
     CtxMsg ctx_msg;
     FailMsg fail_msg;
     LocMsg loc_msg;
+    DurationMsg duration_msg;
} CheckMsg;

typedef struct RcvMsg
Index: src/check_msg.c
===================================================================
--- src/check_msg.c     (revision 1141)
+++ src/check_msg.c     (working copy)
@@ -235,23 +235,13 @@
     if(file == NULL)
     {
         char *tmp = getenv("TEMP");
-        char *tmp_file = tempnam(tmp, "check_");
+        char *uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp, getpid());
+        int fd = mkstemp(uniq_tmp_file);
+        if (fd < 0)
+            eprintf("Error in call to mkstemp",__FILE__, __LINE__ - 2);

-        /*
-         * Note, tempnam is not enough to get a unique name. Between
-         * getting the name and opening the file, something else also
-         * calling tempnam() could get the same name. It has been observed
-         * on MinGW-w64 builds on Wine that this exact thing happens
-         * if multiple instances of a unit tests are running concurrently.
-         * To prevent two concurrent unit tests from getting the same file,
-         * we append the pid to the file. The pid should be unique on the
-         * system.
-         */
-        char *uniq_tmp_file = ck_strdup_printf("%s.%d", tmp_file, getpid());
-
-        file = fopen(uniq_tmp_file, "w+b");
+        file = fdopen(fd, "w+b");
         *name = uniq_tmp_file;
-        free(tmp_file);
     }
     return file;
}
Index: src/check_print.c
===================================================================
--- src/check_print.c   (revision 1141)
+++ src/check_print.c   (working copy)
@@ -198,8 +198,8 @@
     fprintf(file, "      <id>%s</id>\n", tr->tname);
     fprintf(file, "      <iteration>%d</iteration>\n", tr->iter);
     fprintf(file, "      <duration>%d.%06d</duration>\n",
-            tr->duration < 0 ? -1 : tr->duration / 1000000,
-            tr->duration < 0 ? 0 : tr->duration % 1000000);
+            tr->duration < 0 ? -1 : tr->duration / US_PER_SEC,
+            tr->duration < 0 ? 0 : tr->duration % US_PER_SEC);
     fprintf(file, "      <description>");
     fprint_xml_esc(file, tr->tcname);
     fprintf(file, "</description>\n");


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Check-devel mailing list
Che...@li...<mailto:Che...@li...>
https://lists.sourceforge.net/lists/listinfo/check-devel

Re: [Check-devel] Minor Check code changes

[Branden A. <b.m...@gm...>]

Michael,

Thanks for your interest in Check.

Sorry no one has responded thus far to your email. (For whatever reason the
email did not end up in my main inbox, and I found it elsewhere).

The first few changes and the last look just fine. I've got them locally
and will push them soon. Your name will be added to the AUTHORS file.
Thanks!

The tempnam() -> mkstemp() change looks good, but I have a question.
Originally Check only used tmpfile(), but it was found that part of that
call (unlink on close) was not honored in Windows because of how Windows
handled the file system. The result was a lot of files building up in a
directory...  The question with the proposed change is "where will the file
go if the TEMP environment variable is missing"? The previous
implementation, at least on my system, would not find TEMP in my
environment, and tempnam() would fallback on the TMPDIR environment var, or
failing that whatever P_tmpdir points to in stdio.h. If mkstemp() does not
provide these fallbacks, may you submit a patch that takes that into
account?

- Branden


On Thu, Jun 5, 2014 at 4:11 PM, Michael Piszczek <mpi...@dd...> wrote:

>  Hi,
>
>
>
> I wanted to recommend some minor code changes to Check. A couple of these
> resolve issues I saw when running Coverity against Check.
>
> Also I replaced tempnam() with mkstemp();
>
> See below.
>
>
>
> Thanks
>
> Mike P.
>
>
>
>
>
> Index: src/check_pack.c
>
> ===================================================================
>
> --- src/check_pack.c    (revision 1141)
>
> +++ src/check_pack.c    (working copy)
>
> @@ -298,7 +298,7 @@
>
>
>
> void ppack(FILE * fdes, enum ck_msg_type type, CheckMsg * msg)
>
> {
>
> -    char *buf;
>
> +    char *buf = NULL;
>
>      int n;
>
>      ssize_t r;
>
>
>
> Index: src/check_log.c
>
> ===================================================================
>
> --- src/check_log.c     (revision 1141)
>
> +++ src/check_log.c     (working copy)
>
> @@ -341,7 +341,6 @@
>
>                enum cl_event evt)
>
> {
>
>      TestResult *tr;
>
> -    Suite *s;
>
>
>
>      static int num_tests_run = 0;
>
>
>
> Index: src/check_pack.h
>
> ===================================================================
>
> --- src/check_pack.h    (revision 1141)
>
> +++ src/check_pack.h    (working copy)
>
> @@ -57,6 +57,7 @@
>
>      CtxMsg ctx_msg;
>
>      FailMsg fail_msg;
>
>      LocMsg loc_msg;
>
> +    DurationMsg duration_msg;
>
> } CheckMsg;
>
>
>
> typedef struct RcvMsg
>
> Index: src/check_msg.c
>
> ===================================================================
>
> --- src/check_msg.c     (revision 1141)
>
> +++ src/check_msg.c     (working copy)
>
> @@ -235,23 +235,13 @@
>
>      if(file == NULL)
>
>      {
>
>          char *tmp = getenv("TEMP");
>
> -        char *tmp_file = tempnam(tmp, "check_");
>
> +        char *uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp,
> getpid());
>
> +        int fd = mkstemp(uniq_tmp_file);
>
> +        if (fd < 0)
>
> +            eprintf("Error in call to mkstemp",__FILE__, __LINE__ - 2);
>
>
>
> -        /*
>
> -         * Note, tempnam is not enough to get a unique name. Between
>
> -         * getting the name and opening the file, something else also
>
> -         * calling tempnam() could get the same name. It has been observed
>
> -         * on MinGW-w64 builds on Wine that this exact thing happens
>
> -         * if multiple instances of a unit tests are running concurrently.
>
> -         * To prevent two concurrent unit tests from getting the same
> file,
>
> -         * we append the pid to the file. The pid should be unique on the
>
> -         * system.
>
> -         */
>
> -        char *uniq_tmp_file = ck_strdup_printf("%s.%d", tmp_file,
> getpid());
>
> -
>
> -        file = fopen(uniq_tmp_file, "w+b");
>
> +        file = fdopen(fd, "w+b");
>
>          *name = uniq_tmp_file;
>
> -        free(tmp_file);
>
>      }
>
>      return file;
>
> }
>
> Index: src/check_print.c
>
> ===================================================================
>
> --- src/check_print.c   (revision 1141)
>
> +++ src/check_print.c   (working copy)
>
> @@ -198,8 +198,8 @@
>
>      fprintf(file, "      <id>%s</id>\n", tr->tname);
>
>      fprintf(file, "      <iteration>%d</iteration>\n", tr->iter);
>
>      fprintf(file, "      <duration>%d.%06d</duration>\n",
>
> -            tr->duration < 0 ? -1 : tr->duration / 1000000,
>
> -            tr->duration < 0 ? 0 : tr->duration % 1000000);
>
> +            tr->duration < 0 ? -1 : tr->duration / US_PER_SEC,
>
> +            tr->duration < 0 ? 0 : tr->duration % US_PER_SEC);
>
>      fprintf(file, "      <description>");
>
>      fprint_xml_esc(file, tr->tcname);
>
>      fprintf(file, "</description>\n");
>
>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Check-devel mailing list
> Che...@li...
> https://lists.sourceforge.net/lists/listinfo/check-devel
>
>

[Check-devel] Minor Check code changes

[Michael P. <mpi...@dd...>]

Hi,

I wanted to recommend some minor code changes to Check. A couple of these resolve issues I saw when running Coverity against Check.
Also I replaced tempnam() with mkstemp();
See below.

Thanks
Mike P.


Index: src/check_pack.c
===================================================================
--- src/check_pack.c    (revision 1141)
+++ src/check_pack.c    (working copy)
@@ -298,7 +298,7 @@

void ppack(FILE * fdes, enum ck_msg_type type, CheckMsg * msg)
{
-    char *buf;
+    char *buf = NULL;
     int n;
     ssize_t r;

Index: src/check_log.c
===================================================================
--- src/check_log.c     (revision 1141)
+++ src/check_log.c     (working copy)
@@ -341,7 +341,6 @@
               enum cl_event evt)
{
     TestResult *tr;
-    Suite *s;

     static int num_tests_run = 0;

Index: src/check_pack.h
===================================================================
--- src/check_pack.h    (revision 1141)
+++ src/check_pack.h    (working copy)
@@ -57,6 +57,7 @@
     CtxMsg ctx_msg;
     FailMsg fail_msg;
     LocMsg loc_msg;
+    DurationMsg duration_msg;
} CheckMsg;

typedef struct RcvMsg
Index: src/check_msg.c
===================================================================
--- src/check_msg.c     (revision 1141)
+++ src/check_msg.c     (working copy)
@@ -235,23 +235,13 @@
     if(file == NULL)
     {
         char *tmp = getenv("TEMP");
-        char *tmp_file = tempnam(tmp, "check_");
+        char *uniq_tmp_file = ck_strdup_printf("%s/check_%d_XXXXXX", tmp, getpid());
+        int fd = mkstemp(uniq_tmp_file);
+        if (fd < 0)
+            eprintf("Error in call to mkstemp",__FILE__, __LINE__ - 2);

-        /*
-         * Note, tempnam is not enough to get a unique name. Between
-         * getting the name and opening the file, something else also
-         * calling tempnam() could get the same name. It has been observed
-         * on MinGW-w64 builds on Wine that this exact thing happens
-         * if multiple instances of a unit tests are running concurrently.
-         * To prevent two concurrent unit tests from getting the same file,
-         * we append the pid to the file. The pid should be unique on the
-         * system.
-         */
-        char *uniq_tmp_file = ck_strdup_printf("%s.%d", tmp_file, getpid());
-
-        file = fopen(uniq_tmp_file, "w+b");
+        file = fdopen(fd, "w+b");
         *name = uniq_tmp_file;
-        free(tmp_file);
     }
     return file;
}
Index: src/check_print.c
===================================================================
--- src/check_print.c   (revision 1141)
+++ src/check_print.c   (working copy)
@@ -198,8 +198,8 @@
     fprintf(file, "      <id>%s</id>\n", tr->tname);
     fprintf(file, "      <iteration>%d</iteration>\n", tr->iter);
     fprintf(file, "      <duration>%d.%06d</duration>\n",
-            tr->duration < 0 ? -1 : tr->duration / 1000000,
-            tr->duration < 0 ? 0 : tr->duration % 1000000);
+            tr->duration < 0 ? -1 : tr->duration / US_PER_SEC,
+            tr->duration < 0 ? 0 : tr->duration % US_PER_SEC);
     fprintf(file, "      <description>");
     fprint_xml_esc(file, tr->tcname);
     fprintf(file, "</description>\n");

Re: [Check-devel] [Check-announce] check-0.9.13 released

[Chris P. <chr...@ma...>]

Yes, thanks a lot!  Chris

Fredrik Hugosson wrote:
> Nice work Branden!
> 
> Thanks a million!
> /Fredrik Hugosson
> 
> 
> On 05/31/2014 02:47 AM, Branden Archer wrote:
>> Hey all!
>>
>> This release addresses a few bugs, some of which address Windows
>> support. In addition, there is now a sample CMake project to follow for
>> Visual Studios or MSVC projects.
>>
>> Please test it out and report any problems you might have.
>>
>> http://prdownloads.sourceforge.net/check/check-0.9.13.tar.gz?download
>>
>> - Branden
>>
>>
>> NEWS:
>>
>> Fri May 30, 2014: Released Check 0.9.13
>>    based on r1137 (2014-05-26 21:03:09 +0000)
>>
>> * When a test assertion fails, exit() was invoked. This results in any
>>    registered exit handlers being invoked. A test should not be relied
>>    upon to clean up if it fails. Instead, _exit() will be used to signal
>>    a test failure, to prevent exit handlers from being invoked.
>>
>> * Fix issue with string formatting in ck_assert_(u)int_* calls, where using
>>    the % operator would be interpreted as a string formatter. Bug #96.
>>
>> * If the LOG/XML/TAP file name is set to "-" either through the
>>    srunner_set_log() srunner_set_xml() or srunner_set_tap() calls
>>    or through the related environment variables, the logged data will be
>>    printed to stdout instead of a file. This is mainly to support using TAP
>>    for fixtures which expect the results to be reported via stdout. However,
>>    it is available via all of Check's logging modalities.
>>
>> * For CMake builds, check_stdint.h was not being installed. This is now
>>    fixed.
>>
>> * Check's example under doc/example now also works for CMake projects
>>    using Visual Studios and MSVC. This includes an example CMake
>>    configuration.
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their 
> applications. Written by three acclaimed leaders in the field, 
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Check-devel mailing list
> Che...@li...
> https://lists.sourceforge.net/lists/listinfo/check-devel

Re: [Check-devel] [Check-announce] check-0.9.13 released

[Fredrik H. <fre...@ax...>]

Nice work Branden!

Thanks a million!
/Fredrik Hugosson


On 05/31/2014 02:47 AM, Branden Archer wrote:
> Hey all!
>
> This release addresses a few bugs, some of which address Windows
> support. In addition, there is now a sample CMake project to follow for
> Visual Studios or MSVC projects.
>
> Please test it out and report any problems you might have.
>
> http://prdownloads.sourceforge.net/check/check-0.9.13.tar.gz?download
>
> - Branden
>
>
> NEWS:
>
> Fri May 30, 2014: Released Check 0.9.13
>    based on r1137 (2014-05-26 21:03:09 +0000)
>
> * When a test assertion fails, exit() was invoked. This results in any
>    registered exit handlers being invoked. A test should not be relied
>    upon to clean up if it fails. Instead, _exit() will be used to signal
>    a test failure, to prevent exit handlers from being invoked.
>
> * Fix issue with string formatting in ck_assert_(u)int_* calls, where using
>    the % operator would be interpreted as a string formatter. Bug #96.
>
> * If the LOG/XML/TAP file name is set to "-" either through the
>    srunner_set_log() srunner_set_xml() or srunner_set_tap() calls
>    or through the related environment variables, the logged data will be
>    printed to stdout instead of a file. This is mainly to support using TAP
>    for fixtures which expect the results to be reported via stdout. However,
>    it is available via all of Check's logging modalities.
>
> * For CMake builds, check_stdint.h was not being installed. This is now
>    fixed.
>
> * Check's example under doc/example now also works for CMake projects
>    using Visual Studios and MSVC. This includes an example CMake
>    configuration.

[Check-devel] check-0.9.13 released

[Branden A. <b.m...@gm...>]

Hey all!

This release addresses a few bugs, some of which address Windows support.
In addition, there is now a sample CMake project to follow for Visual
Studios or MSVC projects.

Please test it out and report any problems you might have.

http://prdownloads.sourceforge.net/check/check-0.9.13.tar.gz?download

- Branden


NEWS:

Fri May 30, 2014: Released Check 0.9.13
  based on r1137 (2014-05-26 21:03:09 +0000)

* When a test assertion fails, exit() was invoked. This results in any
  registered exit handlers being invoked. A test should not be relied
  upon to clean up if it fails. Instead, _exit() will be used to signal
  a test failure, to prevent exit handlers from being invoked.

* Fix issue with string formatting in ck_assert_(u)int_* calls, where using
  the % operator would be interpreted as a string formatter. Bug #96.

* If the LOG/XML/TAP file name is set to "-" either through the
  srunner_set_log() srunner_set_xml() or srunner_set_tap() calls
  or through the related environment variables, the logged data will be
  printed to stdout instead of a file. This is mainly to support using TAP
  for fixtures which expect the results to be reported via stdout. However,
  it is available via all of Check's logging modalities.

* For CMake builds, check_stdint.h was not being installed. This is now
  fixed.

* Check's example under doc/example now also works for CMake projects
  using Visual Studios and MSVC. This includes an example CMake
  configuration.

[Check-devel] Check release soon

[Branden A. <b.m...@gm...>]

Thinking about releasing a new version of check in the near future. This
would not yet be a 1.0 release, but instead 0.9.13. There are a few general
fixes and a cmake project example for Windows users.

I've run all Check's tests on VMs for all currently supported platforms,
and everything went well. The Jenkins instance provided by
CloudBees<https://check.ci.cloudbees.com> for
the project has been helpful in verifying that the various combinations of
configure options also continues to work. If others are interested in
trying out svn's head in the next few days, let me know if anything is
found. Otherwise, I will move forward with a release some time next week.

Thanks!

- Branden

Re: [Check-devel] Fwd: check-0.9.12/tests/test.log linux 37%: Checks: 8, Failures: 4, Errors: 1

[w l. <w.l...@cs...>]

Thanks Chris.
I have used check-0.9.12 to run the pidgin-2.6.5 test suite
and it looks fine:-)
Bill

On 4/29/14, Chris Pickett <chr...@ma...> wrote:
> I'm pretty sure those are expected failures and error messages, since we
> are testing our own ability to throw up errors when we run make check.
> Second, make check takes a while because there are timing tests for the
> timeout function being run, just need to be patient with it.  Let us know
> if this clarifies things, and if you run into other problems.  Have fun!
>
> Chris
>
> On Tue, April 29, 2014 6:35 am, w langdon wrote:
>> Dear Checkers,
>> Last night I downloaded check-0.9.12.tar.gz
>> make check eventually terminated saying ==================
>> All 7 tests passed
>> ==================
>> make[2]: Leaving directory `/tmp/check/check-0.9.12/tests'
>> make[1]: Leaving directory `/tmp/check/check-0.9.12/tests'
>>
>>
>> but there were some worrying error messages. Looking in tests/test.log it
>> also suggests problems. It finishes with:
>>
>>
>> Results for all suites run:
>> 37%: Checks: 8, Failures: 4, Errors: 1
>>
>>
>> I am using linux 64bit centos (red hat variant)
>> uname -a Linux 2.6.18-371.6.1.el5 #1 SMP Wed Mar 12 20:03:51 EDT 2014
>> x86_64 x86_64 x86_64 GNU/Linux
>>
>> Two questions if I may:
>> 1. Is this expected?
>> 2. How long should "make check" take.
>>
>>
>> Thank you very much
>>
>>
>> Bill
>>
>>
>> ps: let me know if you want more information.
>>
>>
>> Dr. W. B. Langdon,
>> Department of Computer Science
>> University College London
>> Gower Street, London WC1E 6BT, UK
>> http://www.cs.ucl.ac.uk/staff/W.Langdon/
>>
>>
>> GECCO 2014             http://www.sigevo.org/gecco-2014/
>> EuroGP 2014            http://www.evostar.org/cfpEuroGP.html
>> choose your background
>> http://web4.cs.ucl.ac.uk/staff/W.Langdon/colour_telephone/bgcolor.html
>> A Field Guide to Genetic Programming
>> http://www.gp-field-guide.org.uk/
>> GP EM                  http://www.springer.com/10710
>> GP Bibliography        http://www.cs.bham.ac.uk/~wbl/biblio/
>>
>>
>> -------------------------------------------------------------------------
>> -----
>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
>> unparalleled scalability from the best Selenium testing platform
>> available. Simple to use. Nothing to install. Get started now for free."
>> http://p.sf.net/sfu/SauceLabs
>> _______________________________________________
>> Check-devel mailing list
>> Che...@li...
>> https://lists.sourceforge.net/lists/listinfo/check-devel
>
>