Menu

#109 Duplicated usage of AC_USE_SYSTEM_EXTENSIONS

v1.0 (example)
closed-accepted
None
5
2015-08-02
2015-07-30
No

In configure.ac there are two uses of AC_USE_SYSTEM_EXTENSIONS:

[...]
# define things like _GNU_SOURCE appropriately
AC_USE_SYSTEM_EXTENSIONS

# really severe build strictness
AM_INIT_AUTOMAKE([-Wall gnits 1.11.2])
# Change to using into-in-builddir in the future:
#AM_INIT_AUTOMAKE([info-in-builddir -Wall -Werror gnits 1.14])

# From patch 2803433, request system extensions to generate 64-bit safe code
AC_USE_SYSTEM_EXTENSIONS
[...]

Either the first or the second one is redundant so one should be removed but beware, there's a bug introduced in automake 1.14 (fixed in 1.15) that would potentially cause trouble if you put it before AM_INIT_AUTOMAKE.

Thus, I'd probably leave the second one only, to be safer. More info about this automake bug here: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15981

Discussion

  • Branden Archer

    Branden Archer - 2015-08-02

    Thanks for the bug report and the patch. Your patch has been added to Check, and your name will appear in the AUTHORS file.

     
  • Branden Archer

    Branden Archer - 2015-08-02
    • status: open --> closed-accepted
    • assigned_to: Branden Archer
     

Log in to post a comment.