#16 cgnsutil.c:1747: bad loop ?

[dcb]

cgnslib_3.2.1/src/cgnstools/utilities/cgnsutil.c:1747:44: warning: iteration 2u invokes undefined behavior [-Waggressive-loop-optimizations]

       float exp[5];
        for (n = 0; n < 5; n++)
            exp[n] = (float)f->dataconv[n];

but

double dataconv[2];

[M.S. Breitenfeld]

Since the loop goes to 5 then it should be 5. But if I’m reading the code correctly, dataconv only gets filled for 2 elements (0:1). So the loop should probably only go to 2 and not 5. I don’t think there are any values set in dataconv(2:4), so exp will have junk in (2:4). (not verified)

BUT, are we sure it should be f->dataconv[n] and not f->exponent[n] ? I tend to think it should be f->exponent[n].