Re: [Cgi-session-user] Patch to CGI::Session V 4.13 for passing parameters to callbacks called from find()

[Ron S. <ro...@sa...>]

On Sat, 15 Apr 2006 08:22:54 -0400, Mark Stosberg wrote:

Hi Mark

> Overall, I like the idea. I appreciated the thorough documentation.

OK.

> 1. I think the arguments should be gathered as an arrayref and
> passed as an array, the standard, default way to pass arguments. If

What!? There is no such thing as a 'standard, default way to pass=
 arguments'.
Even CGI::Session usually uses hashrefs... See, for example:
=3Ditem find( $dsn, \&code, \%dsn_args )

However, it makes sense not to restrict other users of find(), so I've=
 changed 
the documentation to refer to a generic parameter, $coderef_args, rather=
 than an 
explicit hashref. See the attached patch.

> 2. I'd like some automated tests for this feature. I see there's
> already a start here:
> http://search.cpan.org/src/RSAVAGE/CGI-Session-ExpireSessions-
> 1.06/t/new-line.t

V 1.07 contains a new test, t/03-delete-via-find.t, which deals with this=
 issue.

Anyone interested can go to:

http://savage.net.au/Perl-modules.html

and get V 1.07. This versions assumes you've installed CGI::Session V 4.14=
 (i.e. 
the result of adding my patches).

I won't release v 1.07 to CPAN until after CGI::Session V 4.14 has been 
released.

-- 
Cheers
Ron Savage, ro...@sa... on 16/04/2006
http://savage.net.au/index.html
Let the record show: Microsoft is not an Australian company