Re: [Cgi-session-user] Patch to CGI::Session V 4.13 for passing parameters to callbacks called from find()

[Mark S. <ma...@su...>]

On Sat, Apr 15, 2006 at 12:44:48PM +1000, Ron Savage wrote:
> Hi Mark
> 
> See attached.

Thanks Ron.  Here's some feedback on it. 

Overall, I like the idea. I appreciated the thorough documentation.

A couple aspects seem worth refactoring or at least discussing. 

1. I think the arguments should be gathered as an arrayref and passed
   as an array, the standard, default way to pass arguments. If 
   you want to pass a hashref, it's still easy:

   $args = [\%my_href];

   This will give people a little more flexibility in designing their
   callbacks. 

2. I'd like some automated tests for this feature. I see there's already
   a start here:
   http://search.cpan.org/src/RSAVAGE/CGI-Session-ExpireSessions-1.06/t/new-line.t 

   You may have noticed our Quality Assurance process here created some
   sub-optimal releases lately. I'd like to err farther on the side of 
   assuring quality this time. :)

For anyone who wants to help with this, Ron's code is now available in
SVN, accessible like this: 

svn co svn://svn.cromedome.net/CGI-Session/trunk

Thanks,

	Mark