[Cgi-session-user] Help requested for release: Storable issues

[Mark S. <ma...@su...>]

Hello, 

I was just reviewing the cpan-testers report for CGI::Session, and they are
mostly test failures. This is sad, considering they are skipping the MySQL and
PostgreSQL tests in all cases, I think. 

The things that have been reported not to work include: 

- db_file    with Storable
- SQLite     with Storable 
- PostgreSQL with Storable

I'm fine with just TODO'ing the SQLite and PostgreSQL failures with Storable, since I don't think
those were tested to work with 3.x, and I don't personally care about them-- there are other good
seriarlizers to use. 

The db_file/Storable failure is more troubling, because we had a test
for that in 3.95, and cpan-testers reports no failures for it out of 58
tests. 

Could someone look into these Storable issues so we can get 4.0 released? I don't personally care
about that serializer, so am unlikely to get to it myself.

I believe part of the issue is that Storable is using a binary data
format. 

With SQLite, this means encoding and decoding needs to be done.
DBD::SQLite2 makes reference to such a feature, but at the expense of
possibly breaking other things. I would just assume document not to use
these two together. 

Likewise, I think PostgreSQL objects to storing binary data in a text
field. While a different data type could be used along with functions to
handle binaries, again I would rather say: "Don't do that", at least for now. 

Why db_file/storable is failing, I have no idea. 

    Mark


t/api3_db_file_storable.........Use of uninitialized value in subroutine entry at /opt/perl/testers/.cpanplus/5.8.7/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Driver/db_file.pm line 57.
Can't use string ("") as a subroutine ref while "strict refs" in use at /opt/perl/testers/.cpanplus/5.8.7/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Driver/db_file.pm line 57.
Use of uninitialized value in subroutine entry at /opt/perl/testers/.cpanplus/5.8.7/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Driver/db_file.pm line 57.
        (in cleanup) Can't use string ("") as a subroutine ref while "strict refs" in use at /opt/perl/testers/.cpanplus/5.8.7/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Driver/db_file.pm line 57.
# Looks like you planned 14 tests but only ran 9.





t/g4_sqlite.....................DBD::SQLite::db selectrow_array failed: no such table: sessions(1) at dbdimp.c line 268 at t/g4_sqlite.t line 26.
Use of uninitialized value in concatenation (.) or string at /net/sunu991/disc1/.cpanplus/5.8.5/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Test/Default.pm line 162.
ok
        6/79 skipped: Default serializer cannot serialize objects properly
t/g4_sqlite_freezethaw..........Use of uninitialized value in concatenation (.) or string at /net/sunu991/disc1/.cpanplus/5.8.5/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Test/Default.pm line 162.
ok
t/g4_sqlite_storable............
#     Failed test (/net/sunu991/disc1/.cpanplus/5.8.5/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Test/Default.pm at line 128)
#          got: 'load(): couldn't thaw() data using CGI::Session::Serialize::storable :'
#     expected: ''

#     Failed test (/net/sunu991/disc1/.cpanplus/5.8.5/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Test/Default.pm at line 129)
Can't call method "is_expired" on an undefined value at /net/sunu991/disc1/.cpanplus/5.8.5/build/CGI-Session-4.00_09/blib/lib/CGI/Session/Test/Default.pm line 130.
# Looks like you planned 79 tests but only ran 24.
# Looks like your test died just after 24.
dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 23-79

-- 
http://mark.stosberg.com/