Re: [Cgdb-devel] Patch: Vertical split mode
Brought to you by:
bobbybrasko,
crouchingturbo
From: David W. <dwh...@gm...> - 2009-01-20 13:32:13
|
> I've tested your patch with the feature I've longed for, and I loved > it! Thanks for your efforts! Wide screen monitors are very common > nowadays, and vertically split windows make very efficient use of > screen spaces. Thanks for trying it. I'm glad it works for you! > A small bug I've found: when in vertical split mode, '_'/'+' > decreases/increaes the width of the window by 25% of the height rather > than 25% of the width. Good catch. I'll clean that up. I'm sure there are probably a few more nits lurking in there somewhere. > As a related note, I think that 25% of the width might be too large a > decrement/increment when one has a very wide terminal window. For > example, the size of my full-screen terminal window is 76 lines by 237 > columns, so 1/4 of the width is almost 60 columns -- too large when it > comes to adjusting the width of the window using '_'/'+'. I suppose > this problem might be solved by setting the interval to a small value > (e.g. 1/6 or 1/8 of the width/height) when the width/height exceeds a > certain value (e.g. 120). I think you're right about the 25%. Maybe a percentage jump just doesn't make sense for vertical split adjustments. Perhaps a fixed adjustment amount would be more sensible? |