|
From: Bob R. <bob...@co...> - 2007-08-24 00:54:07
|
On Thu, Aug 23, 2007 at 11:55:37PM +0300, Gilboa Davara wrote: > OK, more luck then brains on my part. > While redoing the patch I found a nice way to reduce the layering breakage. > This once should apply nicely against the current trunk. Hi Gilboa, I've looked over this patch. I'm not entirely sure what you are trying to accomplish, maybe you could shed some light for me. For instance, what is the reason to not use the source_vscroll function to move a page up or down? BTW, I think it's possible to ask the source window how big it is. That would be a more clever way of getting the height than calling the get_src_height() function. Also, why pass the sview object to all of the configuration commands? It's always possible to simply call if_get_sview () if it's necessary. Thanks, Bob Rossi |
