|
From: Bob R. <bob...@co...> - 2006-10-06 00:31:37
|
On Thu, Oct 05, 2006 at 06:34:00PM +0200, Haakon Riiser wrote: > [Bob Rossi] > > >> As for my enhancement, I was wondering if you'd consider making > >> it an option to highlight the entire current line when scrolling > >> around in the source window. The current behavior is to make > >> the current line number bold, but I find it much easier to > >> identify the current line when the highlighting extends all > >> the way across the screen. > > > This seems like a reasonable idea. I'm wondering how this is best > > implemented though. Currently, CGDB only highlights the line number. > > This patch would have it highlight the entire line. How would the user > > switch back and forth between this functionality? > > I was thinking a new option. More on this below. OK, I can agree with this. > > I applied your patch, and noticed that when breakpoints are set, and you > > go over them, the current line is no longer highlighted. > > Yes, don't you agree that's a feature? :-) I agree that some people could like this. I don't like it much, and so probably wouldn't apply it upstream as it is, but I think we can come up with something that we both like. > > I don't have time to look into these but if you want to think > > about how this option could nicely fit into CGDB from a users > > perspective, that would be useful. > > I'm not sure what you mean. As I said above, I thought about adding > a new highlighting group for the current line (the on that is now > hardcoded to boldfaced text), and an option to let it extend across > the entire line. > > By the way, here's my latest version of the patch. The only change > is the one I described above (fixing the segfault by letting the > normal highlighting overlay the current line highlighting). I misunderstood the problem that you are having. Are you saying that highlighting the line numbers with certain information isn't useful at all times because you are scrolling to the right to the point where the line numbers aren't even on the screen? Just to get an idea of what you would find useful, I have a few questions below. Would it be useful for CGDB to highlight lines with breakpoints by highlighting the entire line red or yellow (based on breakpoint enabled or disabled) instead of just the line number? Would it be useful for CGDB to highlight the current line the user is browsing by highlighting the entire line instead of just the line number? Thanks, Bob Rossi |
