|
From: Bob R. <bob...@co...> - 2006-10-03 20:21:27
|
On Tue, Oct 03, 2006 at 12:06:42PM +0200, Haakon Riiser wrote: > First of all, I'd like to thank you guys for making CGDB: Finally > I have a good debugger with a source view and syntax highlighting > without a bloated and buggy GUI interface! :-) Thanks. > Moving onward, I have one small bug report and a suggested > enhancement (patch included). > > > First the bug: When doing 'make install DESTDIR=/foo', the > installer also creates the directory /foo.. and copies > gdbmi_driver into /foo../progs/. Looking at the makefiles in > lib/gdbmi/src/, I see that the problem comes from This should be fixed in SVN now. Thanks for the report. > As for my enhancement, I was wondering if you'd consider making > it an option to highlight the entire current line when scrolling > around in the source window. The current behavior is to make the > current line number bold, but I find it much easier to identify the > current line when the highlighting extends all the way across the > screen. > > I've included a patch below that implements this feature. Currently, > it just replaces the old behavior, since that's all I need for my own > personal use. If you'd like to push this upstream, but not in its > current state, let me know -- I'll gladly make the required changes. This seems like a reasonable idea. I'm wondering how this is best implemented though. Currently, CGDB only highlights the line number. This patch would have it highlight the entire line. How would the user switch back and forth between this functionality? I applied your patch, and noticed that when breakpoints are set, and you go over them, the current line is no longer highlighted. I also noticed that if I do a search, cgdb segfaults. I don't have time to look into these but if you want to think about how this option could nicely fit into CGDB from a users perspective, that would be useful. Mike, any opinions? Thanks, Bob Rossi |
