cgdb-devel

[Cgdb-devel] Weird behavior during file-dialog regex search?

[Gilboa D. <gi...@gm...>]

Hello,

I'm trying to solve a bug in Fedora version of CGDB (which I maintain).
When doing a regular expression search inside the file selection dialog,
pressing enter does not select the file, instead, it simply jumps to the
next match.
The only way to select the first matching file is to press Enter twice.

By looking at the code (capture_regex in filedlg.c) it seems that
pressing Enter triggers a search for the next match, instead of simply
selecting the last highlight.
Given the fact that cgdb is doing regex-as-you-type search, shouldn't
cgdb assume that once I press enter, as-you-type search already
highlighted the last match?

Thanks,
- Gilboa

Re: [Cgdb-devel] Weird behavior during file-dialog regex search?

[Bob R. <bo...@br...>]

On Thu, Oct 28, 2010 at 10:05:15AM +0200, Gilboa Davara wrote:
> Hello,
> 
> I'm trying to solve a bug in Fedora version of CGDB (which I maintain).
> When doing a regular expression search inside the file selection dialog,
> pressing enter does not select the file, instead, it simply jumps to the
> next match.
> The only way to select the first matching file is to press Enter twice.
> 
> By looking at the code (capture_regex in filedlg.c) it seems that
> pressing Enter triggers a search for the next match, instead of simply
> selecting the last highlight.
> Given the fact that cgdb is doing regex-as-you-type search, shouldn't
> cgdb assume that once I press enter, as-you-type search already
> highlighted the last match?

OK, that is a really annoying bug, I don't know how I haven't seen
this before. Thanks.

I'll have to figure out how to fix this for the next release.

Bob

Re: [Cgdb-devel] Weird behavior during file-dialog regex search?

[Gilboa D. <gi...@gm...>]

On Wed, 2010-11-10 at 21:54 -0500, Bob Rossi wrote:
> On Thu, Oct 28, 2010 at 10:05:15AM +0200, Gilboa Davara wrote:
> > Hello,
> > 
> > I'm trying to solve a bug in Fedora version of CGDB (which I maintain).
> > When doing a regular expression search inside the file selection dialog,
> > pressing enter does not select the file, instead, it simply jumps to the
> > next match.
> > The only way to select the first matching file is to press Enter twice.
> > 
> > By looking at the code (capture_regex in filedlg.c) it seems that
> > pressing Enter triggers a search for the next match, instead of simply
> > selecting the last highlight.
> > Given the fact that cgdb is doing regex-as-you-type search, shouldn't
> > cgdb assume that once I press enter, as-you-type search already
> > highlighted the last match?
> 
> OK, that is a really annoying bug, I don't know how I haven't seen
> this before. Thanks.
> 
> I'll have to figure out how to fix this for the next release.

Happy to help.
If you could drop me a fix (or even point me at the right direction)
I'll push an update for Fedora 12/13/14 and RHEL5.

> 
> Bob

- Gilboa
P.S. Did you have a change to look at the focus patch?

Re: [Cgdb-devel] Weird behavior during file-dialog regex search?

[Gilboa D. <gi...@gm...>]

On Thu, 2011-01-27 at 12:44 -0500, Bob Rossi wrote:
> On Thu, Nov 11, 2010 at 02:00:53PM +0200, Gilboa Davara wrote:
> > On Wed, 2010-11-10 at 21:54 -0500, Bob Rossi wrote:
> > > On Thu, Oct 28, 2010 at 10:05:15AM +0200, Gilboa Davara wrote:
> > > > Hello,
> > > > 
> > > > I'm trying to solve a bug in Fedora version of CGDB (which I maintain).
> > > > When doing a regular expression search inside the file selection dialog,
> > > > pressing enter does not select the file, instead, it simply jumps to the
> > > > next match.
> > > > The only way to select the first matching file is to press Enter twice.
> > > > 
> > > > By looking at the code (capture_regex in filedlg.c) it seems that
> > > > pressing Enter triggers a search for the next match, instead of simply
> > > > selecting the last highlight.
> > > > Given the fact that cgdb is doing regex-as-you-type search, shouldn't
> > > > cgdb assume that once I press enter, as-you-type search already
> > > > highlighted the last match?
> > > 
> > > OK, that is a really annoying bug, I don't know how I haven't seen
> > > this before. Thanks.
> > > 
> > > I'll have to figure out how to fix this for the next release.
> > 
> > Happy to help.
> > If you could drop me a fix (or even point me at the right direction)
> > I'll push an update for Fedora 12/13/14 and RHEL5.
> 
> This was fixed in git last night. Give it a try if you'd like to see
> if it works for you. We'll try to get out a bug fix release soon.
> 
> Bob

Thanks!

I'll free some time next week to test it.

- Gilboa

Re: [Cgdb-devel] Weird behavior during file-dialog regex search?

[Gilboa D. <gi...@gm...>]

On Thu, 2011-01-27 at 12:44 -0500, Bob Rossi wrote:

> This was fixed in git last night. Give it a try if you'd like to see
> if it works for you. We'll try to get out a bug fix release soon.
> 
> Bob

Hello,

Sorry for the late reply (We had an urgent demo and was far too busy to
do anything useful besides work..)

Can you point me to the commit? If you have no objections, want to
back-port it to 0.6.5 so I can test it and push into Fedora/RHE-stable.

- Gilboa