#12 cewolf/testpage.jsp IMG

cewolf-0.8
closed-rejected
nobody
TagLibrary (33)
5
2002-11-29
2002-11-29
No

Hello!

I am not a custom tag guru, because sorry for possible
mistakes of mine.

If you look at the generated HTML source of the
cewolf/testpage.jsp, you will see the following:

<TD valign="top">
<!-- image panel -->
<IMG BORDER="0" HEIGHT="300" WIDTH="300"
ALT="" src="cewolf?
img=1&width=300&height=300&iehack=.png"
<!-- end image panel -->
</TD>

The IMG TAG IS BROKEN: it has not a closing '>' or '/>'
sign. I looked at the sources of
de.laures.cewolf.taglib.html.AbstractHTMLBaseTag.java
and saw the following code:

public int doStartTag() throws JspException {
JspWriter writer = pageContext.getOut();
try {
writer.write("<" + getTagName());
writeAttributes(writer);
if(hasBody()){
writer.write(">");
return EVAL_PAGE;
} else {
return SKIP_BODY;
}
} catch(IOException ioe){
throw new JspException(ioe.getMessage());
}
}

The 'else' branch does not have a writer.write(">"); line of
code. I think that may be it is 'the root of the evil' :), but
as I said I know nothing about custom tags.

Thanks,
Leonid Shlyapnikov shl@vlinkmail.com

Discussion

  • Guido Laures

    Guido Laures - 2002-11-29
    • status: open --> closed-rejected
     
  • Guido Laures

    Guido Laures - 2002-11-29

    Logged In: YES
    user_id=574032

    When you take a closer look at the generated img tags you
    will see that they are closed in a new line. This is not
    very nice but should not matter.
    In source code you find the closing of the tag in the
    doEndTag() method.

     
  • Anonymous

    Anonymous - 2002-11-29

    Logged In: YES
    user_id=658971

    But I don't see any closing '>' sign in a new line. Look at my
    previos message, there is a HTML code fragment there.

    <IMG BORDER="0" HEIGHT="300" WIDTH="300" ALT=""
    src="cewolf?img=1&width=300&height=300&iehack=.png"
    <!-- end image panel -->
    </TD>

    I am learning downloaded example web-app cewolf-war-0.8.5
    (cewolf.war), but maybe ther is not this bug in the cewolf-
    0.8.7 library.

     
  • Anonymous

    Anonymous - 2002-11-29

    Logged In: YES
    user_id=658971

    But I don't see any closing '>' sign in a new line. Look at my
    previos message, there is a HTML code fragment there.

    <IMG BORDER="0" HEIGHT="300" WIDTH="300" ALT=""
    src="cewolf?img=1&width=300&height=300&iehack=.png"
    <!-- end image panel -->
    </TD>

    I am learning downloaded example web-app cewolf-war-0.8.5
    (cewolf.war), but maybe ther is not this bug in the cewolf-
    0.8.7 library.

     
  • Anonymous

    Anonymous - 2002-11-29

    Logged In: YES
    user_id=658971

    But I don't see any closing '>' sign in a new line. Look at my
    previos message, there is a HTML code fragment there.

    I am learning downloaded example web-app cewolf-war-0.8.5
    (cewolf.war), but maybe ther is not this bug in the cewolf-
    0.8.7 library.

     

Log in to post a comment.