Re: [Celestia-developers] PATCH - valgrind errors, out-of-source build, gcc warnings

[Andrew Tribick <ajtribick@go...>]

Ok

I've committed the code changes. I've left out the gtk branch changes
because the plan is to unify the interface to the qt version, and I've
left out the automake changes until someone with more experience with
autotools can review this.

Hopefully this all still works for everyone...

Regards,
Andrew

On 26 April 2012 02:42, Daniel K. O. <danielko.listas@...> wrote:
> All of my changes were platform-neutral, except for the bootstrap
> script. I know the libtoolize found on OSX is named glibtoolize, but I
> heard that it's old enough to cause problems to the point it's easier to
> just download a newer version and install - getting the libtoolize
> executable.
>
> If there's anyone maintaining Celestia on Mac, and prefers glibtoolize,
> it might be better to change the first command in bootstrap to:
>
> libtoolize || glibtoolize
>
>
>
> On 04/25/2012 01:05 PM, Andrew Tribick wrote:
>> Thanks for this patch. It appears to work on Windows as well - has
>> anyone else tested (particularly Mac, which I have no access to)?
>>
>> For the case of the #ifdef TEST in nutation.cpp (and similar sections
>> in precession.cpp and modelfile.cpp) it may be worth just removing
>> these sections, they appear to be no longer required.
>>
>> Regards,
>> Andrew
>
>
> --
> Daniel K. O.

[Celestia-developers] PATCH - valgrind errors, out-of-source build, gcc warnings

[Daniel K. O. <danielko.listas@gm...>]

Hello.

Here is a patch against rev 5202 to address a couple of things:

* Fix in build scripts
-- tell configure.in to use the macros dir, consistent with Makefile.am
-- tell automake what options automake needs in Makefile.am
-- add a boostrap script to generate the autotools files
-- gconftool has to reference files in srcdir
* Fix gcc warnings:
-- #if FOO tests instead of #ifdef FOO
-- unused function parameter name
-- static variable in gtk/dialog-time.h instead of gtk/dialog-time.cpp
* Fix memory errors reported by Valgrind:
-- uninitialized member in FrameTree
-- memory read after dealocation in ReferenceFrame
-- unmatched new[]/delete[] in StarDatabase
-- uninitialized temperature in StarDatabase
-- uninitialized member of RenderListEntry: isOpaque
* Fix convoluted code in renderer
-- gluProject is called with a weird viewport, only to be canceled out
later by a glTranslate



Not included, but would be a good idea to address too:
* change autoconf prereq to 2.68; it's almost 2 years old now; currently
the prereq is 2.57, which is a decade old.
* gettext seems to want to update all the .po files during the build, it
appears to be updating them to include "Language" entries.
* more consistent indentation with no TABS.


-- 
Daniel K. O.

Re: [Celestia-developers] PATCH - valgrind errors, out-of-source build, gcc warnings

[Andrew Tribick <ajtribick@go...>]

Thanks for this patch. It appears to work on Windows as well - has
anyone else tested (particularly Mac, which I have no access to)?

For the case of the #ifdef TEST in nutation.cpp (and similar sections
in precession.cpp and modelfile.cpp) it may be worth just removing
these sections, they appear to be no longer required.

Regards,
Andrew

On 6 April 2012 20:37, Daniel K. O. <danielko.listas@...> wrote:
> Hello.
>
> Here is a patch against rev 5202 to address a couple of things:
>
> * Fix in build scripts
> -- tell configure.in to use the macros dir, consistent with Makefile.am
> -- tell automake what options automake needs in Makefile.am
> -- add a boostrap script to generate the autotools files
> -- gconftool has to reference files in srcdir
> * Fix gcc warnings:
> -- #if FOO tests instead of #ifdef FOO
> -- unused function parameter name
> -- static variable in gtk/dialog-time.h instead of gtk/dialog-time.cpp
> * Fix memory errors reported by Valgrind:
> -- uninitialized member in FrameTree
> -- memory read after dealocation in ReferenceFrame
> -- unmatched new[]/delete[] in StarDatabase
> -- uninitialized temperature in StarDatabase
> -- uninitialized member of RenderListEntry: isOpaque
> * Fix convoluted code in renderer
> -- gluProject is called with a weird viewport, only to be canceled out
> later by a glTranslate
>
>
>
> Not included, but would be a good idea to address too:
> * change autoconf prereq to 2.68; it's almost 2 years old now; currently
> the prereq is 2.57, which is a decade old.
> * gettext seems to want to update all the .po files during the build, it
> appears to be updating them to include "Language" entries.
> * more consistent indentation with no TABS.
>
>
> --
> Daniel K. O.
>
> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2
> _______________________________________________
> Celestia-developers mailing list
> Celestia-developers@...
> https://lists.sourceforge.net/lists/listinfo/celestia-developers
>

Re: [Celestia-developers] PATCH - valgrind errors, out-of-source build, gcc warnings

[Andrew Tribick <ajtribick@go...>]

Ok

I've committed the code changes. I've left out the gtk branch changes
because the plan is to unify the interface to the qt version, and I've
left out the automake changes until someone with more experience with
autotools can review this.

Hopefully this all still works for everyone...

Regards,
Andrew

On 26 April 2012 02:42, Daniel K. O. <danielko.listas@...> wrote:
> All of my changes were platform-neutral, except for the bootstrap
> script. I know the libtoolize found on OSX is named glibtoolize, but I
> heard that it's old enough to cause problems to the point it's easier to
> just download a newer version and install - getting the libtoolize
> executable.
>
> If there's anyone maintaining Celestia on Mac, and prefers glibtoolize,
> it might be better to change the first command in bootstrap to:
>
> libtoolize || glibtoolize
>
>
>
> On 04/25/2012 01:05 PM, Andrew Tribick wrote:
>> Thanks for this patch. It appears to work on Windows as well - has
>> anyone else tested (particularly Mac, which I have no access to)?
>>
>> For the case of the #ifdef TEST in nutation.cpp (and similar sections
>> in precession.cpp and modelfile.cpp) it may be worth just removing
>> these sections, they appear to be no longer required.
>>
>> Regards,
>> Andrew
>
>
> --
> Daniel K. O.