Re: [Celestia-developers] The liblua*.so mess, ADDENDUM
Real-time 3D visualization of space
Status: Beta
Brought to you by:
cjlaurel
From: Fridger S. <fri...@de...> - 2012-03-30 20:11:35
|
Pat, On 03/30/2012 09:10 PM, Pat Suwalski wrote: > On 30/03/12 02:39 PM, Fridger Schrempp wrote: >> While you a presumably dreaming of pkgconfig at night ;-) (given your >> Linux history...), I can assure you that in KDE4 based desktops >> pkgconfig does NOT play a significant role at all! Hence a significant >> number of Linux users will not even have pkgconfig installed and errors >> would be thrown at them after starting qmake. My version is more >> elementary i.e. it does not invoke any auxiliary programs whatsoever. >> Many KDE4 users might never have heard what *.pc files are etc. > I respectfully disagree. You can't even build KDE4 without pkgconfig. > Also, it's in every distro's repository. Qt actually ships with .pc files. Most users don't build KDE4. However, it is indeed true that the lua-devel archive and the Qt distro of openSuSE 11.x also contain .pc files. > Anyhow, it is functionality that qmake supports natively > (CONFIG+=link_pkgconfig), so I think it's acceptable to use it. It is certainly acceptable to use pkgconfig, but I still doubt that the specific code is superior. Let's wait for further explicit tests by our friends. >> My syntax using directly the various occuring liblua names is >> selfexplanatory without being inferior in performance. > Incorrect. It is very inferior in performance. Here is the explicit check, using > time qmake -config release ../src/celestia.pro RESULT: ;-) your code: ============ real 0m0.574s user 0m0.433s sys 0m0.134s my code: =========== real 0m0.566s user 0m0.435s sys 0m0.126s So do you still think my code (with my liblua notation being placed last in the loop!) is "very inferior in performance" > > You missed the part that my code adds the INCLUDE path and actually > works. Yours will not build for most users of Linux, because the > libraries aren't in /usr/lib and the includes aren't in /usr/include. I refuse Linux distros that don't use the UNIX standard /usr/lib and /usr/include for their repository stuff that generally includes liblua ;-) Of course, I can easily fix the include issue in my code. Fridger |