I took a look at that patch, and the first line you changed doesn't seem right: it's *decoding* the string--shouldn't it be encoding it to store. Unless perhaps it's being encoded by Qt or KDE later?

I'm going to check in one more small Mac change on Sunday. I might also take a look at the Mac full screen issue one more time before punting it to the next Celestia version (it doesn't seem to happen in QtCelestia anyhow.) After that, I'm ready to build a release. Although the bookmarks/favorites on Windows isn't affected by the URL change, copying of URLs is; we should rebuild the Windows release. I've replaced the motherboard in my Windows 7 system and resurrected it, so I can do this Sunday or Monday if someone else doesn't get to it first.

--Chris

On Fri, Feb 4, 2011 at 12:56 PM, Andrew Tribick <ajtribick@googlemail.com> wrote:
Ok so it turns out the edit bookmarks functionality was caused by me
not having Konqueror installed. So no worries there.

As for the KDE bookmarks problem, I've attached a patch for
kcelbookmarkmenu.cpp that fixes the Unicode bookmarks functionality.
Please check this as this is essentially my first foray into KDE
programming!

Andrew

On 2 February 2011 21:53, Andrew Tribick <ajtribick@googlemail.com> wrote:
> Chris,
>
> Yes this is for new bookmarks. Using Gärtner as an example, I select
> it and use G to go to it, then choose "Add Bookmark" from the
> Bookmarks menu. This gives me an entry "Follow G%c3%a4rtner
> [G%c3%a4rtner]" in the menu. The cel URL output to the console while
> doing this works fine in the Navigation/Go to URL. Selecting the menu
> item in the bookmarks menu however selects Gärtner but deposits me at
> the coordinate origin.
>
> The lack of the Edit Bookmarks functionality is a separate issue.
>
> Andrew
>
> On 2 February 2011 21:26, Chris Laurel <claurel@gmail.com> wrote:
>> Vincent and Andrew--thanks for testing the patch.
>> Regarding bookmarks: are you having problems with existing bookmarks with
>> non-ASCII characters? The patch won't fix these, as they've already been
>> stored with the broken encoding. New bookmarks should work though, unless
>> there's another bug. The fix on the Mac is actually two parts: the patch you
>> tested, plus another patch that prevents existing, incorrectly encoded names
>> from crashing Celestia.
>> --Chris
>> On Wed, Feb 2, 2011 at 11:58 AM, Andrew Tribick <ajtribick@googlemail.com>
>> wrote:
>>>
>>> Chris,
>>>
>>> I confirm the bug exists in the Gnome and KDE versions also. The patch
>>> fixes the issue with cel URLs for these but the KDE bookmarks menu
>>> still does not work correctly. In addition the "Edit bookmarks"
>>> function in the KDE version appears to do nothing - I cannot edit my
>>> bookmarks without messing around in ~/.kde/apps/celestia
>>>
>>> Andrew
>>>
>>> On 2 February 2011 08:34, vincent <vince.gian@free.fr> wrote:
>>> > Chris,
>>> >
>>> > I could reproduce the bug on the qt4 version.
>>> > And your patch definitely fixed it :-)
>>> >
>>> > Vincent
>>> >
>>> >
>>> > Selon Chris Laurel <claurel@gmail.com>:
>>> >
>>> >> I think that I've found the problem: some code in url.cpp that's not
>>> >> correctly dealing with the fact that the char type may be signed. I've
>>> >> attached a small patch. This fixes the problem with favorites on the
>>> >> Mac as
>>> >> well as a related issue with copying URLs.
>>> >>
>>> >> The Win32 version doesn't use cel URLs for favorites; it uses a custom
>>> >> format for favorites that is left over from the very early days of
>>> >> Celestia
>>> >> (all other versions use cel URLs.)
>>> >>
>>> >> --chris
>>> >>
>>> >> On Tue, Feb 1, 2011 at 2:26 PM, Andrew Tribick
>>> >> <ajtribick@googlemail.com>wrote:
>>> >>
>>> >> > As far as I can tell this does not affect the Windows version. Right
>>> >> > now I don't have time to try the Linux builds of 1.6.1, but qt trunk
>>> >> > also exhibits a problem where a bookmark on Gärtner results in
>>> >> > travelling to the coordinate system origin, though ASCII bookmarks
>>> >> > seem to work.
>>> >> >
>>> >> > Andrew
>>> >> >
>>> >> > On 1 February 2011 23:03, Chris Laurel <claurel@gmail.com> wrote:
>>> >> > > Martin has reported a crash on the Mac version when loading a
>>> >> > > favorite
>>> >> > that
>>> >> > > contains a non-ASCII character. I have a workaround for the crash,
>>> >> > > but it
>>> >> > > doesn't fully address the bug. Somewhere in the process of reading
>>> >> > > or
>>> >> > > writing a favorite, the encoding is getting completely messed up.
>>> >> > > For
>>> >> > > example, the name of the lunar crater Gärtner becomes
>>> >> > > "G\377ffffc3\377ffffa4rtner", where the highlighted \377 actually
>>> >> > represents
>>> >> > > the value 255 and every other character is literally what appears
>>> >> > > in the
>>> >> > > decoded string. This is not a valid UTF-8 string, so the call to
>>> >> > > the
>>> >> > MacOS
>>> >> > > function to decode the string fails. What should be there in place
>>> >> > > of the
>>> >> > > whole \377ffffc3\377ffffa4 mess are just the two bytes 0xc3 and
>>> >> > > 0xa4.
>>> >> > > --Chris
>>> >> > >
>>> >> > > On Fri, Jan 28, 2011 at 5:47 PM, Pat Suwalski <pat@suwalski.net>
>>> >> > > wrote:
>>> >> > >>
>>> >> > >> Seems to run fine on my Mac.
>>> >> > >>
>>> >> > >> --Pat
>>> >> > >>
>>> >> > >> On Jan 28, 2011, at 18:45, Chris Laurel wrote:
>>> >> > >>
>>> >> > >> > I just took care of the Mac versioning problem and committed the
>>> >> > change.
>>> >> > >> > I also fixed the stream of compiler warnings about the
>>> >> > >> > redefinition of
>>> >> > >> > UINT64_MAX; this fix is already in trunk.
>>> >> > >> >
>>> >> > >> > I'm in the process of uploading a disk image for the Mac version
>>> >> > >> > of
>>> >> > >> > Celestia 1.6.1. By the time you read this message, it will be
>>> >> > >> > here:
>>> >> > >> >
>>> >> > >> >
>>> >> >
>>> >> > http://www.shatters.net/~claurel/celestia/files/celestia-osx-1.6.1.dmg
>>> >> > >> >
>>> >> > >> > I changed the compression on this disk image so that it's
>>> >> > >> > smaller than
>>> >> > >> > 1.6.0.
>>> >> > >> >
>>> >> > >> > I'm still unable to build a Windows version because of ongoing
>>> >> > problems
>>> >> > >> > with my Windows system.
>>> >> > >> >
>>> >> > >> > --Chris
>>> >> > >> >
>>> >> > >> > On Tue, Jan 25, 2011 at 9:28 AM, Pat Suwalski <pat@suwalski.net>
>>> >> > wrote:
>>> >> > >> > On 24/01/11 12:45 PM, Chris Laurel wrote:
>>> >> > >> > > Yes, this fix should be committed. The original code in vecgl
>>> >> > >> > > is not
>>> >> > >> > > correct: it shouldn't be taking the address of a temporary,
>>> >> > >> > > and I'm
>>> >> > >> > > quite surprised other compilers haven't complained about this
>>> >> > problem.
>>> >> > >> >
>>> >> > >> > Alright, the committed change is part of the updated tarball,
>>> >> > >> > at:
>>> >> > >> >
>>> >> > >> >   http://pat.suwalski.net/celestia-1.6.1.tar.gz
>>> >> > >> >
>>> >> > >> > The only outstanding issue I know of is the MacOS versioning.
>>> >> > >> >
>>> >> > >> > --Pat
>>> >> > >> >
>>> >> > >> >
>>> >> > >> >
>>> >> >
>>> >>
>>> >> ------------------------------------------------------------------------------
>>> >> > >> > Special Offer-- Download ArcSight Logger for FREE (a $49 USD
>>> >> > >> > value)!
>>> >> > >> > Finally, a world-class log management solution at an even better
>>> >> > >> > price-free!
>>> >> > >> > Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>>> >> > >> > February 28th, so secure your free ArcSight Logger TODAY!
>>> >> > >> > http://p.sf.net/sfu/arcsight-sfd2d
>>> >> > >> > _______________________________________________
>>> >> > >> > Celestia-developers mailing list
>>> >> > >> > Celestia-developers@lists.sourceforge.net
>>> >> > >> > https://lists.sourceforge.net/lists/listinfo/celestia-developers
>>> >> > >> >
>>> >> > >>
>>> >> > >
>>> >> > >
>>> >> > >
>>> >> >
>>> >>
>>> >> ------------------------------------------------------------------------------
>>> >> > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD
>>> >> > > value)!
>>> >> > > Finally, a world-class log management solution at an even better
>>> >> > price-free!
>>> >> > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>>> >> > > February 28th, so secure your free ArcSight Logger TODAY!
>>> >> > > http://p.sf.net/sfu/arcsight-sfd2d
>>> >> > > _______________________________________________
>>> >> > > Celestia-developers mailing list
>>> >> > > Celestia-developers@lists.sourceforge.net
>>> >> > > https://lists.sourceforge.net/lists/listinfo/celestia-developers
>>> >> > >
>>> >> > >
>>> >> >
>>> >> >
>>> >> >
>>> >>
>>> >> ------------------------------------------------------------------------------
>>> >> > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>>> >> > Finally, a world-class log management solution at an even better
>>> >> > price-free!
>>> >> > Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>>> >> > February 28th, so secure your free ArcSight Logger TODAY!
>>> >> > http://p.sf.net/sfu/arcsight-sfd2d
>>> >> > _______________________________________________
>>> >> > Celestia-developers mailing list
>>> >> > Celestia-developers@lists.sourceforge.net
>>> >> > https://lists.sourceforge.net/lists/listinfo/celestia-developers
>>> >> >
>>> >>
>>> >
>>> >
>>> >
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>>> Finally, a world-class log management solution at an even better
>>> price-free!
>>> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>>> February 28th, so secure your free ArcSight Logger TODAY!
>>> http://p.sf.net/sfu/arcsight-sfd2d
>>> _______________________________________________
>>> Celestia-developers mailing list
>>> Celestia-developers@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/celestia-developers
>>
>>
>

------------------------------------------------------------------------------
The modern datacenter depends on network connectivity to access resources
and provide services. The best practices for maximizing a physical server's
connectivity to a physical network are well understood - see how these
rules translate into the virtual world?
http://p.sf.net/sfu/oracle-sfdevnlfb
_______________________________________________
Celestia-developers mailing list
Celestia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/celestia-developers