#247 celestia vs. png-1.4.2 and png-1.5

v1.6
closed-fixed
nobody
5
2012-05-22
2010-06-20
No

celestia-1.6.0 doesn't compile against png-1.4.2.
It uses the png_set_gray_1_2_4_to_8() function that was deprecated in
png-1.0.18 (2004) and png-1.2.9 (2006) and removed in png-1.4.0. The
official porting instructions at http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt
recommend replacing it with png_set_expand_gray_1_2_4_to_8().

A possible patch is attached.

Discussion

  • Thomas Klausner

    Thomas Klausner - 2010-06-20

    patch fixing the problem

     
  • Thomas Klausner

    Thomas Klausner - 2011-01-30

    Patch fixing the problem with png-1.5.

     
  • Thomas Klausner

    Thomas Klausner - 2011-01-30

    With png-1.5, the zlib.h header isn't included automatically any longer. Since a symbol from there (Z_BEST_COMPRESSION) is used, compilation breaks. The second attachment fixes this problem.

     
  • Thomas Klausner

    Thomas Klausner - 2011-01-30
    • summary: celestia vs. png-1.4.2 --> celestia vs. png-1.4.2 and png-1.5
     
  • ajtribick

    ajtribick - 2012-05-22
    • status: open --> closed-fixed
     
  • ajtribick

    ajtribick - 2012-05-22

    These fixes are incorporated into the current trunk. Closing.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks