[CEDET-devel] Suspect byte-compiler warning on eieie.el

[David P. <dav...@wa...>]

Eric,

When I byte-compiled your latest CVS version of eieio.el, I got this
warning:

eieio.el:1697:8:Warning: `<' called for effect

On the following function:

(defun eieiomt-get (method-name key class)
   "Get the implementation for METHOD-NAME for int KEY matching CLASS.
See `eieiomt-add' for details on how these are set."
   (if (>= key method-num-fields) (< key 0)
     (error "eieiomt-get: method key error!"))
   (let ((emto (get method-name 'eieio-method-obarray)))
     (if (not emto)
	nil
       (intern-soft (symbol-name class) (aref emto key)))))

May be the first `if' statement should be:

   (if (or (>= key method-num-fields) (< key 0))
     (error "eieiomt-get: method key error!"))

What do you think?

David