Thread: [CEDET-devel] semantic-complete-self-insert not working
Brought to you by:
zappo
From: Andrzej P. <pro...@cs...> - 2012-01-29 10:30:43
|
Hi, I have recently switched to newtrunk which solved most of my previous problems with CEDET. I experience one problem though. semantic-complete-self-insert when bound to "." works properly for a super simple case when the class is defined in the same file. However, in more complex code, when "." is pressed emacs thinks for a while and then no suggestions are shown. How can I debug this case? Cheers, Andrzej |
From: Andrzej P. <pro...@cs...> - 2012-01-29 10:30:49
|
Forgot to say that when I add a single letter after the "." and then use semantic-complete-analyze-inline e.g. Type a; a.m<M-x semantic-complete-analyze-inline> The suggestions are shown properly. Andrzej On Sun, Jan 29, 2012 at 10:59 AM, Andrzej Pronobis <pro...@cs...> wrote: > Hi, > > I have recently switched to newtrunk which solved most of my previous > problems with CEDET. I experience one problem though. > semantic-complete-self-insert when bound to "." works properly for a > super simple case when the class is defined in the same file. However, > in more complex code, when "." is pressed emacs thinks for a while and > then no suggestions are shown. How can I debug this case? > > Cheers, > Andrzej |
From: Andrzej P. <a.p...@gm...> - 2012-01-29 14:22:16
|
Hi, I have recently switched to newtrunk which solved most of my previous problems with CEDET. I experience one problem though. semantic-complete-self-insert when bound to "." works properly for a super simple case when the class is defined in the same file. However, in more complex code, when "." is pressed emacs thinks for a while and then no suggestions are shown. When I add a single letter after the "." and then use semantic-complete-analyze-inline e.g. Type a; a.m<M-x semantic-complete-analyze-inline> The suggestions are shown properly. How can I debug this case? Cheers, Andrzej |
From: Andrzej P. <a.p...@gm...> - 2012-01-30 23:02:10
|
Hi, I have narrowed it down to a very specific problem. semantic-complete-self-insert will not work if the class has members starting from different letters e.g. class A { int aa; int bb; }; but it will work for cases such as: class B { int aa; int ab; }; when it can autocomplete the first letter. Any ideas? Thanks! Andrzej On Sun, Jan 29, 2012 at 3:21 PM, Andrzej Pronobis <a.p...@gm...> wrote: > Hi, > > I have recently switched to newtrunk which solved most of my previous > problems with CEDET. I experience one problem though. > semantic-complete-self-insert when bound to "." works properly for a > super simple case when the class is defined in the same file. However, > in more complex code, when "." is pressed emacs thinks for a while and > then no suggestions are shown. > > When I add a single letter after the "." and then use > semantic-complete-analyze-inline e.g. > Type a; > a.m<M-x semantic-complete-analyze-inline> > The suggestions are shown properly. > > How can I debug this case? > > Cheers, > Andrzej |
From: Andrzej P. <a.p...@gm...> - 2012-01-31 22:53:19
|
Hi again, Could you please suggest some ways of debugging semantic-complete-self-insert? I'm really trying to get this to work and I'm not that an experienced cedet user. Thanks! Andrzej On Tue, Jan 31, 2012 at 12:01 AM, Andrzej Pronobis <a.p...@gm...> wrote: > Hi, > > I have narrowed it down to a very specific problem. > semantic-complete-self-insert will not work if the class has members > starting from different letters e.g. > class A > { > int aa; > int bb; > }; > > but it will work for cases such as: > class B > { > int aa; > int ab; > }; > when it can autocomplete the first letter. > > Any ideas? > > Thanks! > Andrzej > > > > On Sun, Jan 29, 2012 at 3:21 PM, Andrzej Pronobis <a.p...@gm...> wrote: >> Hi, >> >> I have recently switched to newtrunk which solved most of my previous >> problems with CEDET. I experience one problem though. >> semantic-complete-self-insert when bound to "." works properly for a >> super simple case when the class is defined in the same file. However, >> in more complex code, when "." is pressed emacs thinks for a while and >> then no suggestions are shown. >> >> When I add a single letter after the "." and then use >> semantic-complete-analyze-inline e.g. >> Type a; >> a.m<M-x semantic-complete-analyze-inline> >> The suggestions are shown properly. >> >> How can I debug this case? >> >> Cheers, >> Andrzej |
From: Eric M. L. <eri...@gm...> - 2012-02-01 01:31:33
|
Hi, What is going on is that when there is no common prefix, the special Emacs overlay created to manage the inline completion as start==end. It goes into the inline completion engine, discovers that the point isn't "inside" the bounds of the overlay, and assumes you want to exit, and then exits the completion engine. I'm not sure what may have changed in the newer emacsen that may have caused the old code to behave this way. I've been fiddling in semantic-complete-post-command-hook to see what is going on and have been able to make it get partway through, but it still exits too soon. Here is a partial patch: === modified file 'lisp/cedet/semantic/complete.el' *** lisp/cedet/semantic/complete.el 2011-12-07 22:44:28 +0000 --- lisp/cedet/semantic/complete.el 2012-02-01 01:22:45 +0000 *************** *** 686,692 **** (cond ;; EXIT when we are no longer in a good place. ((or (not (eq b (current-buffer))) ! (<= (point) s) (> (point) e)) ;;(message "Exit: %S %S %S" s e (point)) (semantic-complete-inline-exit) --- 686,692 ---- (cond ;; EXIT when we are no longer in a good place. ((or (not (eq b (current-buffer))) ! (and (<= (point) s) (not (= s e))) (> (point) e)) ;;(message "Exit: %S %S %S" s e (point)) (semantic-complete-inline-exit) but it still doesn't work correctly for me. In theory, front-advance (nil) and rear-advance (t) when creating the overlay should allow this to work. Perhaps someone else on the list knows what may have changed in overlay behavior to cause this? Eric On 01/31/2012 05:52 PM, Andrzej Pronobis wrote: > Hi again, > > Could you please suggest some ways of debugging semantic-complete-self-insert? > I'm really trying to get this to work and I'm not that an experienced > cedet user. > > Thanks! > Andrzej > > > > On Tue, Jan 31, 2012 at 12:01 AM, Andrzej Pronobis<a.p...@gm...> wrote: >> Hi, >> >> I have narrowed it down to a very specific problem. >> semantic-complete-self-insert will not work if the class has members >> starting from different letters e.g. >> class A >> { >> int aa; >> int bb; >> }; >> >> but it will work for cases such as: >> class B >> { >> int aa; >> int ab; >> }; >> when it can autocomplete the first letter. >> >> Any ideas? >> >> Thanks! >> Andrzej >> >> >> >> On Sun, Jan 29, 2012 at 3:21 PM, Andrzej Pronobis<a.p...@gm...> wrote: >>> Hi, >>> >>> I have recently switched to newtrunk which solved most of my previous >>> problems with CEDET. I experience one problem though. >>> semantic-complete-self-insert when bound to "." works properly for a >>> super simple case when the class is defined in the same file. However, >>> in more complex code, when "." is pressed emacs thinks for a while and >>> then no suggestions are shown. >>> >>> When I add a single letter after the "." and then use >>> semantic-complete-analyze-inline e.g. >>> Type a; >>> a.m<M-x semantic-complete-analyze-inline> >>> The suggestions are shown properly. >>> >>> How can I debug this case? >>> >>> Cheers, >>> Andrzej > > ------------------------------------------------------------------------------ > Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel > |
From: Andrzej P. <a.p...@gm...> - 2012-02-02 11:46:47
|
Hi, Thanks! This fix seems to work for me. Please let me know if you want me to debug something more. Cheers, Andrzej On Wed, Feb 1, 2012 at 2:31 AM, Eric M. Ludlam <eri...@gm...> wrote: > Hi, > > What is going on is that when there is no common prefix, the special Emacs > overlay created to manage the inline completion as start==end. It goes into > the inline completion engine, discovers that the point isn't "inside" the > bounds of the overlay, and assumes you want to exit, and then exits the > completion engine. > > I'm not sure what may have changed in the newer emacsen that may have > caused the old code to behave this way. I've been fiddling in > semantic-complete-post-command-hook to see what is going on and have been > able to make it get partway through, but it still exits too soon. > > Here is a partial patch: > === modified file 'lisp/cedet/semantic/complete.el' > *** lisp/cedet/semantic/complete.el 2011-12-07 22:44:28 +0000 > --- lisp/cedet/semantic/complete.el 2012-02-01 01:22:45 +0000 > *************** > *** 686,692 **** > (cond > ;; EXIT when we are no longer in a good place. > ((or (not (eq b (current-buffer))) > ! (<= (point) s) > (> (point) e)) > ;;(message "Exit: %S %S %S" s e (point)) > (semantic-complete-inline-exit) > --- 686,692 ---- > (cond > ;; EXIT when we are no longer in a good place. > ((or (not (eq b (current-buffer))) > ! (and (<= (point) s) (not (= s e))) > (> (point) e)) > ;;(message "Exit: %S %S %S" s e (point)) > (semantic-complete-inline-exit) > > > but it still doesn't work correctly for me. > > In theory, front-advance (nil) and rear-advance (t) when creating the > overlay should allow this to work. Perhaps someone else on the list knows > what may have changed in overlay behavior to cause this? > > Eric > > > On 01/31/2012 05:52 PM, Andrzej Pronobis wrote: >> >> Hi again, >> >> Could you please suggest some ways of debugging >> semantic-complete-self-insert? >> I'm really trying to get this to work and I'm not that an experienced >> cedet user. >> >> Thanks! >> Andrzej >> >> >> >> On Tue, Jan 31, 2012 at 12:01 AM, Andrzej Pronobis<a.p...@gm...> >> wrote: >>> >>> Hi, >>> >>> I have narrowed it down to a very specific problem. >>> semantic-complete-self-insert will not work if the class has members >>> starting from different letters e.g. >>> class A >>> { >>> int aa; >>> int bb; >>> }; >>> >>> but it will work for cases such as: >>> class B >>> { >>> int aa; >>> int ab; >>> }; >>> when it can autocomplete the first letter. >>> >>> Any ideas? >>> >>> Thanks! >>> Andrzej >>> >>> >>> >>> On Sun, Jan 29, 2012 at 3:21 PM, Andrzej Pronobis<a.p...@gm...> >>> wrote: >>>> >>>> Hi, >>>> >>>> I have recently switched to newtrunk which solved most of my previous >>>> problems with CEDET. I experience one problem though. >>>> semantic-complete-self-insert when bound to "." works properly for a >>>> super simple case when the class is defined in the same file. However, >>>> in more complex code, when "." is pressed emacs thinks for a while and >>>> then no suggestions are shown. >>>> >>>> When I add a single letter after the "." and then use >>>> semantic-complete-analyze-inline e.g. >>>> Type a; >>>> a.m<M-x semantic-complete-analyze-inline> >>>> The suggestions are shown properly. >>>> >>>> How can I debug this case? >>>> >>>> Cheers, >>>> Andrzej >> >> >> >> ------------------------------------------------------------------------------ >> Keep Your Developer Skills Current with LearnDevNow! >> The most comprehensive online learning library for Microsoft developers >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> Metro Style Apps, more. Free future releases when you subscribe now! >> http://p.sf.net/sfu/learndevnow-d2d >> _______________________________________________ >> Cedet-devel mailing list >> Ced...@li... >> https://lists.sourceforge.net/lists/listinfo/cedet-devel >> > |
From: Andrew B. <abu...@br...> - 2012-12-20 13:46:50
|
On 20/12/2012 1:11 PM, Andrew Burgess wrote: > Apologies for replying to such an old thread I just wanted to add... > > On 01/02/2012 1:31 AM, Eric M. Ludlam wrote: >> What is going on is that when there is no common prefix, the special >> Emacs overlay created to manage the inline completion as start==end. It >> goes into the inline completion engine, discovers that the point isn't >> "inside" the bounds of the overlay, and assumes you want to exit, and >> then exits the completion engine. >> >> I'm not sure what may have changed in the newer emacsen that may have >> caused the old code to behave this way. I've been fiddling in >> semantic-complete-post-command-hook to see what is going on and have >> been able to make it get partway through, but it still exits too soon. >> >> Here is a partial patch: >> === modified file 'lisp/cedet/semantic/complete.el' >> *** lisp/cedet/semantic/complete.el 2011-12-07 22:44:28 +0000 >> --- lisp/cedet/semantic/complete.el 2012-02-01 01:22:45 +0000 >> *************** >> *** 686,692 **** >> (cond >> ;; EXIT when we are no longer in a good place. >> ((or (not (eq b (current-buffer))) >> ! (<= (point) s) >> (> (point) e)) >> ;;(message "Exit: %S %S %S" s e (point)) >> (semantic-complete-inline-exit) >> --- 686,692 ---- >> (cond >> ;; EXIT when we are no longer in a good place. >> ((or (not (eq b (current-buffer))) >> ! (and (<= (point) s) (not (= s e))) >> (> (point) e)) >> ;;(message "Exit: %S %S %S" s e (point)) >> (semantic-complete-inline-exit) >> >> >> but it still doesn't work correctly for me. > > > At that point my complete lack of knowledge about the internals of cedet > means I can't offset any better solutions. > Ok, so a quick hack later and I have a patch proposal. There's probably better ways to solve this but at least this is a start. For me: - semantic-complete-self-insert now works even when there's no common prefix. - if I type some characters, then delete them back to a state where I have empty inline completion text, then inline completion exits. Let me know if there's anything else I could do to help with this patch. Thanks Andrew --- complete.el.orig 2012-12-20 13:29:21.787691000 +0000 +++ complete.el 2012-12-20 13:40:40.837095000 +0000 @@ -681,13 +681,15 @@ a reasonable distance." (let ((s (semantic-overlay-start semantic-complete-inline-overlay)) (e (semantic-overlay-end semantic-complete-inline-overlay)) (b (semantic-overlay-buffer semantic-complete-inline-overlay)) + (l (semantic-overlay-get semantic-complete-inline-overlay 'txt-length)) (txt nil) ) (cond ;; EXIT when we are no longer in a good place. ((or (not (eq b (current-buffer))) (< (point) s) - (> (point) e)) + (> (point) e) + (and (= s e) l (> l 0))) ;;(message "Exit: %S %S %S" s e (point)) (semantic-complete-inline-exit) ) @@ -708,7 +710,12 @@ a reasonable distance." nil ) (t - ;; Else, show completions now + ;; Else, + ;; Store the length of the user supplied text + (semantic-overlay-put semantic-complete-inline-overlay + 'txt-length + (length txt)) + ;; Show completions now (semantic-complete-inline-force-display) )))) |
From: Andrew B. <abu...@br...> - 2012-12-20 13:11:54
|
Apologies for replying to such an old thread I just wanted to add... On 01/02/2012 1:31 AM, Eric M. Ludlam wrote: > What is going on is that when there is no common prefix, the special > Emacs overlay created to manage the inline completion as start==end. It > goes into the inline completion engine, discovers that the point isn't > "inside" the bounds of the overlay, and assumes you want to exit, and > then exits the completion engine. > > I'm not sure what may have changed in the newer emacsen that may have > caused the old code to behave this way. I've been fiddling in > semantic-complete-post-command-hook to see what is going on and have > been able to make it get partway through, but it still exits too soon. > > Here is a partial patch: > === modified file 'lisp/cedet/semantic/complete.el' > *** lisp/cedet/semantic/complete.el 2011-12-07 22:44:28 +0000 > --- lisp/cedet/semantic/complete.el 2012-02-01 01:22:45 +0000 > *************** > *** 686,692 **** > (cond > ;; EXIT when we are no longer in a good place. > ((or (not (eq b (current-buffer))) > ! (<= (point) s) > (> (point) e)) > ;;(message "Exit: %S %S %S" s e (point)) > (semantic-complete-inline-exit) > --- 686,692 ---- > (cond > ;; EXIT when we are no longer in a good place. > ((or (not (eq b (current-buffer))) > ! (and (<= (point) s) (not (= s e))) > (> (point) e)) > ;;(message "Exit: %S %S %S" s e (point)) > (semantic-complete-inline-exit) > > > but it still doesn't work correctly for me. I have also run into this issue when updating from cedet-1.01 to cedet-1.1. I tried this patch but as you suggest I'm seeing strange issues, for example in the following code: struct bar { int aa; int bb; }; int main () { bar b; b. /* <-- try to complete here */ } After typing the "." in "b." I get the completion up, but if I move point up (I'd expect this to exit completion mode) the completion then follows the point around; this kind-of makes sense as 's == e' so we don't exit completion mode. Next I took a look at the cedet-1.0.1 code, interestingly the code used to be "(< (point) s)" - if I put this in /instead/ of the above patch I get the old behaviour back. Next a check online reveals: http://cedet.bzr.sourceforge.net/bzr/cedet/code/trunk/revision/8112.1.117 as the commit that made the change. At that point my complete lack of knowledge about the internals of cedet means I can't offset any better solutions. Thanks, Andrew > > In theory, front-advance (nil) and rear-advance (t) when creating the > overlay should allow this to work. Perhaps someone else on the list > knows what may have changed in overlay behavior to cause this? > > Eric > > On 01/31/2012 05:52 PM, Andrzej Pronobis wrote: >> Hi again, >> >> Could you please suggest some ways of debugging semantic-complete-self-insert? >> I'm really trying to get this to work and I'm not that an experienced >> cedet user. >> >> Thanks! >> Andrzej >> >> >> >> On Tue, Jan 31, 2012 at 12:01 AM, Andrzej Pronobis<a.p...@gm...> wrote: >>> Hi, >>> >>> I have narrowed it down to a very specific problem. >>> semantic-complete-self-insert will not work if the class has members >>> starting from different letters e.g. >>> class A >>> { >>> int aa; >>> int bb; >>> }; >>> >>> but it will work for cases such as: >>> class B >>> { >>> int aa; >>> int ab; >>> }; >>> when it can autocomplete the first letter. >>> >>> Any ideas? >>> >>> Thanks! >>> Andrzej >>> >>> >>> >>> On Sun, Jan 29, 2012 at 3:21 PM, Andrzej Pronobis<a.p...@gm...> wrote: >>>> Hi, >>>> >>>> I have recently switched to newtrunk which solved most of my previous >>>> problems with CEDET. I experience one problem though. >>>> semantic-complete-self-insert when bound to "." works properly for a >>>> super simple case when the class is defined in the same file. However, >>>> in more complex code, when "." is pressed emacs thinks for a while and >>>> then no suggestions are shown. >>>> >>>> When I add a single letter after the "." and then use >>>> semantic-complete-analyze-inline e.g. >>>> Type a; >>>> a.m<M-x semantic-complete-analyze-inline> >>>> The suggestions are shown properly. >>>> >>>> How can I debug this case? >>>> >>>> Cheers, >>>> Andrzej >> >> ------------------------------------------------------------------------------ >> Keep Your Developer Skills Current with LearnDevNow! >> The most comprehensive online learning library for Microsoft developers >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> Metro Style Apps, more. Free future releases when you subscribe now! >> http://p.sf.net/sfu/learndevnow-d2d >> _______________________________________________ >> Cedet-devel mailing list >> Ced...@li... >> https://lists.sourceforge.net/lists/listinfo/cedet-devel >> > > ------------------------------------------------------------------------------ > Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel > > |
From: Eric M. L. <er...@si...> - 2013-01-04 02:48:09
|
Hi Andrew, Thanks for the patch. I experimented with this for a while, and analyzed old changes to this area. I think I have a different change that accommodates the original intent, the bug David fixed that introduced the issue you saw, and your patch. With the inline completion that starts when you press '.', it seems important to be able to delete the entire prefix and start over, which is a little different from what your patch does. It is bad, however, to delete the '.', as that should end the completion, which David's patch was trying to fix. To handle both, I added a new value to the overlay which is the original starting position of the overlay. The overlay start never moves through a completion, so if it were to move, we should exit the completion mode. I found this logic worked robustly in the example you provided. I hope it will work well for you also. Let me know if it doesn't. Thanks Eric On 12/20/2012 08:45 AM, Andrew Burgess wrote: > On 20/12/2012 1:11 PM, Andrew Burgess wrote: >> Apologies for replying to such an old thread I just wanted to add... >> >> On 01/02/2012 1:31 AM, Eric M. Ludlam wrote: >>> What is going on is that when there is no common prefix, the special >>> Emacs overlay created to manage the inline completion as start==end. It >>> goes into the inline completion engine, discovers that the point isn't >>> "inside" the bounds of the overlay, and assumes you want to exit, and >>> then exits the completion engine. >>> >>> I'm not sure what may have changed in the newer emacsen that may have >>> caused the old code to behave this way. I've been fiddling in >>> semantic-complete-post-command-hook to see what is going on and have >>> been able to make it get partway through, but it still exits too soon. >>> >>> Here is a partial patch: >>> === modified file 'lisp/cedet/semantic/complete.el' >>> *** lisp/cedet/semantic/complete.el 2011-12-07 22:44:28 +0000 >>> --- lisp/cedet/semantic/complete.el 2012-02-01 01:22:45 +0000 >>> *************** >>> *** 686,692 **** >>> (cond >>> ;; EXIT when we are no longer in a good place. >>> ((or (not (eq b (current-buffer))) >>> ! (<= (point) s) >>> (> (point) e)) >>> ;;(message "Exit: %S %S %S" s e (point)) >>> (semantic-complete-inline-exit) >>> --- 686,692 ---- >>> (cond >>> ;; EXIT when we are no longer in a good place. >>> ((or (not (eq b (current-buffer))) >>> ! (and (<= (point) s) (not (= s e))) >>> (> (point) e)) >>> ;;(message "Exit: %S %S %S" s e (point)) >>> (semantic-complete-inline-exit) >>> >>> >>> but it still doesn't work correctly for me. >> >> >> At that point my complete lack of knowledge about the internals of cedet >> means I can't offset any better solutions. >> > > Ok, so a quick hack later and I have a patch proposal. There's probably better ways to solve this but at least this is a start. > > For me: > - semantic-complete-self-insert now works even when there's no common prefix. > - if I type some characters, then delete them back to a state where I have empty inline completion text, then inline completion exits. > > Let me know if there's anything else I could do to help with this patch. > > > Thanks > Andrew > > > --- complete.el.orig 2012-12-20 13:29:21.787691000 +0000 > +++ complete.el 2012-12-20 13:40:40.837095000 +0000 > @@ -681,13 +681,15 @@ a reasonable distance." > (let ((s (semantic-overlay-start semantic-complete-inline-overlay)) > (e (semantic-overlay-end semantic-complete-inline-overlay)) > (b (semantic-overlay-buffer semantic-complete-inline-overlay)) > + (l (semantic-overlay-get semantic-complete-inline-overlay 'txt-length)) > (txt nil) > ) > (cond > ;; EXIT when we are no longer in a good place. > ((or (not (eq b (current-buffer))) > (< (point) s) > - (> (point) e)) > + (> (point) e) > + (and (= s e) l (> l 0))) > ;;(message "Exit: %S %S %S" s e (point)) > (semantic-complete-inline-exit) > ) > @@ -708,7 +710,12 @@ a reasonable distance." > nil > ) > (t > - ;; Else, show completions now > + ;; Else, > + ;; Store the length of the user supplied text > + (semantic-overlay-put semantic-complete-inline-overlay > + 'txt-length > + (length txt)) > + ;; Show completions now > (semantic-complete-inline-force-display) > > )))) > > > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel > |
From: Andrew B. <abu...@br...> - 2013-01-07 10:53:22
|
On 04/01/2013 2:47 AM, Eric M. Ludlam wrote: > Thanks for the patch. I experimented with this for a while, and > analyzed old changes to this area. > > I think I have a different change that accommodates the original intent, > the bug David fixed that introduced the issue you saw, and your patch. I tested out your new fix and this works fine for me. Thanks for taking the time to look at this. Cheers, Andrew |