Thread: [CEDET-devel] Info-directory-list: use add-to-list instead of setq?
Brought to you by:
zappo
From: Mandar M. <man...@gm...> - 2013-04-23 14:24:53
|
I suddenly discovered my Info-directory-list variable was broken. It didn't have a path that I'd added in the INFOPATH environment variable. I think a setq in cedet-devel-load.el (bzr version of CEDET) is responsible. After making the change below -- I've just copied the corresponding bit from cedet-1.1, but don't know whether this is the right thing to do -- things are working again, so I thought I'd report. Not subscribed to the list. It'd be great if you could please cc me in on replies. Thanks, Mandar. --- Output of "bzr diff" --- === modified file 'cedet-devel-load.el' --- cedet-devel-load.el 2013-04-06 03:12:12 +0000 +++ cedet-devel-load.el 2013-04-23 11:26:23 +0000 @@ -56,9 +56,14 @@ (load (expand-file-name "lisp/cedet/cogre/loaddefs.el" CEDETDIR) nil t t) (load (expand-file-name "lisp/cedet/srecode/loaddefs.el" CEDETDIR) nil t t) (load (expand-file-name "lisp/cedet/semantic/loaddefs.el" CEDETDIR) nil t t) - (setq Info-directory-list - (cons (expand-file-name "doc/info" CEDETDIR) - Info-default-directory-list))) + (let ((fulldocpath (expand-file-name "doc/info" CEDETDIR))) + (if (featurep 'info) + (progn + (condition-case nil ; Not all emacs versions have this. + (info-initialize) + (error nil)) + (add-to-list 'Info-directory-list fulldocpath)) + (add-to-list 'Info-default-directory-list fulldocpath)))) ;; Load in COMPAT code - This is because NEW CEDET code may use this ;; for compatibility reasons, but Emacs integrated code removes it. |
From: Eric M. L. <er...@si...> - 2013-05-07 00:42:52
|
Hi Mandar, Thanks for the patch. I think you identified the right stuff in that this needs to be able to run before info loads. I worry though about changing the default info path though. Maybe the right thing is to have an eval-after-load call to just update the info load path after other configurations run. Perhaps someone who is more familiar with Info init on the mailing list can lend some advice? Eric On 04/23/2013 07:42 AM, Mandar Mitra wrote: > I suddenly discovered my Info-directory-list variable was broken. It > didn't have a path that I'd added in the INFOPATH environment variable. > > I think a setq in cedet-devel-load.el (bzr version of CEDET) is > responsible. After making the change below -- I've just copied the > corresponding bit from cedet-1.1, but don't know whether this is the > right thing to do -- things are working again, so I thought I'd report. > > Not subscribed to the list. It'd be great if you could please cc me in > on replies. > > Thanks, > Mandar. > > --- Output of "bzr diff" --- > > === modified file 'cedet-devel-load.el' > --- cedet-devel-load.el 2013-04-06 03:12:12 +0000 > +++ cedet-devel-load.el 2013-04-23 11:26:23 +0000 > @@ -56,9 +56,14 @@ > (load (expand-file-name "lisp/cedet/cogre/loaddefs.el" CEDETDIR) nil t t) > (load (expand-file-name "lisp/cedet/srecode/loaddefs.el" CEDETDIR) nil t t) > (load (expand-file-name "lisp/cedet/semantic/loaddefs.el" CEDETDIR) nil t t) > - (setq Info-directory-list > - (cons (expand-file-name "doc/info" CEDETDIR) > - Info-default-directory-list))) > + (let ((fulldocpath (expand-file-name "doc/info" CEDETDIR))) > + (if (featurep 'info) > + (progn > + (condition-case nil ; Not all emacs versions have this. > + (info-initialize) > + (error nil)) > + (add-to-list 'Info-directory-list fulldocpath)) > + (add-to-list 'Info-default-directory-list fulldocpath)))) > > ;; Load in COMPAT code - This is because NEW CEDET code may use this > ;; for compatibility reasons, but Emacs integrated code removes it. > > > ------------------------------------------------------------------------------ > Try New Relic Now& We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app,& servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr > _______________________________________________ > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel > |