Also from me a bunch of Thanks fpr preparing the stable release!! :-)

Klaus


-----Ursprüngliche Nachricht-----
Von: cedet-devel-admin@lists.sourceforge.net im Auftrag von David PONCE
Gesendet: Mi 08.02.2006 10:25
An: eric@siege-engine.com
Cc: cedet-devel@lists.sourceforge.net
Betreff: [CEDET-devel] Problem with latest update of inversion.el

Hi Eric,

I just updated my local copy of CEDET from CVS, and noticed that the
version 1.0 is coming! :-)

However there is a problem with the following change to inversion.el:

(inversion-add-to-load-path): Throw error if revision mismatch.

With that change it is no more possible to override an older version
of a CEDET package found in the `load-path'.  This prevent loading
CEDET on CVS Emacs 22 which includes speedbar version 1.0.  Now
'inversion-add-to-load-path' signal an error instead of overriding
speedbar 1.0 with the CEDET's one at version 1.0.1.  IMO, this is a
regression.  WDYT of just issuing a warning instead?  Below is a patch
that just does that.

Anyway, thanks for preparing the release!

David

2006-02-08  David Ponce  <david@dponce.com>

        * cedet/common/inversion.el

        (inversion-add-to-load-path): Don't signal an error when shadowing
        an outdated package.

Index: inversion.el
===================================================================
RCS file: /cvsroot/cedet/cedet/common/inversion.el,v
retrieving revision 1.27
diff -c -r1.27 inversion.el
*** inversion.el        8 Feb 2006 04:16:13 -0000       1.27
--- inversion.el        8 Feb 2006 09:22:25 -0000
***************
*** 367,392 ****
    (let ((ver (inversion-find-version package)))
      ;; If PACKAGE not found or a bad version already in `load-path',
      ;; prepend the new PACKAGE path, so it will be loaded first.
!     (when ver
!       (let ((icv (inversion-check-version (car ver) (cdr ver) minimum)))
!       (if icv
!           (error "Package %s minimum version requirement %s not met with available version %s"
!                  package minimum (car ver)))))
!     (let* ((default-directory
!            (or installdir
!                (expand-file-name (format "./%s" package))))
!          subdir)
!       (when (file-directory-p default-directory)
!       ;; Add SUBDIRS
!       (while subdirs
!         (setq subdir  (expand-file-name (car subdirs))
!               subdirs (cdr subdirs))
!         (when (file-directory-p subdir)
!           (message "%S added to `load-path'" subdir)
!           (add-to-list 'load-path subdir)))
!       ;; Add the main path
!       (message "%S added to `load-path'" default-directory)
!       (add-to-list 'load-path default-directory)))))
 
  ;;; Inversion tests
  ;;
--- 367,393 ----
    (let ((ver (inversion-find-version package)))
      ;; If PACKAGE not found or a bad version already in `load-path',
      ;; prepend the new PACKAGE path, so it will be loaded first.
!     (when (or (not ver)
!               (and
!                (inversion-check-version (car ver) (cdr ver) minimum)
!                (message "Outdated %s %s shadowed to meet minimum version %s"
!                         package (car ver) minimum)
!                t))
!       (let* ((default-directory
!                (or installdir
!                    (expand-file-name (format "./%s" package))))
!              subdir)
!         (when (file-directory-p default-directory)
!           ;; Add SUBDIRS
!           (while subdirs
!             (setq subdir  (expand-file-name (car subdirs))
!                   subdirs (cdr subdirs))
!             (when (file-directory-p subdir)
!               (message "%S added to `load-path'" subdir)
!               (add-to-list 'load-path subdir)))
!           ;; Add the main path
!           (message "%S added to `load-path'" default-directory)
!           (add-to-list 'load-path default-directory))))))
 
  ;;; Inversion tests
  ;;




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Cedet-devel mailing list
Cedet-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cedet-devel