Re: [Cdrdao-devel] A patch adding a couple of minor features to cdrdao

[Eric B. <eri...@ya...>]

That's fine, but I think --query is a confusing option name. Does 
--query mean "perform the query and print the result" or does it mean 
"don't perform the query, just print what you would have submitted"? 
It's the latter, but the option name doesn't convey that distinction. 
Also, this functionality overlaps closely with the "read-cddb" command. 
If you are going to actually query a CDDB server, this command should 
also have the --cddb-servers and --cddb-timeout options as well. Then it 
starts getting complicated. Perhaps it would make more sense to absorb 
this functionality into the "read-cddb" command, perhaps by using "-" as 
the --cddb-directory option to mean "print the result rather than write 
it to a file". Then perhaps "discid" should be renamed 
"cddb-query-string" and revert to its old simple behavior.

Denis Leroy wrote:

>I've checked in your patch, but i made the discid command actually do
>the CDDB query and print out the result. If you run it with the
>'--query' option, it does exactly what your version did and only prints
>the CDDB query. I thought this would be a good compromise.
>
>thanks for the patch, keep'em coming :-)
>-denis
>
>--- Eric Benson <eri...@ya...> wrote:
>  
>
>>>>This patch adds a "discid" command that prints the CDDB query
>>>>        
>>>>
>>string
>>    
>>
>>>>for 
>>>>the CD in the drive, and it adds --eject as an option to the
>>>>        
>>>>
>>"unlock"
>>    
>>
>>>>command. These are both pretty simple and I've been using them for
>>>>over 
>>>>a year myself. It would be great if they get added to cdrdao's CVS 
>>>>mainline so other folks can use them, plus it would save me from
>>>>having to apply them myself!
>>>>        
>>>>
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by: IBM Linux Tutorials
>Free Linux tutorial presented by Daniel Robbins, President and CEO of
>GenToo technologies. Learn everything from fundamentals to system
>administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>_______________________________________________
>Cdrdao-devel mailing list
>Cdr...@li...
>https://lists.sourceforge.net/lists/listinfo/cdrdao-devel
>
>  
>