Re: [Cdrdao-devel] gcdmaster changes for 3/8/01

[Andreas M. <an...@da...>]

Manuel Clos wrote:
> 
> Here is what I just commited to CVS:
> 
> * Changed the play/stop button to a "play | stop" toolbar, this prevents
> the "playing again" problem when you hit the button twice to stop the
> playing and it starts again...
> * moved the play and playCallback funcs to AudioCDProject
> * added a playStop func to audioCDView and AudioCDProject
> * got some icons from tcd for the play toolbar
> * AudioCDView is no more a friendly class of AudioCDChild (read: removed
> bad hack)
> * Added #define UPD_PLAY_STATUS      0x00000800   to guiUpdate.h
> * now AudioCDView uses UPD_PLAY_STATUS to draw the cursor and update the
> buttons, ...
> 
> My idea is to create a new cursor for playing, and show the position in
> the play toolbar. This way we can set the marker even while playing, set
> selections, zoom, ... we just need to care of funcs that _change_ the
> Toc object.
> 
> Why don't we use a fixed timeout for playing instead of the idle timeout ?

It would be almost impossible to find the correct timeout value. If it
is too small the timout will come before the playing function has
returned. It it is too big the playing will be jumpy. I think the
idle signal is the right choice. What advantage would you expect from
the fixed timout signal?

> Also, why are we doing this?:
> 
> (now this is in AudioCDProject::AudioCDProject)
>    soundInterface_ = new SoundIF;
>    playBuffer_ = new Sample[playBurst_];
>    soundInterface_ = NULL;
> 
> we create a SoundIF and then we lost the reference... why?

That's of course an error; probably an relict from some code changes.
You can remove the allocation at this place.

Andreas
-- 
Andreas Mueller                  Tel: +49 89 67808848
Ramsmeierstr. 1                Email: an...@da...
85579 Neubiberg, Germany