Okay, no problem.

Will look into it.

J

On 8 Mar 2014, at 14:54, Egon Willighagen <egonw@users.sf.net> wrote:

John, slowly I am finding my way around in the new build system :) See my blog, and thanks for your pointers!

With this patch, I do see a few regressions:

-Tests run: 15, Failures: 0, Errors: 0, Skipped: 0|org.openscience.cdk.graph.CyclesTest
+Tests run: 15, Failures: 0, Errors: 1, Skipped: 0|org.openscience.cdk.graph.CyclesTest

-Tests run: 13, Failures: 0, Errors: 0, Skipped: 0|org.openscience.cdk.graph.TripletShortCyclesTest
+Tests run: 13, Failures: 0, Errors: 11, Skipped: 0|org.openscience.cdk.graph.TripletShortCyclesTest

The patches looks fine to me otherwise...

Can you look at these regressions?


[patches:#742] Cycles updates for circular fp

Status: open
Group: Needs_Review
Created: Mon Feb 10, 2014 12:23 PM UTC by John May
Last Updated: Mon Feb 10, 2014 12:23 PM UTC
Owner: nobody

Adds some simple functionality updates to mimic the CDD ring perception. Was planned already but made sense to patch now : commits on 10th feb.

https://github.com/johnmay/cdk/compare/cdk:master...feature%2Fcycles-filter?expand=1


Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/cdk/patches/742/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/