#593 Corrected and tidied up comparators for JDK 1.7

Accepted
closed
nobody
JDK 1.7 (1)
cdk-1.4.x
9
2012-12-12
2012-11-29
John May
No

Discussion

  • John May

    John May - 2012-11-29
    • labels: --> JDK 1.7
     
  • John May

    John May - 2012-12-06
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -3,7 +3,7 @@
     The commits are:
      - https://github.com/johnmay/cdk/commit/02672b6b0eabf51c30b92b0e503641c8367944b9
      - https://github.com/johnmay/cdk/commit/ffabca18514032268c25853664bac52075c9dffd (Stephan's HOSECode patch)
    - - https://github.com/johnmay/cdk/commit/5bf4c219a399644378f36a884e71ef9b3b3f6d74
    + - https://github.com/johnmay/cdk/commit/5bf4c219a399644378f36a884e71ef9b3b3f6d74 (pushed)
    
     Also there was some clean up needed in one of the fingerprint comparators but I'd already fixed it in \[[patch:551](https://sourceforge.net/p/cdk/patches/551/)\] so I left that as it was.
    
     
  • John May

    John May - 2012-12-06
    • milestone: Needs_Review --> Needs_Revision
     
  • John May

    John May - 2012-12-06

    Just spotted some more clean up I can do

     
  • John May

    John May - 2012-12-06
     
  • John May

    John May - 2012-12-06
    • milestone: Needs_Revision --> Needs_Review
     
  • John May

    John May - 2012-12-10
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,9 +1,2 @@
    -Patches are on [master+](https://github.com/johnmay/cdk/commits/master%2B)
    +Patches are on [patch/cdk-1.4.x/comparators](https://github.com/johnmay/cdk/tree/patch/cdk-1.4.x/comparators)
    
    -The commits are:
    - - https://github.com/johnmay/cdk/commit/02672b6b0eabf51c30b92b0e503641c8367944b9
    - - https://github.com/johnmay/cdk/commit/ffabca18514032268c25853664bac52075c9dffd (Stephan's HOSECode patch)
    - - https://github.com/johnmay/cdk/commit/5bf4c219a399644378f36a884e71ef9b3b3f6d74 (pushed)
    -
    -Also there was some clean up needed in one of the fingerprint comparators but I'd already fixed it in \[[patch:551](https://sourceforge.net/p/cdk/patches/551/)\] so I left that as it was.
    -
    
     
  • John May

    John May - 2012-12-10
    • redone these patches on cdk-1.4.x.
    • split out the commits so the first commits adds the generics to all comparators and the rest is a single commit per comparator
    • explained a bit more in the commit message was wrong/corrected
     
  • Egon Willighagen

    7/8 patches applied and pushed to cdk-1.4.x.

     
  • John May

    John May - 2012-12-12

    Is it just the public method I need to fix?

     
  • Egon Willighagen

    Yeah, think so.

     
  • Egon Willighagen

    Thanx, looks good. Applied and pushed.

     
  • Egon Willighagen

    • status: open --> closed
    • milestone: Needs_Review --> Accepted
     
  • Egon Willighagen

    • branch: master --> cdk-1.4.x
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks